github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5795] [MERGED] Re-implement useDisplayPayee to use context to minimize SQL queries #24734

New Issue
Closed
opened 2026-04-16 18:12:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 18:12:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5795
Author: @joel-jeremy
Created: 9/26/2025
Status: ✅ Merged
Merged: 11/6/2025
Merged by: @joel-jeremy

Base: master ← Head: DisplayPayeeContext

📝 Commits (10+)

  • 235db7a Re-implement useDisplayPayee to use context to minimize SQL queries
  • 9b24996 Rename ScrollProvider to useScrollListener and move to hooks folder
  • 34d9627 Add DisplayPayeeContextProvider to TransactionsTable.test.tsx
  • ed4bd36 Set higher page count
  • 7f4d2a6 Fix payee autocomplete search
  • 497fdbe [autofix.ci] apply automated fixes
  • c8ad774 Fix highlight of Create payee
  • def2797 Show search if there are 100 payees
  • a34499e Cleanup
  • d048f02 Rename to DisplayPayeeProvider

📊 Changes

24 files changed (+661 additions, -468 deletions)

View changed files

📝 packages/component-library/src/Popover.tsx (+1 -0)
📝 packages/desktop-client/e2e/page-models/account-page.ts (+37 -13)
➕ packages/desktop-client/e2e/page-models/edit-rule-modal.ts (+171 -0)
📝 packages/desktop-client/e2e/page-models/rules-page.ts (+9 -139)
➕ packages/desktop-client/e2e/page-models/schedule-edit-modal.ts (+78 -0)
📝 packages/desktop-client/e2e/page-models/schedules-page.ts (+4 -35)
📝 packages/desktop-client/e2e/rules.test.ts (+6 -2)
📝 packages/desktop-client/e2e/schedules.test.ts (+12 -4)
📝 packages/desktop-client/src/components/FinancesApp.tsx (+1 -1)
📝 packages/desktop-client/src/components/Modals.tsx (+2 -2)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+4 -4)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx (+1 -2)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx (+71 -77)
📝 packages/desktop-client/src/components/filters/PayeeFilter.tsx (+5 -8)
📝 packages/desktop-client/src/components/mobile/MobileNavTabs.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx (+1 -1)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionListWithBalances.tsx (+5 -4)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+5 -1)
📝 packages/desktop-client/src/components/schedules/ScheduleEditModal.tsx (+2 -2)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+49 -39)

...and 4 more files

📄 Description

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5795 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 9/26/2025 **Status:** ✅ Merged **Merged:** 11/6/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `DisplayPayeeContext` --- ### 📝 Commits (10+) - [`235db7a`](https://github.com/actualbudget/actual/commit/235db7aa2c74e1cb8b7b865c47a1a913b89fd2d9) Re-implement useDisplayPayee to use context to minimize SQL queries - [`9b24996`](https://github.com/actualbudget/actual/commit/9b24996aed3f1aeed3adb2431b6b567bcd116bb5) Rename ScrollProvider to useScrollListener and move to hooks folder - [`34d9627`](https://github.com/actualbudget/actual/commit/34d9627d04c2420aaefe73e8e6bc57a59376bfa0) Add DisplayPayeeContextProvider to TransactionsTable.test.tsx - [`ed4bd36`](https://github.com/actualbudget/actual/commit/ed4bd36dbaca8b94675865744f2b3947c0b07103) Set higher page count - [`7f4d2a6`](https://github.com/actualbudget/actual/commit/7f4d2a630484e7b72dbcdb38feeace2d5301da34) Fix payee autocomplete search - [`497fdbe`](https://github.com/actualbudget/actual/commit/497fdbedb3e52b763a8dc849b740b7e2fc2c8bf1) [autofix.ci] apply automated fixes - [`c8ad774`](https://github.com/actualbudget/actual/commit/c8ad77488bfc2ec502387b08271898775d358755) Fix highlight of Create payee - [`def2797`](https://github.com/actualbudget/actual/commit/def27979e4c83c61a0505e3fdf911ca8e8ff23de) Show search if there are 100 payees - [`a34499e`](https://github.com/actualbudget/actual/commit/a34499e7de8aeeaa557f974d70d0aec01949bde7) Cleanup - [`d048f02`](https://github.com/actualbudget/actual/commit/d048f02527bc197cf2883ae5a4f67dfdd446009b) Rename to DisplayPayeeProvider ### 📊 Changes **24 files changed** (+661 additions, -468 deletions) <details> <summary>View changed files</summary> 📝 `packages/component-library/src/Popover.tsx` (+1 -0) 📝 `packages/desktop-client/e2e/page-models/account-page.ts` (+37 -13) ➕ `packages/desktop-client/e2e/page-models/edit-rule-modal.ts` (+171 -0) 📝 `packages/desktop-client/e2e/page-models/rules-page.ts` (+9 -139) ➕ `packages/desktop-client/e2e/page-models/schedule-edit-modal.ts` (+78 -0) 📝 `packages/desktop-client/e2e/page-models/schedules-page.ts` (+4 -35) 📝 `packages/desktop-client/e2e/rules.test.ts` (+6 -2) 📝 `packages/desktop-client/e2e/schedules.test.ts` (+12 -4) 📝 `packages/desktop-client/src/components/FinancesApp.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/Modals.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+4 -4) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.test.tsx` (+1 -2) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.tsx` (+71 -77) 📝 `packages/desktop-client/src/components/filters/PayeeFilter.tsx` (+5 -8) 📝 `packages/desktop-client/src/components/mobile/MobileNavTabs.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionList.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionListWithBalances.tsx` (+5 -4) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+5 -1) 📝 `packages/desktop-client/src/components/schedules/ScheduleEditModal.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+49 -39) _...and 4 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:12:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#24734
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?