github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #5139] [CLOSED] 🐛 [Bug] No longer need to click twice to edit transaction fields on mobile #24388

New Issue
Closed
opened 2026-04-16 18:01:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 18:01:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5139
Author: @alecbakholdin
Created: 6/11/2025
Status: ❌ Closed

Base: master ← Head: 4282-double-tap-for-new-transaction

📝 Commits (8)

  • f61bf72 Changed TransactionEdit behavior for mobile
  • 926b3b1 removed console.log
  • ca43494 Removed log and unused field
  • c24a249 updated playwright config to output html artifact
  • c79c9e7 undid playwright change
  • b9d5d4c Update VRT
  • 2c43ca2 Merge branch 'master' into 4282-double-tap-for-new-transaction
  • a838dcc Added a "solution" for the out of sync problem

📊 Changes

9 files changed (+40 additions, -64 deletions)

View changed files

📝 packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx (+26 -60)
📝 packages/desktop-client/src/hooks/useSingleActiveEditForm.tsx (+8 -4)
➕ upcoming-release-notes/5139.md (+6 -0)

📄 Description

Closes #4282

Focus for the mobile amount field was being tracked in two locations with a local useState() and the useSingleActiveEditForm hook. Changed the behavior of the hook and also stopped the other fields from being disabled when a field is being edited. This allows single-click navigation from the amount field (the only problem child).

Would like someone with an iPhone to verify this still works properly as there is mention of iOS being a problem in the implementation

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5139 **Author:** [@alecbakholdin](https://github.com/alecbakholdin) **Created:** 6/11/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `4282-double-tap-for-new-transaction` --- ### 📝 Commits (8) - [`f61bf72`](https://github.com/actualbudget/actual/commit/f61bf728652d55725ef91829b8613e12ba3532c8) Changed TransactionEdit behavior for mobile - [`926b3b1`](https://github.com/actualbudget/actual/commit/926b3b1f487ae150be96f111d3b98618990a74a5) removed console.log - [`ca43494`](https://github.com/actualbudget/actual/commit/ca434943d8c7dbc6537019053e4eece3b32238f1) Removed log and unused field - [`c24a249`](https://github.com/actualbudget/actual/commit/c24a24906fc27baa65dd44a6c0130db2a084e548) updated playwright config to output html artifact - [`c79c9e7`](https://github.com/actualbudget/actual/commit/c79c9e75ed718db851fd22f0945af372c3bdb4ac) undid playwright change - [`b9d5d4c`](https://github.com/actualbudget/actual/commit/b9d5d4ca9699f91ba583f597d3b28a9d58847972) Update VRT - [`2c43ca2`](https://github.com/actualbudget/actual/commit/2c43ca257e0385040694fe877e49d18ed814b18d) Merge branch 'master' into 4282-double-tap-for-new-transaction - [`a838dcc`](https://github.com/actualbudget/actual/commit/a838dcc9e351ab9d54d8dd7f6c5755d9a4d59bd6) Added a "solution" for the out of sync problem ### 📊 Changes **9 files changed** (+40 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-from-accounts-id-page-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/transactions.mobile.test.ts-snapshots/Mobile-Transactions-creates-a-transaction-via-footer-button-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx` (+26 -60) 📝 `packages/desktop-client/src/hooks/useSingleActiveEditForm.tsx` (+8 -4) ➕ `upcoming-release-notes/5139.md` (+6 -0) </details> ### 📄 Description Closes #4282 Focus for the mobile amount field was being tracked in two locations with a local useState() and the useSingleActiveEditForm hook. Changed the behavior of the hook and also stopped the other fields from being disabled when a field is being edited. This allows single-click navigation from the amount field (the only problem child). Would like someone with an iPhone to verify this still works properly as there is mention of iOS being a problem in the implementation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 18:01:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#24388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?