github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 20:38:54 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #5051] [MERGED] 🐛 Fix goals tooltip obstructing cover spending context menu #24341

New Issue
Closed
opened 2026-04-16 17:59:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 17:59:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5051
Author: @Johnn27
Created: 5/24/2025
Status: ✅ Merged
Merged: 5/24/2025
Merged by: @youngcw

Base: master ← Head: fix-tooltip-overlap

📝 Commits (3)

  • 2cc4f6e 🐛 Fix goals tooltip obstructing cover spending context menu
  • 197f4f7 Update release note
  • f4cb08e Fix lint format

📊 Changes

3 files changed (+13 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx (+6 -1)
📝 packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx (+1 -0)
➕ upcoming-release-notes/5051.md (+6 -0)

📄 Description

Fixes: #4939 - Tooltip appears over popover in budget category balance

Problem:
When right-clicking (or clicking the chevron) on a category's balance in the budget table to open the context menu (Popover), the hover-triggered tooltip for the balance can still appear, creating a "double popup" that is visually confusing.

Solution:
This PR prevents the tooltip from appearing when its associated Popover (context menu) is already open.

Technical Changes:

  1. BalanceWithCarryover.tsx:

    • Added a new optional prop tooltipDisabled?: boolean to BalanceWithCarryoverProps.
    • The Tooltip component's triggerProps.isDisabled condition has been updated to:
      isDisabled: tooltipDisabled || !isGoalTemplatesEnabled || goalValue == null || isNarrowWidth.
      This ensures the tooltip is disabled if tooltipDisabled is true, in addition to the existing conditions.

  2. EnvelopeBudgetComponents.tsx (within ExpenseCategoryMonth):

    • The balanceMenuOpen state (which tracks if the balance context menu Popover is open) is now passed to the <BalanceWithCarryover /> component's new tooltipDisabled prop:
      <BalanceWithCarryover ... tooltipDisabled={balanceMenuOpen} />

Impact:
This change provides a cleaner user experience on the desktop budget screen by ensuring only one popup (either the tooltip or the context menu) is active at a time for the category balance. This fix is targeted at the desktop UI where this specific interaction occurs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5051 **Author:** [@Johnn27](https://github.com/Johnn27) **Created:** 5/24/2025 **Status:** ✅ Merged **Merged:** 5/24/2025 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix-tooltip-overlap` --- ### 📝 Commits (3) - [`2cc4f6e`](https://github.com/actualbudget/actual/commit/2cc4f6ec4fabaff44855707ad3e3fad7a5423c31) 🐛 Fix goals tooltip obstructing cover spending context menu - [`197f4f7`](https://github.com/actualbudget/actual/commit/197f4f7a9de0621709a3b549d7d2273869be1bdc) Update release note - [`f4cb08e`](https://github.com/actualbudget/actual/commit/f4cb08e4bbddc5d0d4dcc0a71af830f1f8cd3151) Fix lint format ### 📊 Changes **3 files changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/budget/envelope/EnvelopeBudgetComponents.tsx` (+1 -0) ➕ `upcoming-release-notes/5051.md` (+6 -0) </details> ### 📄 Description **Fixes: #4939 - Tooltip appears over popover in budget category balance** **Problem:** When right-clicking (or clicking the chevron) on a category's balance in the budget table to open the context menu (Popover), the hover-triggered tooltip for the balance can still appear, creating a "double popup" that is visually confusing. **Solution:** This PR prevents the tooltip from appearing when its associated Popover (context menu) is already open. **Technical Changes:** 1. **`BalanceWithCarryover.tsx`:** * Added a new optional prop `tooltipDisabled?: boolean` to `BalanceWithCarryoverProps`. * The `Tooltip` component's `triggerProps.isDisabled` condition has been updated to: `isDisabled: tooltipDisabled || !isGoalTemplatesEnabled || goalValue == null || isNarrowWidth`. This ensures the tooltip is disabled if `tooltipDisabled` is true, in addition to the existing conditions. 2. **`EnvelopeBudgetComponents.tsx` (within `ExpenseCategoryMonth`):** * The `balanceMenuOpen` state (which tracks if the balance context menu Popover is open) is now passed to the `<BalanceWithCarryover />` component's new `tooltipDisabled` prop: `<BalanceWithCarryover ... tooltipDisabled={balanceMenuOpen} />` **Impact:** This change provides a cleaner user experience on the desktop budget screen by ensuring only one popup (either the tooltip or the context menu) is active at a time for the category balance. This fix is targeted at the desktop UI where this specific interaction occurs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 17:59:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#24341
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?