github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #4507] [MERGED] :electron: Copy budget files to succeed even if cleanup fails & adding retries #24031

New Issue
Closed
opened 2026-04-16 17:47:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 17:47:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4507
Author: @MikesGlitch
Created: 3/2/2025
Status: ✅ Merged
Merged: 3/3/2025
Merged by: @MikesGlitch

Base: master ← Head: fix/move-files-should-be-successful-if-files-moved

📝 Commits (6)

📊 Changes

4 files changed (+46 additions, -4 deletions)

View changed files

📝 packages/desktop-electron/index.ts (+26 -1)
📝 packages/desktop-electron/package.json (+1 -1)
➕ upcoming-release-notes/4507.md (+6 -0)
📝 yarn.lock (+13 -2)

📄 Description

When the user tries to move their budget directory there's a chance the directory will fail if the permissions aren't right or the files are locked.

The current issue is that if it fails it leaves the users budget files in one place, but the app still references the old file location. So their budget files appear to be gone.

The fix is to allow the budget directory to succeed if the budget files moved, which allows the app to set the new budget directory. To mitigate file locking I've added retries.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4507 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 3/3/2025 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `fix/move-files-should-be-successful-if-files-moved` --- ### 📝 Commits (6) - [`9a472b2`](https://github.com/actualbudget/actual/commit/9a472b2639d7ef3f63e7d6b7210f161311f58df1) allowing copy budget files to succeed even if cleanup fails - [`fe49e91`](https://github.com/actualbudget/actual/commit/fe49e91feed30f0d8249c22f086d3ed1213c568f) release notes - [`98739b0`](https://github.com/actualbudget/actual/commit/98739b07fd89afea8e4c359dda7e1f33e46ea690) updating fs-extra - [`4cdef53`](https://github.com/actualbudget/actual/commit/4cdef53ac8f52b01918097b44a6112a1cd995a61) retries in for removing dir - [`6d5a316`](https://github.com/actualbudget/actual/commit/6d5a3169f69bfbf130b9614960a8108ecdd3a1d9) better retry defaults - [`0941c81`](https://github.com/actualbudget/actual/commit/0941c812795be851cc73ad8b92d7f1dbe14c337f) defaults ### 📊 Changes **4 files changed** (+46 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-electron/index.ts` (+26 -1) 📝 `packages/desktop-electron/package.json` (+1 -1) ➕ `upcoming-release-notes/4507.md` (+6 -0) 📝 `yarn.lock` (+13 -2) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> When the user tries to move their budget directory there's a chance the directory will fail if the permissions aren't right or the files are locked. The current issue is that if it fails it leaves the users budget files in one place, but the app still references the old file location. So their budget files appear to be gone. The fix is to allow the budget directory to succeed if the budget files moved, which allows the app to set the new budget directory. To mitigate file locking I've added retries. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 17:47:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#24031
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?