mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-09 03:32:54 -05:00
[Bug]: A sentence is missing in the translation repository #2394
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#2394
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @harf4ng on GitHub (Aug 15, 2025).
Verified issue does not already exist?
What happened?
File: \packages\desktop-client\src\components\modals\ConfirmTransactionDeleteModal.tsx
Function: export function ConfirmTransactionDeleteModal({
Sentence :
message = 'Are you sure you want to delete the transaction?',
The message is missing a translation flag so it stays in english and no way we can translate it with weblate.
How can we reproduce the issue?
Just look at source code
Where are you hosting Actual?
None
What browsers are you seeing the problem on?
No response
Operating System
Windows 11
@JonhyOliveira commented on GitHub (Aug 17, 2025):
Hey @harf4ng
Couldn't find the exact path you are referring to in the issue. I just want to add a few links here to make it easier for the next one to parse through this.
I did find CofirmDeleteModal.tsx.
The title seems to be properly translated but the actual message is not translated. I assume this is the "message" you are referring to, right?
cccd66713d/packages/desktop-client/src/components/modals/ConfirmDeleteModal.tsx (L38-L45)I need some guidance as to what a full fix for this would look like. Since adding
t('Confirm Delete Transaction')would probably not be enough@milanalexandre commented on GitHub (Aug 17, 2025):
fixed by https://github.com/actualbudget/actual/pull/5556
@harf4ng commented on GitHub (Aug 17, 2025):
The ConfirmTransactionDeleteModal.tsx file is in the 25.8.0 branch.
Though according to milanalexandre it is fixed?
@JonhyOliveira commented on GitHub (Aug 17, 2025):
@harf4ng, looking at the changes looks like
ConfirmTransactionDeleteModalwent away and is getting replaced by a more generalConfirmDeleteModal. The message is also now injected already translated inuseTransactionBatchActions. This is what I could tell by looking at the PR patch diff at least.Seems fixed at first glance
@harf4ng commented on GitHub (Aug 17, 2025):
Ok thanks so this means we will have that in a new version anytime soon.
@joel-jeremy commented on GitHub (Sep 4, 2025):
This is now in the latest 25.8.0 release