github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 09:38:37 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #4227] [MERGED] Extract accounts related server handlers from main.ts to server/accounts/app.ts #23883

New Issue
Closed
opened 2026-04-16 17:43:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 17:43:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4227
Author: @joel-jeremy
Created: 1/23/2025
Status: ✅ Merged
Merged: 2/21/2025
Merged by: @joel-jeremy

Base: master ← Head: server-account-handlers

📝 Commits (10+)

  • 822cd51 Move transaction related handlers to server/transactions folder and use the new convention
  • 30ed94e Fix lint and typecheck
  • edb3051 Move server account handlers from main.ts to accounts/app.ts
  • ba50100 Add accounts app to main.ts
  • f026e72 Release notes
  • 032917d Fix types
  • a56121e Fix typecheck error
  • 5179ad0 Fix types
  • 756df9d Fix build error
  • 20360d2 Use main app

📊 Changes

16 files changed (+1147 additions, -973 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx (+1 -1)
📝 packages/desktop-client/src/components/modals/CreateAccountModal.tsx (+1 -3)
📝 packages/desktop-client/src/gocardless.ts (+2 -9)
📝 packages/loot-core/src/client/accounts/accountsSlice.ts (+17 -24)
➕ packages/loot-core/src/server/accounts/app.ts (+1038 -0)
📝 packages/loot-core/src/server/accounts/payees.ts (+4 -3)
📝 packages/loot-core/src/server/accounts/sync.ts (+17 -10)
📝 packages/loot-core/src/server/errors.ts (+15 -0)
📝 packages/loot-core/src/server/main.ts (+4 -793)
📝 packages/loot-core/src/server/post.ts (+17 -8)
📝 packages/loot-core/src/types/handlers.d.ts (+3 -1)
➕ packages/loot-core/src/types/models/bank.d.ts (+6 -0)
📝 packages/loot-core/src/types/models/gocardless.d.ts (+8 -0)
📝 packages/loot-core/src/types/models/simplefin.d.ts (+8 -0)
📝 packages/loot-core/src/types/server-handlers.d.ts (+0 -121)
➕ upcoming-release-notes/4227.md (+6 -0)

📄 Description

Related to https://github.com/actualbudget/actual/issues/1113

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4227 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 2/21/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `server-account-handlers` --- ### 📝 Commits (10+) - [`822cd51`](https://github.com/actualbudget/actual/commit/822cd51c39fa87ae658fc2c6f0595ffeae7706ca) Move transaction related handlers to server/transactions folder and use the new convention - [`30ed94e`](https://github.com/actualbudget/actual/commit/30ed94eb2ba5b97ba097e1b3b5a023eb9c63d1a8) Fix lint and typecheck - [`edb3051`](https://github.com/actualbudget/actual/commit/edb3051513a7d56b9edc791ec2a0213989ecc98f) Move server account handlers from main.ts to accounts/app.ts - [`ba50100`](https://github.com/actualbudget/actual/commit/ba501001b63a385179a98d6fef5e89bf9b0c348f) Add accounts app to main.ts - [`f026e72`](https://github.com/actualbudget/actual/commit/f026e728ef0ab8ea841dbe76437a7f9624d081f3) Release notes - [`032917d`](https://github.com/actualbudget/actual/commit/032917dce13620bf6cc1349948af230b621f2d54) Fix types - [`a56121e`](https://github.com/actualbudget/actual/commit/a56121ee079d3550ecfffa1a03f50af6694d1851) Fix typecheck error - [`5179ad0`](https://github.com/actualbudget/actual/commit/5179ad01e543a585a2112d78a195e638301f2ec5) Fix types - [`756df9d`](https://github.com/actualbudget/actual/commit/756df9d407224c0ef6f4ec9ae3d4671cc4b94376) Fix build error - [`20360d2`](https://github.com/actualbudget/actual/commit/20360d23ffb8bfa99c348578deada5e23d75b1c3) Use main app ### 📊 Changes **16 files changed** (+1147 additions, -973 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/modals/CreateAccountModal.tsx` (+1 -3) 📝 `packages/desktop-client/src/gocardless.ts` (+2 -9) 📝 `packages/loot-core/src/client/accounts/accountsSlice.ts` (+17 -24) ➕ `packages/loot-core/src/server/accounts/app.ts` (+1038 -0) 📝 `packages/loot-core/src/server/accounts/payees.ts` (+4 -3) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+17 -10) 📝 `packages/loot-core/src/server/errors.ts` (+15 -0) 📝 `packages/loot-core/src/server/main.ts` (+4 -793) 📝 `packages/loot-core/src/server/post.ts` (+17 -8) 📝 `packages/loot-core/src/types/handlers.d.ts` (+3 -1) ➕ `packages/loot-core/src/types/models/bank.d.ts` (+6 -0) 📝 `packages/loot-core/src/types/models/gocardless.d.ts` (+8 -0) 📝 `packages/loot-core/src/types/models/simplefin.d.ts` (+8 -0) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+0 -121) ➕ `upcoming-release-notes/4227.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Related to https://github.com/actualbudget/actual/issues/1113 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 17:43:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#23883
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?