github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #3238] [MERGED] Remove some any types from the API #23361

New Issue
Closed
opened 2026-04-16 17:25:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 17:25:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3238
Author: @jfdoming
Created: 8/11/2024
Status: ✅ Merged
Merged: 8/14/2024
Merged by: @jfdoming

Base: master ← Head: jfdoming/better-api-types

📝 Commits (7)

  • 47fa7d1 Remove some any types from the API
  • b6b6369 Add release notes
  • 0b3af22 No backwards-incompatible changes
  • f9eb042 Update tests to reflect API changes
  • 963e752 PR feedback: standardize on id for deletes
  • 5cccf89 PR feedback: restore partial updates
  • a64285e Merge branch 'master' into jfdoming/better-api-types

📊 Changes

10 files changed (+53 additions, -42 deletions)

View changed files

📝 packages/api/methods.test.ts (+8 -14)
📝 packages/api/methods.ts (+2 -2)
📝 packages/loot-core/src/server/accounts/transaction-rules.test.ts (+1 -1)
📝 packages/loot-core/src/server/accounts/transaction-rules.ts (+4 -3)
📝 packages/loot-core/src/server/api.ts (+12 -9)
📝 packages/loot-core/src/server/rules/app.ts (+3 -3)
📝 packages/loot-core/src/server/rules/types/handlers.ts (+8 -5)
📝 packages/loot-core/src/types/api-handlers.d.ts (+8 -4)
📝 packages/loot-core/src/types/server-handlers.d.ts (+1 -1)
➕ upcoming-release-notes/3238.md (+6 -0)

📄 Description

This diff updates withMutation so that it conserves types when used (before, it would replace args/return values with any, meaning that type errors fixed in this PR had crept in).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3238 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 8/11/2024 **Status:** ✅ Merged **Merged:** 8/14/2024 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/better-api-types` --- ### 📝 Commits (7) - [`47fa7d1`](https://github.com/actualbudget/actual/commit/47fa7d13bfd4ee900b1e29d1aea18335f25a8d94) Remove some `any` types from the API - [`b6b6369`](https://github.com/actualbudget/actual/commit/b6b63697d8e49736b9cacd60dfc95aa510c9d9d4) Add release notes - [`0b3af22`](https://github.com/actualbudget/actual/commit/0b3af2256f3026389fa7090281ee6742de0ee2c4) No backwards-incompatible changes - [`f9eb042`](https://github.com/actualbudget/actual/commit/f9eb0420e801843b9732ff5f34f695d515b1cf49) Update tests to reflect API changes - [`963e752`](https://github.com/actualbudget/actual/commit/963e7524dc4f5675deb40760fc9420016559b6cc) PR feedback: standardize on id for deletes - [`5cccf89`](https://github.com/actualbudget/actual/commit/5cccf89776fcdb8337a16e4c0f6a7aca24a19737) PR feedback: restore partial updates - [`a64285e`](https://github.com/actualbudget/actual/commit/a64285ea96112f693d52d206b834184eae7a8383) Merge branch 'master' into jfdoming/better-api-types ### 📊 Changes **10 files changed** (+53 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/methods.test.ts` (+8 -14) 📝 `packages/api/methods.ts` (+2 -2) 📝 `packages/loot-core/src/server/accounts/transaction-rules.test.ts` (+1 -1) 📝 `packages/loot-core/src/server/accounts/transaction-rules.ts` (+4 -3) 📝 `packages/loot-core/src/server/api.ts` (+12 -9) 📝 `packages/loot-core/src/server/rules/app.ts` (+3 -3) 📝 `packages/loot-core/src/server/rules/types/handlers.ts` (+8 -5) 📝 `packages/loot-core/src/types/api-handlers.d.ts` (+8 -4) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+1 -1) ➕ `upcoming-release-notes/3238.md` (+6 -0) </details> ### 📄 Description This diff updates `withMutation` so that it conserves types when used (before, it would replace args/return values with `any`, meaning that type errors fixed in this PR had crept in). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 17:25:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#23361
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?