github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: All Accounts totals do not match when a closed account has a balance #2322

New Issue
Open
opened 2026-02-28 20:10:27 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-02-28 20:10:27 -06:00
Owner
Copy Link

Originally created by @Juulz on GitHub (Jul 28, 2025).

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

A bug happened!
When a closed account has a balance (for whatever reason), the reported totals:
Purple sidebar All accounts does not include the balance from the closed account(s)
Green Transaction page All Accounts total DOES include the balance from the closed account(s).

How can we reproduce the issue?

How can we reproduce the issue?
Add a transaction to a closed account so it's balance is not zero.

Where are you hosting Actual?

Pikapods

What browsers are you seeing the problem on?

Chrome

Operating System

Windows 11

Originally created by @Juulz on GitHub (Jul 28, 2025). ### Verified issue does not already exist? - [x] I have searched and found no existing issue ### What happened? A bug happened! When a closed account has a balance (for whatever reason), the reported totals: Purple sidebar All accounts does not include the balance from the closed account(s) Green Transaction page All Accounts total DOES include the balance from the closed account(s). ### How can we reproduce the issue? How can we reproduce the issue? Add a transaction to a closed account so it's balance is not zero. ### Where are you hosting Actual? Pikapods ### What browsers are you seeing the problem on? Chrome ### Operating System Windows 11
GiteaMirror added the transactionsgood first issuebughelp wanted labels 2026-02-28 20:10:28 -06:00
GiteaMirror commented 2026-02-28 20:10:28 -06:00
Author
Owner
Copy Link

@Juulz commented on GitHub (Jul 28, 2025):

Perhaps the best way to handle this is to change the color of "Closed" and add a warning so it stands out.

The other choice is to not allow ANY changes to a closed account, but that is probably overkill and would take more work.

@Juulz commented on GitHub (Jul 28, 2025): Perhaps the best way to handle this is to change the color of "Closed" and add a warning so it stands out. The other choice is to not allow ANY changes to a closed account, but that is probably overkill and would take more work.
GiteaMirror commented 2026-02-28 20:10:29 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jul 28, 2025):

Probably what should happen is that adding transactions to a closed account should be blocked. So the add transaction button should be removed for closed accounts and also block any rule that is attempting to move a transaction to a closed account.

@youngcw commented on GitHub (Jul 28, 2025): Probably what should happen is that adding transactions to a closed account should be blocked. So the add transaction button should be removed for closed accounts and also block any rule that is attempting to move a transaction to a closed account.
GiteaMirror commented 2026-02-28 20:10:29 -06:00
Author
Owner
Copy Link

@Juulz commented on GitHub (Jul 28, 2025):

A transaction could still be changed to cause the problem. Locking the account completely is probably the correct fix. Then, if someone wants to make any change, they have to unclose the account and closing it again will force the balance to zero.

@Juulz commented on GitHub (Jul 28, 2025): A transaction could still be changed to cause the problem. Locking the account completely is probably the correct fix. Then, if someone wants to make any change, they have to unclose the account and closing it again will force the balance to zero.
GiteaMirror commented 2026-02-28 20:10:30 -06:00
Author
Owner
Copy Link

@Serializator commented on GitHub (Aug 20, 2025):

The PR was closed due to inactivity but I am still working on this. I will not reopen the PR because I can't assure I will keep the PR up-to-date over longer periods of time. Just a heads-up to avoid someone doing duplicate work 😄

@Serializator commented on GitHub (Aug 20, 2025): The PR was closed due to inactivity but I am still working on this. I will not reopen the PR because I can't assure I will keep the PR up-to-date over longer periods of time. Just a heads-up to avoid someone doing duplicate work 😄
GiteaMirror commented 2026-02-28 20:10:30 -06:00
Author
Owner
Copy Link

@Serializator commented on GitHub (Sep 1, 2025):

Working on this intermittently. The list below is implemented.

Right not testing everything through to prevent bugs / regressions.

  • The API disallows the updating of the account or amount of a transaction in a closed account.
  • The account, debit and credit columns in the transaction table can't be clicked for transactions in a closed account.
  • The UI will not show the import button for closed accounts.
  • Rules will be skipped when they either update the account or amount of a transaction in a closed account.
  • Any actions in the menu (incl. keyboard shortcuts) which affect the account or amount are grayed out.
@Serializator commented on GitHub (Sep 1, 2025): Working on this intermittently. The list below is implemented. Right not testing everything through to prevent bugs / regressions. - The API disallows the updating of the account or amount of a transaction in a closed account. - The account, debit and credit columns in the transaction table can't be clicked for transactions in a closed account. - The UI will not show the import button for closed accounts. - Rules will be skipped when they either update the account or amount of a transaction in a closed account. - Any actions in the menu (incl. keyboard shortcuts) which affect the account or amount are grayed out.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue help wanted transactions
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#2322
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?