[PR #2724] [MERGED] ♻️ (tooltip) refactoring to react-aria (vol.4) #23084

Closed
opened 2026-04-16 17:13:04 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2724
Author: @MatissJanis
Created: 5/7/2024
Status: Merged
Merged: 5/15/2024
Merged by: @MatissJanis

Base: masterHead: matiss/tooltip-5


📝 Commits (10+)

  • b3b3a34 ♻️ (tooltip) refactoring to react-aria (vol.4)
  • 3b5eb5e Release notes
  • e173765 Feedback: rename some files
  • 79642a2 More file renames
  • 42776a4 Rename BalanceTooltip to BalancePopoverContent
  • b39efd8 Delete unnecessary release notes file
  • d0291ac BalanceMovementMenu
  • 78d6a0e Feedback: fix floating menu in chrome
  • e8bacdc Merge branch 'master' into matiss/tooltip-5
  • 61cd1af Update VRT screenshots

📊 Changes

18 files changed (+288 additions, -370 deletions)

View changed files

📝 .eslintrc.js (+2 -2)
📝 packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/budget/BudgetTotals.tsx (+39 -39)
📝 packages/desktop-client/src/components/budget/SidebarCategory.tsx (+34 -33)
📝 packages/desktop-client/src/components/budget/SidebarGroup.tsx (+36 -35)
📝 packages/desktop-client/src/components/budget/rollover/BalanceMovementMenu.tsx (+22 -39)
📝 packages/desktop-client/src/components/budget/rollover/CoverMenu.tsx (+6 -33)
📝 packages/desktop-client/src/components/budget/rollover/HoldMenu.tsx (+6 -18)
📝 packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx (+59 -50)
📝 packages/desktop-client/src/components/budget/rollover/TransferMenu.tsx (+11 -40)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx (+0 -1)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx (+45 -54)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx (+14 -20)
📝 packages/desktop-client/src/components/common/Menu.tsx (+7 -5)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx (+1 -1)
upcoming-release-notes/2724.md (+6 -0)

📄 Description

Follow-up to https://github.com/actualbudget/actual/pull/2631

This should move the majority (if not all) of the Tooltip components used in the reports page.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2724 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 5/7/2024 **Status:** ✅ Merged **Merged:** 5/15/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/tooltip-5` --- ### 📝 Commits (10+) - [`b3b3a34`](https://github.com/actualbudget/actual/commit/b3b3a34c5a3dd9c729e3b1875606f3aec45e19d7) ♻️ (tooltip) refactoring to react-aria (vol.4) - [`3b5eb5e`](https://github.com/actualbudget/actual/commit/3b5eb5e81ebb513d9100874e8fcf5c99b72f63f2) Release notes - [`e173765`](https://github.com/actualbudget/actual/commit/e17376532f06f8fb12dae5f487c4ef21b170c481) Feedback: rename some files - [`79642a2`](https://github.com/actualbudget/actual/commit/79642a2f6fdcfa21ff254f8c295b6d1d08453a2f) More file renames - [`42776a4`](https://github.com/actualbudget/actual/commit/42776a4d5cd2b35d6d030fbe0b716503046f05ed) Rename BalanceTooltip to BalancePopoverContent - [`b39efd8`](https://github.com/actualbudget/actual/commit/b39efd89648176e1a5bc52789fdd1ec9313b4c0a) Delete unnecessary release notes file - [`d0291ac`](https://github.com/actualbudget/actual/commit/d0291ac175fbee88627a05f1ad6aebcd5251680f) BalanceMovementMenu - [`78d6a0e`](https://github.com/actualbudget/actual/commit/78d6a0e09f582b312d1381f8ff68129dfc924677) Feedback: fix floating menu in chrome - [`e8bacdc`](https://github.com/actualbudget/actual/commit/e8bacdc473962bb6ba759fe5cf2f4682d39a4ff9) Merge branch 'master' into matiss/tooltip-5 - [`61cd1af`](https://github.com/actualbudget/actual/commit/61cd1afe1b9a6291c5f4e6f19dc7b9fe50e00c3e) Update VRT screenshots ### 📊 Changes **18 files changed** (+288 additions, -370 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+2 -2) 📝 `packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/budget.test.js-snapshots/Budget-transfer-funds-to-another-category-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/budget/BudgetTotals.tsx` (+39 -39) 📝 `packages/desktop-client/src/components/budget/SidebarCategory.tsx` (+34 -33) 📝 `packages/desktop-client/src/components/budget/SidebarGroup.tsx` (+36 -35) 📝 `packages/desktop-client/src/components/budget/rollover/BalanceMovementMenu.tsx` (+22 -39) 📝 `packages/desktop-client/src/components/budget/rollover/CoverMenu.tsx` (+6 -33) 📝 `packages/desktop-client/src/components/budget/rollover/HoldMenu.tsx` (+6 -18) 📝 `packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx` (+59 -50) 📝 `packages/desktop-client/src/components/budget/rollover/TransferMenu.tsx` (+11 -40) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx` (+45 -54) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudgetAmount.tsx` (+14 -20) 📝 `packages/desktop-client/src/components/common/Menu.tsx` (+7 -5) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx` (+1 -1) ➕ `upcoming-release-notes/2724.md` (+6 -0) </details> ### 📄 Description Follow-up to https://github.com/actualbudget/actual/pull/2631 This should move the majority (if not all) of the Tooltip components used in the reports page. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 17:13:04 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#23084