github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2652] [MERGED] Template only the relevant amount in a split-schedule category #23045

New Issue
Closed
opened 2026-04-16 17:11:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 17:11:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2652
Author: @jfdoming
Created: 4/21/2024
Status: ✅ Merged
Merged: 5/21/2024
Merged by: @youngcw

Base: master ← Head: jfdoming/cross-category-schedule-templates

📝 Commits (6)

  • 3486074 Template only the relevant amount in a split-schedule category
  • e5d5e2c Merge branch 'master' into jfdoming/cross-category-schedule-templates
  • a3363f8 Add release notes
  • 97beea1 Merge branch 'master' into jfdoming/cross-category-schedule-templates
  • 8fed6af Adjust sign correctly depending on category type
  • c979dd8 Merge branch 'master' into jfdoming/cross-category-schedule-templates

📊 Changes

4 files changed (+29 additions, -11 deletions)

View changed files

📝 packages/loot-core/src/server/accounts/rules.ts (+2 -3)
📝 packages/loot-core/src/server/budget/goals/goalsSchedule.ts (+20 -7)
📝 packages/loot-core/src/server/schedules/app.ts (+1 -1)
➕ upcoming-release-notes/2652.md (+6 -0)

📄 Description

As it says on the tin. For the logic, there are a few cases to consider; open to changing any of these, but these ones seem logical to me:

  • Category that corresponds to some parts of a split: the category gets the sum of all splits that match the category
    => e.g., if you have a split with "personal trainer" and "gym membership", you can template a "personal trainer" category that just receives the amount due there.
  • Category that corresponds to all parts of a split: the category gets the sum of all splits
    => self-explanatory, the split belongs to only one category

These ones are more subject to change:

  • Category that corresponds to no part of a split: the category gets the sum of all splits
    => this is so that if you write "#template schedule foo" in a category that's unrelated, you don't end up with "0" of the schedule
  • Category that contains a regular rule with a changed amount
    => I think this part is most open to change. This is so that if you add a schedule with a that overwrites the transaction amount, the overwritten amount will get used. I don't see a use-case for overwriting the transaction amount, but it's an option the UI supports so IMO it could be worth handling here

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2652 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 4/21/2024 **Status:** ✅ Merged **Merged:** 5/21/2024 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `jfdoming/cross-category-schedule-templates` --- ### 📝 Commits (6) - [`3486074`](https://github.com/actualbudget/actual/commit/3486074c0ee7b8bc8027a58c011dd1c38f776edb) Template only the relevant amount in a split-schedule category - [`e5d5e2c`](https://github.com/actualbudget/actual/commit/e5d5e2cadbd736231213cf37a911dafb2de3bbf5) Merge branch 'master' into jfdoming/cross-category-schedule-templates - [`a3363f8`](https://github.com/actualbudget/actual/commit/a3363f88fd08a9144de432e8239a8c0ba7a9ba2d) Add release notes - [`97beea1`](https://github.com/actualbudget/actual/commit/97beea105352e24040a76b97dcbe965e5af058ce) Merge branch 'master' into jfdoming/cross-category-schedule-templates - [`8fed6af`](https://github.com/actualbudget/actual/commit/8fed6afe4f5c10bab54022a7218877e39723bdc3) Adjust sign correctly depending on category type - [`c979dd8`](https://github.com/actualbudget/actual/commit/c979dd8b753e06ee0707194bd58b9e8f4a1751c8) Merge branch 'master' into jfdoming/cross-category-schedule-templates ### 📊 Changes **4 files changed** (+29 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/accounts/rules.ts` (+2 -3) 📝 `packages/loot-core/src/server/budget/goals/goalsSchedule.ts` (+20 -7) 📝 `packages/loot-core/src/server/schedules/app.ts` (+1 -1) ➕ `upcoming-release-notes/2652.md` (+6 -0) </details> ### 📄 Description As it says on the tin. For the logic, there are a few cases to consider; open to changing any of these, but these ones seem logical to me: - Category that corresponds to some parts of a split: the category gets the sum of all splits that match the category => e.g., if you have a split with "personal trainer" and "gym membership", you can template a "personal trainer" category that just receives the amount due there. - Category that corresponds to all parts of a split: the category gets the sum of all splits => self-explanatory, the split belongs to only one category These ones are more subject to change: - Category that corresponds to no part of a split: the category gets the sum of all splits => this is so that if you write "#template schedule foo" in a category that's unrelated, you don't end up with "0" of the schedule - Category that contains a regular rule with a changed amount => I think this part is most open to change. This is so that if you add a schedule with a that _overwrites_ the transaction amount, the overwritten amount will get used. I don't see a use-case for overwriting the transaction amount, but it's an option the UI supports so IMO it could be worth handling here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 17:11:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#23045
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?