github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2601] [MERGED] ⚡ extra error handling in case backend failed loading #23005

New Issue
Closed
opened 2026-04-16 17:10:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 17:10:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2601
Author: @MatissJanis
Created: 4/14/2024
Status: ✅ Merged
Merged: 4/15/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/error-handling

📝 Commits (3)

  • db13970 ⚡ extra error handling in case backend failed loading
  • cf1d3e1 Release notes
  • ec16afe Rename some error vars

📊 Changes

3 files changed (+50 additions, -43 deletions)

View changed files

📝 packages/desktop-client/src/browser-server.js (+42 -31)
📝 packages/desktop-client/src/components/FatalError.tsx (+2 -12)
➕ upcoming-release-notes/2601.md (+6 -0)

📄 Description

Adding a bit of extra error handling in case the backend has failed loading (fatal error).

It seems at some point we have lost the fatal error handling logic. Meaning that in case of fatal errors (backend totally failed loading) - we would show an endless spinning bar instead of an error message.

So this slightly improves the situation.. the user will now see an error message.

Also renamed e vars to something else. This might fix https://github.com/actualbudget/actual/issues/1766 , but since I've not been able to reproduce the issue locally - it's mostly a shot in the dark.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2601 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/14/2024 **Status:** ✅ Merged **Merged:** 4/15/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/error-handling` --- ### 📝 Commits (3) - [`db13970`](https://github.com/actualbudget/actual/commit/db1397066bcf80b53e08eb26789bb08b4514528a) :zap: extra error handling in case backend failed loading - [`cf1d3e1`](https://github.com/actualbudget/actual/commit/cf1d3e17a1b0ced9789948d83e9ac8e904880d1f) Release notes - [`ec16afe`](https://github.com/actualbudget/actual/commit/ec16afef055798d393da8801426bf092f5acee7b) Rename some error vars ### 📊 Changes **3 files changed** (+50 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/browser-server.js` (+42 -31) 📝 `packages/desktop-client/src/components/FatalError.tsx` (+2 -12) ➕ `upcoming-release-notes/2601.md` (+6 -0) </details> ### 📄 Description Adding a bit of extra error handling in case the backend has failed loading (fatal error). It seems at some point we have lost the fatal error handling logic. Meaning that in case of fatal errors (backend totally failed loading) - we would show an endless spinning bar instead of an error message. So this _slightly_ improves the situation.. the user will now see an error message. --- Also renamed `e` vars to something else. This _might_ fix https://github.com/actualbudget/actual/issues/1766 , but since I've not been able to reproduce the issue locally - it's mostly a shot in the dark. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 17:10:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#23005
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?