github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1864] [MERGED] Make Select All respect filters and splits #22604

New Issue
Closed
opened 2026-04-16 16:53:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 16:53:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1864
Author: @jamescostian
Created: 11/6/2023
Status: ✅ Merged
Merged: 11/9/2023
Merged by: @joel-jeremy

Base: master ← Head: improve-select-plus-filter

📝 Commits (1)

  • 9ee5f43 Make Select All respect filters and splits

📊 Changes

3 files changed (+28 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Account.js (+1 -0)
📝 packages/desktop-client/src/hooks/useSelected.tsx (+21 -2)
➕ upcoming-release-notes/1864.md (+6 -0)

📄 Description

This PR improves the situation described in issue #283. Here's a demo:

Setup

Setup

Select all

master branch - selects the parent Split, which affects the Selected balance

Original Select All

This PR

Improved Select All

Filter by category, then select all

master branch - selects the parent Split and the non-Food-category transactions, which affect the Selected balance

Original Select All while Filtering

This PR

Improved Select All while Filtering

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1864 **Author:** [@jamescostian](https://github.com/jamescostian) **Created:** 11/6/2023 **Status:** ✅ Merged **Merged:** 11/9/2023 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `improve-select-plus-filter` --- ### 📝 Commits (1) - [`9ee5f43`](https://github.com/actualbudget/actual/commit/9ee5f430e62a66ce3e6516e854d49c04c80869b0) Make Select All respect filters and splits ### 📊 Changes **3 files changed** (+28 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Account.js` (+1 -0) 📝 `packages/desktop-client/src/hooks/useSelected.tsx` (+21 -2) ➕ `upcoming-release-notes/1864.md` (+6 -0) </details> ### 📄 Description This PR improves the situation described in issue #283. Here's a demo: # Setup ![Setup](https://github.com/actualbudget/actual/assets/1456118/7bab4bf7-4502-4cae-938c-b5a32e8533a5) # Select all ## master branch - selects the parent Split, which affects the Selected balance ![Original Select All](https://github.com/actualbudget/actual/assets/1456118/f061d4b5-43eb-4981-83f6-d9c041c60e20) ## This PR ![Improved Select All](https://github.com/actualbudget/actual/assets/1456118/00d4ff73-cae5-4c14-8cf8-558f58d94b45) # Filter by category, then select all ## master branch - selects the parent Split and the non-Food-category transactions, which affect the Selected balance ![Original Select All while Filtering](https://github.com/actualbudget/actual/assets/1456118/38714b9b-168f-4790-a244-ff503d8b2af2) ## This PR ![Improved Select All while Filtering](https://github.com/actualbudget/actual/assets/1456118/2b1ce7c0-f23c-4eaf-9ee0-d19c963e2bde) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 16:53:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#22604
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?