github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 20:38:54 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #1349] [MERGED] Fix importing transactions in Safari and clean up openFileDialog API #22291

New Issue
Closed
opened 2026-04-16 16:39:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 16:39:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1349
Author: @Cldfire
Created: 7/16/2023
Status: ✅ Merged
Merged: 7/16/2023
Merged by: @j-f1

Base: master ← Head: jarek/fix-import-in-safari

📝 Commits (4)

  • ec00b95 Fix importing transactions in Safari
  • 0fe3ae0 Add changelog entry
  • 9d9e560 Add missing await
  • 8b01e17 Create one file input and reuse it

📊 Changes

3 files changed (+31 additions, -12 deletions)

View changed files

📝 packages/desktop-client/src/browser-preload.browser.js (+23 -10)
📝 packages/desktop-client/src/components/modals/ImportTransactions.js (+2 -2)
➕ upcoming-release-notes/1349.md (+6 -0)

📄 Description

Closes https://github.com/actualbudget/actual/issues/1313.

See my comments on the issue for investigation into what was happening. It seems WebKit wants the file input in the DOM to reliably fire change events when the user makes a selection. I set the input to display: none to make sure that even if it sticks around in the DOM for some reason it's not interactive.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1349 **Author:** [@Cldfire](https://github.com/Cldfire) **Created:** 7/16/2023 **Status:** ✅ Merged **Merged:** 7/16/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jarek/fix-import-in-safari` --- ### 📝 Commits (4) - [`ec00b95`](https://github.com/actualbudget/actual/commit/ec00b95f917d13c8fbeecda50ebe463e4d00e992) Fix importing transactions in Safari - [`0fe3ae0`](https://github.com/actualbudget/actual/commit/0fe3ae0d1f8a98ad9075362033130909cf0f238c) Add changelog entry - [`9d9e560`](https://github.com/actualbudget/actual/commit/9d9e560c945e9375c71169b79159669e31d3be6a) Add missing await - [`8b01e17`](https://github.com/actualbudget/actual/commit/8b01e17e6251cbf7ec684f6c1cc0daea770630f5) Create one file input and reuse it ### 📊 Changes **3 files changed** (+31 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/browser-preload.browser.js` (+23 -10) 📝 `packages/desktop-client/src/components/modals/ImportTransactions.js` (+2 -2) ➕ `upcoming-release-notes/1349.md` (+6 -0) </details> ### 📄 Description Closes https://github.com/actualbudget/actual/issues/1313. See my comments on the issue for investigation into what was happening. It seems WebKit wants the file input in the DOM to reliably fire `change` events when the user makes a selection. I set the input to `display: none` to make sure that even if it sticks around in the DOM for some reason it's not interactive. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 16:39:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#22291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?