github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #1023] [MERGED] Added Dev Container #22082

New Issue
Closed
opened 2026-04-16 16:29:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 16:29:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1023
Author: @jonezy35
Created: 5/11/2023
Status: ✅ Merged
Merged: 5/11/2023
Merged by: @j-f1

Base: master ← Head: dev-container

📝 Commits (10+)

  • 2c442df Initial Development Container
  • c896204 added build to docker-compose & moved yarn install
  • 33f8b9d restarting codespaces
  • 400c000 troubleshooting yarn
  • ee42e3a working container
  • 15e5e5f Verified container auto reloads changes made to codebase
  • ed209ce Added comments
  • ae870c8 Fixed yarn issue & added docker start script
  • 46f3997 updated contributing.md
  • b7c280d Fixed Typos

📊 Changes

5 files changed (+58 additions, -0 deletions)

View changed files

📝 CONTRIBUTING.md (+12 -0)
➕ Dockerfile (+11 -0)
➕ docker-compose.yml (+16 -0)
➕ docker-start.sh (+13 -0)
➕ upcoming-release-notes/1023.md (+6 -0)

📄 Description

In working a feature request, I found it desirable to have a development docker container to spin up and easily shut down. After discussions with maintainers in the Discord, I decided to take a moment to create the dev container.

Changes

  1. Created Dockerfile to build custom image
  2. Created docker-compose.yml which also builds the image (so no need to run docker build)
  3. Created docker-start.sh to be used by the image
    • This script checks if node_modules exists. If it does, it starts the container as normal. If it doesn't, it runs yarn to install them.
  4. Added development section to contributing.md explaining the two options for starting a dev environment.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1023 **Author:** [@jonezy35](https://github.com/jonezy35) **Created:** 5/11/2023 **Status:** ✅ Merged **Merged:** 5/11/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `dev-container` --- ### 📝 Commits (10+) - [`2c442df`](https://github.com/actualbudget/actual/commit/2c442df77db3972353b90f64865bfd3781c8db46) Initial Development Container - [`c896204`](https://github.com/actualbudget/actual/commit/c8962043b21ae582942ba37aca723b9345145dd6) added build to docker-compose & moved yarn install - [`33f8b9d`](https://github.com/actualbudget/actual/commit/33f8b9d659771f8b7b4c419d7c575d9e29668335) restarting codespaces - [`400c000`](https://github.com/actualbudget/actual/commit/400c000e58e246c954862612bd07bb2dd3908fdc) troubleshooting yarn - [`ee42e3a`](https://github.com/actualbudget/actual/commit/ee42e3ad2c339af34ccf5a4cc2d3ccae89adf85b) working container - [`15e5e5f`](https://github.com/actualbudget/actual/commit/15e5e5fb0456da419881861fa26f69cdecd94beb) Verified container auto reloads changes made to codebase - [`ed209ce`](https://github.com/actualbudget/actual/commit/ed209ce5448d787cbedc8693de03ca0754da0f27) Added comments - [`ae870c8`](https://github.com/actualbudget/actual/commit/ae870c8ad48c22705fc7d3b44588f70dc4c010a8) Fixed yarn issue & added docker start script - [`46f3997`](https://github.com/actualbudget/actual/commit/46f3997fcac6f512d25ac58504a990766ddf70ca) updated contributing.md - [`b7c280d`](https://github.com/actualbudget/actual/commit/b7c280d548283c5414f2ebdeaf297d93acc20c56) Fixed Typos ### 📊 Changes **5 files changed** (+58 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTING.md` (+12 -0) ➕ `Dockerfile` (+11 -0) ➕ `docker-compose.yml` (+16 -0) ➕ `docker-start.sh` (+13 -0) ➕ `upcoming-release-notes/1023.md` (+6 -0) </details> ### 📄 Description In working a feature request, I found it desirable to have a development docker container to spin up and easily shut down. After [discussions with maintainers in the Discord](https://discord.com/channels/937901803608096828/1105238627274989640/1105615279121244251), I decided to take a moment to create the dev container. <h3>Changes</h3> 1. Created `Dockerfile` to build custom image 2. Created `docker-compose.yml` which also builds the image (so no need to run `docker build`) 3. Created `docker-start.sh` to be used by the image - This script checks if `node_modules` exists. If it does, it starts the container as normal. If it doesn't, it runs `yarn` to install them. 4. Added development section to `contributing.md` explaining the two options for starting a dev environment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 16:29:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#22082
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?