github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #649] [MERGED] Allow the server to auto-configure the server URL for the client #21839

New Issue
Closed
opened 2026-04-16 16:16:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 16:16:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/649
Author: @j-f1
Created: 2/11/2023
Status: ✅ Merged
Merged: 2/21/2023
Merged by: @j-f1

Base: master ← Head: jed/auto-configure-server

📝 Commits (10+)

  • 2631c07 Allow the server to auto-configure the server URL for the client
  • 8080b68 Extract server URL/version logic out to ensure consistent updates
  • eb40e70 ()
  • 7b9ff2d Be more explicit about when the server version is re-fetched
  • 809ae20 Use a single layer of context provider
  • 94ad1c5 Merge branch 'master' into jed/auto-configure-server
  • 8cd8ed2 Move the bootstrap route to /account/needs-bootstrap
  • 1ad99a9 No more isActual
  • 3dafc45 Refactor to call subscribe-needs-bootstrap instead of fetch()
  • 3e5bd1e Dedupe calls to subscribe-needs-bootstrap

📊 Changes

13 files changed (+116 additions, -65 deletions)

View changed files

📝 packages/desktop-client/src/components/LoggedInUser.js (+1 -1)
➕ packages/desktop-client/src/components/ServerContext.js (+68 -0)
📝 packages/desktop-client/src/components/Titlebar.js (+1 -2)
📝 packages/desktop-client/src/components/manager/ConfigServer.js (+6 -6)
📝 packages/desktop-client/src/components/manager/ManagementApp.js (+1 -1)
📝 packages/desktop-client/src/components/manager/ServerURL.js (+1 -1)
📝 packages/desktop-client/src/components/manager/subscribe/common.js (+21 -1)
📝 packages/desktop-client/src/components/settings/Encryption.js (+1 -1)
📝 packages/desktop-client/src/components/settings/index.js (+1 -1)
➖ packages/desktop-client/src/hooks/useServerURL.js (+0 -18)
➖ packages/desktop-client/src/hooks/useServerVersion.js (+0 -23)
📝 packages/desktop-client/src/index.js (+4 -1)
📝 packages/loot-core/src/server/main.js (+11 -9)

📄 Description

Fixes #499. When you serve an Actual build generated from this PR on an Actual server with https://github.com/actualbudget/actual-server/pull/135 incorporated, you’ll skip the initial “Where's the server?” screen and go right to the “Bootstrap this Actual instance” / “Sign in to this Actual instance” screen. In the unlikely event you want to connect to a different server you can still do that from the link at the bottom of the page. And this will only happen after verifying that the current server is indeed an Actual server.

I also had to do some refactoring because initially the link at the bottom didn’t update from “no server configured.”

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/649 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 2/11/2023 **Status:** ✅ Merged **Merged:** 2/21/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/auto-configure-server` --- ### 📝 Commits (10+) - [`2631c07`](https://github.com/actualbudget/actual/commit/2631c0776789b3aab4cb9da2f47cd23217aab62e) Allow the server to auto-configure the server URL for the client - [`8080b68`](https://github.com/actualbudget/actual/commit/8080b68341ea9402731f0f8e1a6249c4a8ca24fb) Extract server URL/version logic out to ensure consistent updates - [`eb40e70`](https://github.com/actualbudget/actual/commit/eb40e70bc54b01bb186badfdc42a50d9bd63f0d6) () - [`7b9ff2d`](https://github.com/actualbudget/actual/commit/7b9ff2d0c433afdd40d859022145950ea4f209ff) Be more explicit about when the server version is re-fetched - [`809ae20`](https://github.com/actualbudget/actual/commit/809ae20495ea5d3f8ca163dca898f0ee30e547d8) Use a single layer of context provider - [`94ad1c5`](https://github.com/actualbudget/actual/commit/94ad1c5ba5fa0b870914e80961c0b55f927deab1) Merge branch 'master' into jed/auto-configure-server - [`8cd8ed2`](https://github.com/actualbudget/actual/commit/8cd8ed273f6f7f1a61e535195651971b5eb5b7f4) Move the bootstrap route to /account/needs-bootstrap - [`1ad99a9`](https://github.com/actualbudget/actual/commit/1ad99a94a0339aa47b83ef58b5945e303ab3cdfe) No more `isActual` - [`3dafc45`](https://github.com/actualbudget/actual/commit/3dafc452c8992fc31f26308fb79adeb27c713a79) Refactor to call subscribe-needs-bootstrap instead of fetch() - [`3e5bd1e`](https://github.com/actualbudget/actual/commit/3e5bd1ef5163d360163d13c9817ffc1f5302dede) Dedupe calls to subscribe-needs-bootstrap ### 📊 Changes **13 files changed** (+116 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+1 -1) ➕ `packages/desktop-client/src/components/ServerContext.js` (+68 -0) 📝 `packages/desktop-client/src/components/Titlebar.js` (+1 -2) 📝 `packages/desktop-client/src/components/manager/ConfigServer.js` (+6 -6) 📝 `packages/desktop-client/src/components/manager/ManagementApp.js` (+1 -1) 📝 `packages/desktop-client/src/components/manager/ServerURL.js` (+1 -1) 📝 `packages/desktop-client/src/components/manager/subscribe/common.js` (+21 -1) 📝 `packages/desktop-client/src/components/settings/Encryption.js` (+1 -1) 📝 `packages/desktop-client/src/components/settings/index.js` (+1 -1) ➖ `packages/desktop-client/src/hooks/useServerURL.js` (+0 -18) ➖ `packages/desktop-client/src/hooks/useServerVersion.js` (+0 -23) 📝 `packages/desktop-client/src/index.js` (+4 -1) 📝 `packages/loot-core/src/server/main.js` (+11 -9) </details> ### 📄 Description Fixes #499. When you serve an Actual build generated from this PR on an Actual server with https://github.com/actualbudget/actual-server/pull/135 incorporated, you’ll skip the initial “Where's the server?” screen and go right to the “Bootstrap this Actual instance” / “Sign in to this Actual instance” screen. In the unlikely event you want to connect to a different server you can still do that from the link at the bottom of the page. And this will only happen after verifying that the current server is indeed an Actual server. I also had to do some refactoring because initially the link at the bottom didn’t update from “no server configured.” --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 16:16:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#21839
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?