github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #440] [MERGED] Further iteration on the sidebar design #21747

New Issue
Closed
opened 2026-04-16 16:11:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 16:11:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/440
Author: @j-f1
Created: 1/10/2023
Status: ✅ Merged
Merged: 1/11/2023
Merged by: @MatissJanis

Base: master ← Head: even-more-sidebar-changes

📝 Commits (10+)

  • 0a9f767 Revert to expanding tools inline
  • 26083c2 Add an explicit “All Accounts” section, make accounts collapsible
  • 109e18b Highlight collapsed sections if relevant
  • 3cabca4 Add back the “Add account” button
  • cbb17af Sentence case
  • db44ad2 “All open accounts” if you have closed accounts
  • 11c8a0f Pad the bottom of “Add accounts”
  • b44dac9 Secondary item styling
  • dcb9ca3 Indent items
  • a6600cf Bold headers instead of graying them out

📊 Changes

2 files changed (+150 additions, -114 deletions)

View changed files

📝 packages/desktop-client/src/components/SidebarWithData.js (+1 -0)
📝 packages/loot-design/src/components/sidebar.js (+149 -114)

📄 Description

Outdated screenshots Screenshot_2023-01-10 16 31 58 Screenshot_2023-01-10 16 02 51

← The tools are back inline. The section defaults to closed unless you load the page into one of the tools, then it will open itself.

…and the parent item highlights itself when collapsed if any of its children are selected →

.

.

Screenshot_2023-01-10 16 04 40


New look for the Accounts section: →

  • The “Accounts” header now toggles the visibility of the entire section, just like the Tools section (although the Accounts section is always open by default)
  • There’s now a new header called “All accounts” (or “All open accounts” if you have closed accounts, would appreciate feedback on this distinction) that shows your net worth, and lets you see transaction history for on and off budget accounts combined (i.e. what “Accounts” used to do)
  • The button to add an account is now at the bottom of the accounts list, below “Closed accounts.” While it could theoretically scroll out of view, by the time you make that many accounts you’ll hopefully know where to look, right? (or you’ll end up scrolling to the bottom of the list anyway)

Here’s how it looks with both open: ↓
Screenshot_2023-01-10 16 33 10

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/440 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 1/10/2023 **Status:** ✅ Merged **Merged:** 1/11/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `even-more-sidebar-changes` --- ### 📝 Commits (10+) - [`0a9f767`](https://github.com/actualbudget/actual/commit/0a9f767eee537e30f908be8d584296669fdcad3b) Revert to expanding tools inline - [`26083c2`](https://github.com/actualbudget/actual/commit/26083c255fff5c0b0d4ba272ecb422f35a65a05b) Add an explicit “All Accounts” section, make accounts collapsible - [`109e18b`](https://github.com/actualbudget/actual/commit/109e18b71d7cab285ae7d72f5df3de06a43d286f) Highlight collapsed sections if relevant - [`3cabca4`](https://github.com/actualbudget/actual/commit/3cabca4c8af002b2a4f71f0c3d373f96a02d880b) Add back the “Add account” button - [`cbb17af`](https://github.com/actualbudget/actual/commit/cbb17af532ab0f0825bc2a6dff38492807028cbb) Sentence case - [`db44ad2`](https://github.com/actualbudget/actual/commit/db44ad2954dd88c59a77c31bd1e596c14cdf3c97) “All open accounts” if you have closed accounts - [`11c8a0f`](https://github.com/actualbudget/actual/commit/11c8a0f78bf771ce134d7346fdc97f04659bfe27) Pad the bottom of “Add accounts” - [`b44dac9`](https://github.com/actualbudget/actual/commit/b44dac9bf9b644177c0bb1ed3d9f9ce9a13b9e99) Secondary item styling - [`dcb9ca3`](https://github.com/actualbudget/actual/commit/dcb9ca3481c8c30b5fcb4c6d765ac34f61c07dd6) Indent items - [`a6600cf`](https://github.com/actualbudget/actual/commit/a6600cf5c62992f8f8435923f6815fbbccbe8671) Bold headers instead of graying them out ### 📊 Changes **2 files changed** (+150 additions, -114 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+1 -0) 📝 `packages/loot-design/src/components/sidebar.js` (+149 -114) </details> ### 📄 Description <details><summary>Outdated screenshots</summary> <img width="249" align=left alt="Screenshot_2023-01-10 16 31 58" src="https://user-images.githubusercontent.com/25517624/211666802-90693583-b8e4-4002-b9de-1ae200297a90.png"> <img width="343" align=right alt="Screenshot_2023-01-10 16 02 51" src="https://user-images.githubusercontent.com/25517624/211662042-81fa54ec-90ce-4628-91fc-cbac537caf8f.png"> &larr; The tools are back inline. The section defaults to closed unless you load the page into one of the tools, then it will open itself. …and the parent item highlights itself when collapsed if any of its children are selected &rarr; . . <img width="256" align=right alt="Screenshot_2023-01-10 16 04 40" src="https://user-images.githubusercontent.com/25517624/211662290-244195fd-c3b1-47ab-b469-dec0237f1722.png"> <br>New look for the Accounts section: &rarr; - The “Accounts” header now toggles the visibility of the entire section, just like the Tools section (although the Accounts section is always open by default) - There’s now a new header called “All accounts” (or “All open accounts” if you have closed accounts, would appreciate feedback on this distinction) that shows your net worth, and lets you see transaction history for on and off budget accounts combined (i.e. what “Accounts” used to do) - The button to add an account is now at the bottom of the accounts list, below “Closed accounts.” While it could theoretically scroll out of view, by the time you make that many accounts you’ll hopefully know where to look, right? (or you’ll end up scrolling to the bottom of the list anyway) Here’s how it looks with both open: &darr; <img width="241" alt="Screenshot_2023-01-10 16 33 10" src="https://user-images.githubusercontent.com/25517624/211667033-e66c6bac-8326-496f-9e3e-ca3d8cba863a.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 16:11:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#21747
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?