github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-15 22:54:03 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7503] [AI] Optimize CI e2e tests with pre-built bundle serving #21576

New Issue
Open
opened 2026-04-14 22:09:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 22:09:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7503
Author: @MatissJanis
Created: 4/14/2026
Status: 🔄 Open

Base: master ← Head: claude/speed-up-playwright-tests-UQIDS

📝 Commits (10+)

  • 9206fe3 [AI] Speed up Playwright e2e CI jobs
  • 5603da1 [AI] Fix e2e build: set REACT_APP_NETLIFY=true so test-file button renders
  • 70a2444 [AI] Reduce e2e workers from 4 to 3 to avoid animation-race flake
  • 7d6966a [AI] Switch e2e to 2 workers x 4 shards
  • d20e459 [AI] Bump e2e workers to 5
  • fc16f34 [AI] Merge origin/master into speed-up-playwright-tests branch
  • c52fbdb [AI] Fix e2e flakes: disable CSS animations in non-VRT runs
  • 555d809 [AI] Fix e2e flakes: bump expect timeout and rename use->runTest
  • 9ce278a Add release notes for PR #7503
  • 0713a78 Update 7503.md

📊 Changes

9 files changed (+316 additions, -25 deletions)

View changed files

📝 .github/workflows/e2e-test.yml (+58 -7)
➕ packages/desktop-client/bin/serve-build.mjs (+102 -0)
📝 packages/desktop-client/e2e/accounts.test.ts (+8 -1)
📝 packages/desktop-client/e2e/fixtures.ts (+42 -2)
📝 packages/desktop-client/e2e/page-models/budget-page.ts (+9 -0)
📝 packages/desktop-client/e2e/page-models/configuration-page.ts (+8 -2)
📝 packages/desktop-client/e2e/page-models/navigation.ts (+71 -10)
📝 packages/desktop-client/playwright.config.ts (+12 -3)
➕ upcoming-release-notes/7503.md (+6 -0)

📄 Description

Description

CI browser E2E and VRT jobs currently start the full Vite dev server on every shard. That is slow and resource-heavy, which limits how aggressively we can parallelize tests.

This change speeds up CI by building the browser bundle once, uploading it as a workflow artifact, and serving it with a small static HTTP server that sets the COOP/COEP headers the app needs for SharedArrayBuffer/SQLite. Playwright’s webServer runs that server when E2E_USE_BUILD=1; locally, the default remains yarn start unless you opt in.

Hopefully this will make the e2e test CI jobs a little bit quicker.

Related issue(s)

N/A

Testing

CI should pass

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 12.94 MB 0%
loot-core 1 4.85 MB 0%
api 1 3.88 MB 0%
cli 1 7.91 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 12.94 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.85 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 814.39 kB 0%
static/js/PayeeRuleCountLabel.js 52.12 kB 0%
static/js/ReportRouter.js 1.18 MB 0%
static/js/ScheduleEditForm.js 136.13 kB 0%
static/js/TransactionEdit.js 185.13 kB 0%
static/js/TransactionList.js 82.8 kB 0%
static/js/Value.js 4.34 MB 0%
static/js/ca.js 191.72 kB 0%
static/js/chart-theme.js 709.55 kB 0%
static/js/client.js 450.92 kB 0%
static/js/da.js 104.4 kB 0%
static/js/de.js 174.12 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 176.5 kB 0%
static/js/es.js 181.54 kB 0%
static/js/extends.js 486.5 kB 0%
static/js/fr.js 176.79 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.68 kB 0%
static/js/narrow.js 363.68 kB 0%
static/js/nb-NO.js 151.58 kB 0%
static/js/nl.js 108.66 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 193.49 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 178.91 kB 0%
static/js/theme.js 30.79 kB 0%
static/js/uk.js 212.28 kB 0%
static/js/useFormatList.js 9.86 kB 0%
static/js/wide.js 292 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 110.19 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.85 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.BiN7Vxsx.js 4.85 MB 0%

api

Total

Files count Total bundle size % Changed
1 3.88 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.88 MB 0%

cli

Total

Files count Total bundle size % Changed
1 7.91 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.91 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7503 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/14/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `claude/speed-up-playwright-tests-UQIDS` --- ### 📝 Commits (10+) - [`9206fe3`](https://github.com/actualbudget/actual/commit/9206fe3fe9c7bbf3d66886249f9ee81cabecd8aa) [AI] Speed up Playwright e2e CI jobs - [`5603da1`](https://github.com/actualbudget/actual/commit/5603da1b1c05fda20c16df113615e0ca853fe286) [AI] Fix e2e build: set REACT_APP_NETLIFY=true so test-file button renders - [`70a2444`](https://github.com/actualbudget/actual/commit/70a24449fe2a96a8819ac70222045ccefb89dee9) [AI] Reduce e2e workers from 4 to 3 to avoid animation-race flake - [`7d6966a`](https://github.com/actualbudget/actual/commit/7d6966a1b29c97493624145eacab2b69b582628f) [AI] Switch e2e to 2 workers x 4 shards - [`d20e459`](https://github.com/actualbudget/actual/commit/d20e45945c7a33745bb77d09efb6056e667de6ba) [AI] Bump e2e workers to 5 - [`fc16f34`](https://github.com/actualbudget/actual/commit/fc16f348c171b34c60dd3c2281a5d1f47c764c77) [AI] Merge origin/master into speed-up-playwright-tests branch - [`c52fbdb`](https://github.com/actualbudget/actual/commit/c52fbdb2ebdd90f723f62e088131c2220b6a8a9b) [AI] Fix e2e flakes: disable CSS animations in non-VRT runs - [`555d809`](https://github.com/actualbudget/actual/commit/555d809799ad82b3e68f5f2225b824ef72bd5745) [AI] Fix e2e flakes: bump expect timeout and rename use->runTest - [`9ce278a`](https://github.com/actualbudget/actual/commit/9ce278a5cfb2de5d9d0c74eba249cb8adf0c1c17) Add release notes for PR #7503 - [`0713a78`](https://github.com/actualbudget/actual/commit/0713a78d3c551ea7fe5a645d7eff61a5b22116df) Update 7503.md ### 📊 Changes **9 files changed** (+316 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/e2e-test.yml` (+58 -7) ➕ `packages/desktop-client/bin/serve-build.mjs` (+102 -0) 📝 `packages/desktop-client/e2e/accounts.test.ts` (+8 -1) 📝 `packages/desktop-client/e2e/fixtures.ts` (+42 -2) 📝 `packages/desktop-client/e2e/page-models/budget-page.ts` (+9 -0) 📝 `packages/desktop-client/e2e/page-models/configuration-page.ts` (+8 -2) 📝 `packages/desktop-client/e2e/page-models/navigation.ts` (+71 -10) 📝 `packages/desktop-client/playwright.config.ts` (+12 -3) ➕ `upcoming-release-notes/7503.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description CI browser E2E and VRT jobs currently start the full Vite dev server on every shard. That is slow and resource-heavy, which limits how aggressively we can parallelize tests. This change speeds up CI by building the browser bundle once, uploading it as a workflow artifact, and serving it with a small static HTTP server that sets the COOP/COEP headers the app needs for SharedArrayBuffer/SQLite. Playwright’s `webServer` runs that server when `E2E_USE_BUILD=1`; locally, the default remains `yarn start` unless you opt in. Hopefully this will make the e2e test CI jobs a little bit quicker. ## Related issue(s) <!-- e.g. Fixes #123, Relates to #456 --> N/A ## Testing CI should pass ## Checklist - [ ] Release notes added (see link above) - [ ] No obvious regressions in affected areas - [ ] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 12.94 MB | 0% loot-core | 1 | 4.85 MB | 0% api | 1 | 3.88 MB | 0% cli | 1 | 7.91 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 12.94 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.85 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 814.39 kB | 0% static/js/PayeeRuleCountLabel.js | 52.12 kB | 0% static/js/ReportRouter.js | 1.18 MB | 0% static/js/ScheduleEditForm.js | 136.13 kB | 0% static/js/TransactionEdit.js | 185.13 kB | 0% static/js/TransactionList.js | 82.8 kB | 0% static/js/Value.js | 4.34 MB | 0% static/js/ca.js | 191.72 kB | 0% static/js/chart-theme.js | 709.55 kB | 0% static/js/client.js | 450.92 kB | 0% static/js/da.js | 104.4 kB | 0% static/js/de.js | 174.12 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 176.5 kB | 0% static/js/es.js | 181.54 kB | 0% static/js/extends.js | 486.5 kB | 0% static/js/fr.js | 176.79 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.68 kB | 0% static/js/narrow.js | 363.68 kB | 0% static/js/nb-NO.js | 151.58 kB | 0% static/js/nl.js | 108.66 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 193.49 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 178.91 kB | 0% static/js/theme.js | 30.79 kB | 0% static/js/uk.js | 212.28 kB | 0% static/js/useFormatList.js | 9.86 kB | 0% static/js/wide.js | 292 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 110.19 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.85 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BiN7Vxsx.js | 4.85 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.88 MB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.91 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.91 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 22:09:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#21576
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?