mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-09 03:32:54 -05:00
[Bug]: Tracking budget should not show "cover expenses" on mobile #2142
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#2142
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @psybers on GitHub (May 18, 2025).
Verified issue does not already exist?
What happened?
I recently hopped into mobile (I rarely use mobile) and was surprised to see a notice about overspent categories and a "Cover" button. Note that I use a tracking budget, so the notion of transferring between categories to "cover" the overspending is a bit foreign.
I suspect this is just a bug and it should not show for tracking budgets. Note that no such UI shows for tracking budgets on desktop.
How can we reproduce the issue?
Where are you hosting Actual?
Docker
What browsers are you seeing the problem on?
Chrome
Operating System
Mobile Device
@psybers commented on GitHub (May 18, 2025):
Probably this code in
packages/desktop-client/src/components/mobile/budget/BudgetTable.jsxline 698:0dca8498fe/packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (L698)@youngcw commented on GitHub (May 18, 2025):
Is there a reason that you shouldn't be warned about overspending? Its true that moving money isn't really needed.
Should the banner text be different?
@psybers commented on GitHub (May 18, 2025):
@youngcw We said the same thing in two places at the same time! Here were my Discord messages:
@psybers commented on GitHub (May 18, 2025):
Note that if it stays, the counts are wrong because it includes hidden and income categories.
I don't think I care if my income is 'overspent'. Extra money is always nice.
But the hidden cats should not be warning me as they aren't "in the budget" any more.
@joel-jeremy commented on GitHub (May 20, 2025):
I'm not too familiar with the tracking budget workflow but just wondering, what scenario is having an overspent (hidden) category valid? I think it's a good warning to users that a hidden category (supposed to be zeroed out) has some amounts in it because that could throw off the budget.
Maybe we could exclude the hidden category warning in the overspent banner but add another banner about hidden categories having some amounts (positive and/or negative)?
@psybers commented on GitHub (May 20, 2025):
@joel-jeremy FYI for a tracking budget, hidden categories are not in the budget. (that was a somewhat recent change)
But the general idea of 'covering' a category does not fit the tracking budget. It is not zero-sum like envelope.
@clay53 commented on GitHub (Jul 7, 2025):
I also find the idea that my income is "overspent" odd
@YusefOuda commented on GitHub (Jul 8, 2025):
Glad to see hidden categories will not be considered going forward, but I still think that the banner should not appear for any categories on a tracking budget
@psybers commented on GitHub (Jul 8, 2025):
@youngcw The original bug, as reported, is not fixed. The original bug is that the cover expenses shows at all for tracking budgets. Not just that it should ignore hidden categories.
@youngcw commented on GitHub (Jul 8, 2025):
@psybers This comment said it was fine to stay
@psybers commented on GitHub (Jul 8, 2025):
@youngcw The warning should show, but the 'cover expenses' does not make sense.
There is no notion of 'covering' in a tracking budget.
@youngcw commented on GitHub (Jul 8, 2025):
So just the button should be gone or change the text?
@psybers commented on GitHub (Jul 8, 2025):
Well the button is useful to show what is overspent. So probably it should remain, but the whole idea of 'cover' is not a good fit for the tracking budgets.
So the name should change. And then the modal that appears would not have a notion of clicking to "cover". Maybe remove the click handler? And the modal name would also change.
The button maybe should be "View"? I guess the modal name could be "Overspent Categories" or something?
@psybers commented on GitHub (Jul 8, 2025):
Here is the current UI (on a tracking budget):
This button could be "View".
Here the modal name would be "Overspent Categories". Clicking on a category would do nothing. Unless you can think of a reasonable action there. It seems fine to leave the filter box at the top.
@clay53 commented on GitHub (Jul 8, 2025):
Is income a hidden category?
@youngcw commented on GitHub (Jul 8, 2025):
@clay53 Not as a rule. You can hide income categories if you want
@youngcw commented on GitHub (Jul 8, 2025):
@psybers How does #5307 look?
@psybers commented on GitHub (Jul 8, 2025):
@youngcw Yup, that looks like it would hit almost everything reported in this particular issue! Thank you!
The other suggestion (and this was more a suggestion) was to not include 'income' categories in the modal. For a tracking budget, I doubt anyone wants to be notified when their income is higher than they budgeted. It is just the spending categories that need to be tracked and warned.
@youngcw commented on GitHub (Jul 8, 2025):
How about now?
@YusefOuda commented on GitHub (Jul 9, 2025):
Looks good, would love the ability to dismiss the banner though
@psybers commented on GitHub (Jul 9, 2025):
@youngcw looks good!
@albertogasparin commented on GitHub (Jul 31, 2025):
As reported in https://github.com/actualbudget/actual/issues/4843 we would also like to have the option to hide / dismiss the banner.
Or at least check if all the budgets are 0 and then do not show it. As for instance in my family we like Actual but don’t have budgets (as we maximise savings) and that big red banner makes us feel something is wrong…
@psybers commented on GitHub (Jul 31, 2025):
@albertogasparin When you say "don't have budgets" do you mean you literally leave each category budgeted as zero dollars? Maybe there does not need to be an option to toggle it on/off, but rather the feature could filter out any categories with a 0 budget?
@psybers commented on GitHub (Jul 31, 2025):
Let's move that discussion over to #4843 since this issue, as reported, is fixed.