github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7193] [MERGED] [AI] Promote typescript/no-for-in-array lint rule from warn to error #21361

New Issue
Closed
opened 2026-04-14 22:02:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 22:02:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7193
Author: @MatissJanis
Created: 3/13/2026
Status: ✅ Merged
Merged: 3/13/2026
Merged by: @MatissJanis

Base: master ← Head: claude/fix-for-in-array-rule-0nJ2J

📝 Commits (2)

  • 7313ea2 [AI] Promote typescript/no-for-in-array lint rule from warn to error
  • a083804 Add release notes for PR #7193

📊 Changes

4 files changed (+14 additions, -5 deletions)

View changed files

📝 .oxlintrc.json (+1 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx (+1 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+6 -3)
➕ upcoming-release-notes/7193.md (+6 -0)

📄 Description

Convert the oxlint rule from "warn" to "error" as noted by the existing
TODO comment, and fix the three violations by replacing for-in loops
with for-of using .entries().

https://claude.ai/code/session_01N6F8DMzUVDxNJC56jMGknf

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7193 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/13/2026 **Status:** ✅ Merged **Merged:** 3/13/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/fix-for-in-array-rule-0nJ2J` --- ### 📝 Commits (2) - [`7313ea2`](https://github.com/actualbudget/actual/commit/7313ea285dae41c72d1b4329d6439761ce1d3ef9) [AI] Promote typescript/no-for-in-array lint rule from warn to error - [`a083804`](https://github.com/actualbudget/actual/commit/a0838045934c648fefe89a3549fd9f8d2d239a2e) Add release notes for PR #7193 ### 📊 Changes **4 files changed** (+14 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+6 -3) ➕ `upcoming-release-notes/7193.md` (+6 -0) </details> ### 📄 Description Convert the oxlint rule from "warn" to "error" as noted by the existing TODO comment, and fix the three violations by replacing for-in loops with for-of using .entries(). https://claude.ai/code/session_01N6F8DMzUVDxNJC56jMGknf --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 22:02:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#21361
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?