github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #6450] [MERGED] lint: patch typescript ignored issues #20897

New Issue
Closed
opened 2026-04-14 21:48:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 21:48:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6450
Author: @MatissJanis
Created: 12/19/2025
Status: ✅ Merged
Merged: 12/19/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/updates

📝 Commits (3)

  • ef85140 Updates across multiple packages
  • 78a3869 Release notes
  • 4fc34e5 Enhance error handling in budget goals reducer by throwing an error when the template is null

📊 Changes

118 files changed (+429 additions, -428 deletions)

View changed files

📝 .oxlintrc.json (+0 -27)
📝 packages/api/methods.ts (+2 -2)
📝 packages/component-library/src/ColorPicker.tsx (+7 -7)
📝 packages/component-library/src/InitialFocus.ts (+2 -2)
📝 packages/component-library/src/InitialFocus.web.test.tsx (+1 -1)
📝 packages/component-library/src/Input.tsx (+2 -2)
📝 packages/crdt/src/crdt/merkle.ts (+1 -1)
📝 packages/crdt/src/crdt/timestamp.ts (+1 -1)
📝 packages/desktop-client/src/components/budget/goals/reducer.ts (+4 -1)
📝 packages/desktop-client/vite.config.mts (+1 -1)
📝 packages/desktop-electron/beforePackHook.ts (+1 -1)
📝 packages/desktop-electron/e2e/fixtures.ts (+3 -3)
📝 packages/desktop-electron/index.ts (+6 -6)
📝 packages/desktop-electron/menu.ts (+6 -1)
📝 packages/desktop-electron/preload.ts (+4 -4)
📝 packages/desktop-electron/window-state.ts (+1 -1)
📝 packages/loot-core/src/mocks/budget.ts (+1 -1)
📝 packages/loot-core/src/mocks/setup.ts (+1 -1)
📝 packages/loot-core/src/platform/client/undo/index.ts (+2 -2)
📝 packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts (+2 -2)

...and 80 more files

📄 Description

Summary

This PR contains code style updates across the codebase, primarily focused on:

  • Type imports: Updated imports to use type keyword for type-only imports (e.g., import { type Foo } instead of import { Foo })
  • Type definitions: Converted many interface declarations to type declarations for consistency
  • Linting configuration: Removed oxlint rules for consistent-type-imports and consistent-type-definitions that were previously disabled

Changes

  • 116 files changed with 419 insertions and 427 deletions
  • Updates span across multiple packages:
    • packages/api/
    • packages/component-library/
    • packages/crdt/
    • packages/desktop-client/
    • packages/desktop-electron/
    • packages/loot-core/
    • packages/sync-server/

Impact

These are primarily stylistic changes that improve code consistency. No functional changes are expected.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6450 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 12/19/2025 **Status:** ✅ Merged **Merged:** 12/19/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/updates` --- ### 📝 Commits (3) - [`ef85140`](https://github.com/actualbudget/actual/commit/ef85140b5564427f54ee97cf45467dfc118dab20) Updates across multiple packages - [`78a3869`](https://github.com/actualbudget/actual/commit/78a386952fe387e5cff6a55ceb9a45b542b95179) Release notes - [`4fc34e5`](https://github.com/actualbudget/actual/commit/4fc34e5291eae53c0d1f5171e03ede75cd7cd089) Enhance error handling in budget goals reducer by throwing an error when the template is null ### 📊 Changes **118 files changed** (+429 additions, -428 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+0 -27) 📝 `packages/api/methods.ts` (+2 -2) 📝 `packages/component-library/src/ColorPicker.tsx` (+7 -7) 📝 `packages/component-library/src/InitialFocus.ts` (+2 -2) 📝 `packages/component-library/src/InitialFocus.web.test.tsx` (+1 -1) 📝 `packages/component-library/src/Input.tsx` (+2 -2) 📝 `packages/crdt/src/crdt/merkle.ts` (+1 -1) 📝 `packages/crdt/src/crdt/timestamp.ts` (+1 -1) 📝 `packages/desktop-client/src/components/budget/goals/reducer.ts` (+4 -1) 📝 `packages/desktop-client/vite.config.mts` (+1 -1) 📝 `packages/desktop-electron/beforePackHook.ts` (+1 -1) 📝 `packages/desktop-electron/e2e/fixtures.ts` (+3 -3) 📝 `packages/desktop-electron/index.ts` (+6 -6) 📝 `packages/desktop-electron/menu.ts` (+6 -1) 📝 `packages/desktop-electron/preload.ts` (+4 -4) 📝 `packages/desktop-electron/window-state.ts` (+1 -1) 📝 `packages/loot-core/src/mocks/budget.ts` (+1 -1) 📝 `packages/loot-core/src/mocks/setup.ts` (+1 -1) 📝 `packages/loot-core/src/platform/client/undo/index.ts` (+2 -2) 📝 `packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts` (+2 -2) _...and 80 more files_ </details> ### 📄 Description ## Summary This PR contains code style updates across the codebase, primarily focused on: - **Type imports**: Updated imports to use `type` keyword for type-only imports (e.g., `import { type Foo }` instead of `import { Foo }`) - **Type definitions**: Converted many `interface` declarations to `type` declarations for consistency - **Linting configuration**: Removed oxlint rules for `consistent-type-imports` and `consistent-type-definitions` that were previously disabled ## Changes - 116 files changed with 419 insertions and 427 deletions - Updates span across multiple packages: - `packages/api/` - `packages/component-library/` - `packages/crdt/` - `packages/desktop-client/` - `packages/desktop-electron/` - `packages/loot-core/` - `packages/sync-server/` ## Impact These are primarily stylistic changes that improve code consistency. No functional changes are expected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 21:48:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#20897
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?