github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 12:28:57 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6380] feat: trigger VRT updates via /update-vrt comment #20840

New Issue
Closed
opened 2026-04-14 21:46:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 21:46:52 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6380

State: closed
Merged: Yes

Summary

Changes how VRT screenshot updates are triggered. Instead of automatically running on every PR, the VRT update workflow now only runs when a maintainer or contributor comments /update-vrt on the PR.

New Workflow

flowchart TD
    A[PR Opened/Updated] --> B[E2E Tests Run]
    B --> C{VRT Tests}
    C -->|Pass| D[Tests Complete]
    C -->|Fail| E[Post Comment with Report Link]
    E --> F[Comment includes /update-vrt instruction]
    F --> G{User comments /update-vrt?}
    G -->|Yes| H[VRT Generate Workflow Triggers]
    H --> I[Generate VRT Patches]
    I --> J[VRT Apply Workflow Runs]
    J --> K[Screenshots Updated in PR]
    G -->|No| M[User Investigates Changes]

Changes

  1. vrt-update-generate.yml: Changed trigger from pull_request to issue_comment with /update-vrt filter
  2. e2e-test.yml: Updated VRT failure comment to inform users about the /update-vrt command

Benefits

  • Reduces unnecessary CI runs for PRs that intentionally change visual appearance
  • Gives contributors explicit control over when VRT screenshots are updated
  • Maintains the automated update capability when needed
**Original Pull Request:** https://github.com/actualbudget/actual/pull/6380 **State:** closed **Merged:** Yes --- ## Summary Changes how VRT screenshot updates are triggered. Instead of automatically running on every PR, the VRT update workflow now only runs when a maintainer or contributor comments `/update-vrt` on the PR. ## New Workflow ```mermaid flowchart TD A[PR Opened/Updated] --> B[E2E Tests Run] B --> C{VRT Tests} C -->|Pass| D[Tests Complete] C -->|Fail| E[Post Comment with Report Link] E --> F[Comment includes /update-vrt instruction] F --> G{User comments /update-vrt?} G -->|Yes| H[VRT Generate Workflow Triggers] H --> I[Generate VRT Patches] I --> J[VRT Apply Workflow Runs] J --> K[Screenshots Updated in PR] G -->|No| M[User Investigates Changes] ``` ## Changes 1. **vrt-update-generate.yml**: Changed trigger from `pull_request` to `issue_comment` with `/update-vrt` filter 2. **e2e-test.yml**: Updated VRT failure comment to inform users about the `/update-vrt` command ## Benefits - Reduces unnecessary CI runs for PRs that intentionally change visual appearance - Gives contributors explicit control over when VRT screenshots are updated - Maintains the automated update capability when needed
GiteaMirror added the pull-request label 2026-04-14 21:46:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#20840
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?