github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #6198] fix: balance rule action template variable #20744

New Issue
Closed
opened 2026-04-14 21:43:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 21:43:41 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6198

State: closed
Merged: Yes

…ategory

Fixes bug introduced in https://github.com/actualbudget/actual/pull/5939

002f74a8fa (diff-349c667806f385199d699efd549fbe9447148c6fed0939ccf571bc66f451399f) broke the balance variable in rule action templates

It meant that all transactions using the balance variable needed to have a category, instead of the previous behaviour of requiring an account. As Off-budget transactions aren't categorised, this is an issue for transactions in those accounts (e.g. the primary use case - mortgages)

These lines:
002f74a8fa/packages/loot-core/src/server/transactions/transaction-rules.ts (L970-L1005)

Need to be moved back into the if (trans.account) { statement on line 954.

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6198 **State:** closed **Merged:** Yes --- …ategory Fixes bug introduced in https://github.com/actualbudget/actual/pull/5939 https://github.com/actualbudget/actual/commit/002f74a8fa963b1ab6077f96f4e5c34ad7e62225#diff-349c667806f385199d699efd549fbe9447148c6fed0939ccf571bc66f451399f broke the `balance` variable in rule action templates It meant that all transactions using the `balance` variable needed to have a category, instead of the previous behaviour of requiring an account. As Off-budget transactions aren't categorised, this is an issue for transactions in those accounts (e.g. the primary use case - mortgages) These lines: https://github.com/actualbudget/actual/blob/002f74a8fa963b1ab6077f96f4e5c34ad7e62225/packages/loot-core/src/server/transactions/transaction-rules.ts#L970-L1005 Need to be moved back into the `if (trans.account) {` statement on line 954.
GiteaMirror added the pull-request label 2026-04-14 21:43:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#20744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?