github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 09:38:37 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #5662] [MERGED] Fix version bump logic to work if the month has rolled over #20418

New Issue
Closed
opened 2026-04-14 21:36:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 21:36:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5662
Author: @jfdoming
Created: 9/3/2025
Status: ✅ Merged
Merged: 9/5/2025
Merged by: @jfdoming

Base: master ← Head: jfdoming/fix-version-bump-script

📝 Commits (6)

  • a1fe2b1 Fix version bump logic to work if the month has rolled over
  • 52bbe44 Refactor script to be more testable
  • c7ae5b3 Add tests for regression
  • 9460144 Move tests to dedicated package
  • bd44f0c Add release notes
  • c26fa23 Coderabbit

📊 Changes

10 files changed (+268 additions, -121 deletions)

View changed files

➖ .github/actions/get-next-package-version.js (+0 -117)
📝 .github/workflows/generate-release-pr.yml (+1 -1)
📝 .github/workflows/publish-nightly-npm-packages.yml (+3 -3)
➕ packages/ci-actions/bin/get-next-package-version.js (+73 -0)
➕ packages/ci-actions/package.json (+11 -0)
➕ packages/ci-actions/src/versions/get-next-package-version.js (+72 -0)
➕ packages/ci-actions/src/versions/get-next-package-version.test.js (+85 -0)
➕ packages/ci-actions/vitest.config.mts (+9 -0)
➕ upcoming-release-notes/5662.md (+6 -0)
📝 yarn.lock (+8 -0)

📄 Description

Along with the bugfix, also included some tests (and refactoring to make testing CI scripts easier). Strongly suggest reviewing by commit as the changes are independent and will make more sense that way.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5662 **Author:** [@jfdoming](https://github.com/jfdoming) **Created:** 9/3/2025 **Status:** ✅ Merged **Merged:** 9/5/2025 **Merged by:** [@jfdoming](https://github.com/jfdoming) **Base:** `master` ← **Head:** `jfdoming/fix-version-bump-script` --- ### 📝 Commits (6) - [`a1fe2b1`](https://github.com/actualbudget/actual/commit/a1fe2b1ac0f253473ae857799ed3a4edcfbc094d) Fix version bump logic to work if the month has rolled over - [`52bbe44`](https://github.com/actualbudget/actual/commit/52bbe4474f998183ddf06b7dd906e4f14d8303f3) Refactor script to be more testable - [`c7ae5b3`](https://github.com/actualbudget/actual/commit/c7ae5b32c4292e899bcc6c4fc836377e785bcefa) Add tests for regression - [`9460144`](https://github.com/actualbudget/actual/commit/946014440f353cf34fa61e64f56641f5a8690198) Move tests to dedicated package - [`bd44f0c`](https://github.com/actualbudget/actual/commit/bd44f0c00c95ca816a9bea9a61ec787e09c50035) Add release notes - [`c26fa23`](https://github.com/actualbudget/actual/commit/c26fa2312bac5b97b4eca5be93e6617770dcf80f) Coderabbit ### 📊 Changes **10 files changed** (+268 additions, -121 deletions) <details> <summary>View changed files</summary> ➖ `.github/actions/get-next-package-version.js` (+0 -117) 📝 `.github/workflows/generate-release-pr.yml` (+1 -1) 📝 `.github/workflows/publish-nightly-npm-packages.yml` (+3 -3) ➕ `packages/ci-actions/bin/get-next-package-version.js` (+73 -0) ➕ `packages/ci-actions/package.json` (+11 -0) ➕ `packages/ci-actions/src/versions/get-next-package-version.js` (+72 -0) ➕ `packages/ci-actions/src/versions/get-next-package-version.test.js` (+85 -0) ➕ `packages/ci-actions/vitest.config.mts` (+9 -0) ➕ `upcoming-release-notes/5662.md` (+6 -0) 📝 `yarn.lock` (+8 -0) </details> ### 📄 Description Along with the bugfix, also included some tests (and refactoring to make testing CI scripts easier). Strongly suggest reviewing [by commit](https://github.com/actualbudget/actual/pull/5662/commits/a1fe2b1ac0f253473ae857799ed3a4edcfbc094d) as the changes are independent and will make more sense that way. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 21:36:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#20418
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?