github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #5639] [MERGED] feat(currency): add currency display to rules #20408

New Issue
Closed
opened 2026-04-14 21:35:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 21:35:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5639
Author: @misu-dev
Created: 8/28/2025
Status: ✅ Merged
Merged: 10/7/2025
Merged by: @joel-jeremy

Base: master ← Head: feat/add-currency-to-rules

📝 Commits (10+)

  • 5987a8c feat(currency): add to rules
  • 4db4799 doc: release notes
  • 869831d feat: remove keydown from Input
  • d77d9f8 doc: release notes
  • 1e74780 fix: make onEnter optional
  • 245141c fix: ai remark
  • adc4185 refactor: remove onKeyDown from Input.tsx
  • 86a334d fix: handle Amount (inflow) and Amount (outflow) properly
  • 442c223 [autofix.ci] apply automated fixes
  • 7a8c3da fix: update AmountInput to sign and on outflow set +

📊 Changes

8 files changed (+133 additions, -115 deletions)

View changed files

📝 packages/desktop-client/src/components/filters/FilterExpression.tsx (+1 -6)
📝 packages/desktop-client/src/components/filters/FiltersMenu.jsx (+28 -1)
📝 packages/desktop-client/src/components/rules/RuleEditor.tsx (+11 -13)
📝 packages/desktop-client/src/components/rules/Value.tsx (+3 -2)
📝 packages/desktop-client/src/components/util/AmountInput.tsx (+73 -29)
📝 packages/desktop-client/src/components/util/GenericInput.jsx (+4 -3)
📝 packages/loot-core/src/shared/rules.ts (+7 -61)
➕ upcoming-release-notes/5639.md (+6 -0)

📄 Description

Created a new PR as I force pushed the other one before reopening (https://github.com/actualbudget/actual/pull/5536).

Added other handling of the Filter as suggested by @MatissJanis. I hope the current implementation is less invasive.

Also fixes: https://github.com/actualbudget/actual/issues/5701

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5639 **Author:** [@misu-dev](https://github.com/misu-dev) **Created:** 8/28/2025 **Status:** ✅ Merged **Merged:** 10/7/2025 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `feat/add-currency-to-rules` --- ### 📝 Commits (10+) - [`5987a8c`](https://github.com/actualbudget/actual/commit/5987a8c4b1336a79b61b275f8369d52de730cce8) feat(currency): add to rules - [`4db4799`](https://github.com/actualbudget/actual/commit/4db4799a36dc9defa34798f9b79739aee6d53d82) doc: release notes - [`869831d`](https://github.com/actualbudget/actual/commit/869831d9cba3d2154aafedefd6bcf1c81089352e) feat: remove keydown from Input - [`d77d9f8`](https://github.com/actualbudget/actual/commit/d77d9f892b3f2a9f58d3b166167c23ffaada5384) doc: release notes - [`1e74780`](https://github.com/actualbudget/actual/commit/1e747808bb71e7a08bf3432aa45586be8b6cdb25) fix: make onEnter optional - [`245141c`](https://github.com/actualbudget/actual/commit/245141c24e513d65f4f669bbb7f4a9c847c711d8) fix: ai remark - [`adc4185`](https://github.com/actualbudget/actual/commit/adc4185f27354ea9e9eeac85bb5dfe998332bca0) refactor: remove onKeyDown from Input.tsx - [`86a334d`](https://github.com/actualbudget/actual/commit/86a334de39862a9dd53213f78aca16b86af6631c) fix: handle Amount (inflow) and Amount (outflow) properly - [`442c223`](https://github.com/actualbudget/actual/commit/442c223db426a8c1592265b56fc2e96149312e7f) [autofix.ci] apply automated fixes - [`7a8c3da`](https://github.com/actualbudget/actual/commit/7a8c3da43485ee3bb1a925159864d439a0c12703) fix: update AmountInput to sign and on outflow set + ### 📊 Changes **8 files changed** (+133 additions, -115 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/filters/FilterExpression.tsx` (+1 -6) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.jsx` (+28 -1) 📝 `packages/desktop-client/src/components/rules/RuleEditor.tsx` (+11 -13) 📝 `packages/desktop-client/src/components/rules/Value.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/util/AmountInput.tsx` (+73 -29) 📝 `packages/desktop-client/src/components/util/GenericInput.jsx` (+4 -3) 📝 `packages/loot-core/src/shared/rules.ts` (+7 -61) ➕ `upcoming-release-notes/5639.md` (+6 -0) </details> ### 📄 Description Created a new PR as I force pushed the other one before reopening (https://github.com/actualbudget/actual/pull/5536). Added other handling of the Filter as suggested by @MatissJanis. I hope the current implementation is less invasive. Also fixes: https://github.com/actualbudget/actual/issues/5701 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 21:35:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#20408
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?