github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #4557] [MERGED] ♻️ removing 'focused' prop from generic Input component #19814

New Issue
Closed
opened 2026-04-14 21:18:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 21:18:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4557
Author: @MatissJanis
Created: 3/6/2025
Status: ✅ Merged
Merged: 3/7/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/remove-focuesd-input

📝 Commits (1)

  • c2e2ade ♻️ removing 'focused' prop from generic Input component

📊 Changes

9 files changed (+17 additions, -34 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/Reconcile.tsx (+2 -5)
📝 packages/desktop-client/src/components/common/Input.tsx (+3 -14)
📝 packages/desktop-client/src/components/common/InputWithContent.tsx (+1 -1)
📝 packages/desktop-client/src/components/common/Modal.tsx (+0 -1)
📝 packages/desktop-client/src/components/modals/EditFieldModal.tsx (+1 -4)
📝 packages/desktop-client/src/components/select/DateSelect.tsx (+2 -5)
📝 packages/desktop-client/src/components/util/AmountInput.tsx (+2 -3)
📝 packages/desktop-client/src/components/util/PercentInput.tsx (+0 -1)
➕ upcoming-release-notes/4557.md (+6 -0)

📄 Description

As far as I'm aware - this prop does not actually do anything. It might have done something earlier..

For example: the component is used when reconciling. Even with the removal of this focused prop - the auto-focus logic still works (via other logic we have in the codebase).

Removing this prop also makes it possible to move Input to the component library as it no longer relies on a higher-level context.

Looking for 2+ approvals prior to merging.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4557 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/6/2025 **Status:** ✅ Merged **Merged:** 3/7/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/remove-focuesd-input` --- ### 📝 Commits (1) - [`c2e2ade`](https://github.com/actualbudget/actual/commit/c2e2ade42d13733237a82d68b1cd6b83a4c27b95) :recycle: removing 'focused' prop from generic Input component ### 📊 Changes **9 files changed** (+17 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/Reconcile.tsx` (+2 -5) 📝 `packages/desktop-client/src/components/common/Input.tsx` (+3 -14) 📝 `packages/desktop-client/src/components/common/InputWithContent.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/common/Modal.tsx` (+0 -1) 📝 `packages/desktop-client/src/components/modals/EditFieldModal.tsx` (+1 -4) 📝 `packages/desktop-client/src/components/select/DateSelect.tsx` (+2 -5) 📝 `packages/desktop-client/src/components/util/AmountInput.tsx` (+2 -3) 📝 `packages/desktop-client/src/components/util/PercentInput.tsx` (+0 -1) ➕ `upcoming-release-notes/4557.md` (+6 -0) </details> ### 📄 Description As far as I'm aware - this prop does not actually do anything. It might have done something earlier.. For example: the component is used when reconciling. Even with the removal of this `focused` prop - the auto-focus logic still works (via other logic we have in the codebase). Removing this prop also makes it possible to move `Input` to the component library as it no longer relies on a higher-level context. **Looking for 2+ approvals prior to merging.** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 21:18:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#19814
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?