github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #4433] [CLOSED] [WIP] Allow early payment of scheduled transactions #19744

New Issue
Closed
opened 2026-04-14 21:15:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 21:15:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/4433
Author: @AntoineTA
Created: 2/23/2025
Status: ❌ Closed

Base: master ← Head: fix-1957

📝 Commits (3)

  • bad78d3 fix: ensure scheduled transaction can be paid in advance by changing hasTransactions query
  • b0dc34d Merge branch 'master' into fix-1957
  • 9fdc8fa chore: add release note

📊 Changes

2 files changed (+38 additions, -9 deletions)

View changed files

📝 packages/loot-core/src/shared/schedules.ts (+32 -9)
➕ upcoming-release-notes/4433.md (+6 -0)

📄 Description

Fixes #1957

Currently, a scheduled transaction is considered "Paid" iff there is an actual transaction such that

  1. it is associated with the relevant schedule AND
  2. its date is the same as the date of the scheduled transaction (or at most two days before, if schedule uses approximate date).

This makes it impossible for a schedule transaction to be paid in advance, causing the behaviour described in the issue.

This PR proposes to solve this by changing the conditions under which a scheduled transaction is considered paid. More precisely, a scheduled transaction will now be paid iff there is an actual transaction such that

  1. it is associated with the relevant schedule AND
  2. its date is less than or equal to the date of the scheduled transaction
  3. its date is greater than the date of the previous scheduled transaction in this schedule (apply only to recurring schedules).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/4433 **Author:** [@AntoineTA](https://github.com/AntoineTA) **Created:** 2/23/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-1957` --- ### 📝 Commits (3) - [`bad78d3`](https://github.com/actualbudget/actual/commit/bad78d3916d93f76d814952e51e1e4605f8bded3) fix: ensure scheduled transaction can be paid in advance by changing hasTransactions query - [`b0dc34d`](https://github.com/actualbudget/actual/commit/b0dc34d3bd7290e8e3be858e506b12b1e8d73668) Merge branch 'master' into fix-1957 - [`9fdc8fa`](https://github.com/actualbudget/actual/commit/9fdc8fab1fa92ddd004a47cf38bbd32fa52d118f) chore: add release note ### 📊 Changes **2 files changed** (+38 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/shared/schedules.ts` (+32 -9) ➕ `upcoming-release-notes/4433.md` (+6 -0) </details> ### 📄 Description Fixes #1957 Currently, a scheduled transaction is considered "Paid" iff there is an actual transaction such that 1. it is associated with the relevant schedule AND 2. its date is the same as the date of the scheduled transaction (or at most two days before, if schedule uses approximate date). This makes it impossible for a schedule transaction to be paid in advance, causing the behaviour described in the issue. This PR proposes to solve this by changing the conditions under which a scheduled transaction is considered paid. More precisely, a scheduled transaction will now be paid iff there is an actual transaction such that 1. it is associated with the relevant schedule AND 2. its date is less than or equal to the date of the scheduled transaction 3. its date is greater than the date of the _previous_ scheduled transaction in this schedule (apply only to recurring schedules). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 21:15:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#19744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?