github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

Fix SQL injection vulnerability in cleanup-template.ts #1939

New Issue
Closed
opened 2026-02-28 19:59:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 19:59:10 -06:00
Owner
Copy Link

Originally created by @coderabbitai[bot] on GitHub (Mar 6, 2025).

Originally assigned to: @joel-jeremy on GitHub.

This issue addresses a SQL injection vulnerability in the cleanup-template.ts file.

Currently, there is direct string concatenation in an SQL query:

const notes = await db.all<db.DbNote>(
  `SELECT * FROM notes WHERE lower(note) like '%${TEMPLATE_PREFIX}%'`,
);

It should be replaced with parameterized queries:

const notes = await db.all<db.DbNote>(
  `SELECT * FROM notes WHERE lower(note) like ?`,
  [`%${TEMPLATE_PREFIX}%`]
);

The fix has been implemented and pushed to the 'fix-sql-injection-in-cleanup-template' branch but creating a PR is experiencing technical difficulties.

cc: @joel-jeremy

Originally created by @coderabbitai[bot] on GitHub (Mar 6, 2025). Originally assigned to: @joel-jeremy on GitHub. This issue addresses a SQL injection vulnerability in the cleanup-template.ts file. Currently, there is direct string concatenation in an SQL query: ```typescript const notes = await db.all<db.DbNote>( `SELECT * FROM notes WHERE lower(note) like '%${TEMPLATE_PREFIX}%'`, ); ``` It should be replaced with parameterized queries: ```typescript const notes = await db.all<db.DbNote>( `SELECT * FROM notes WHERE lower(note) like ?`, [`%${TEMPLATE_PREFIX}%`] ); ``` The fix has been implemented and pushed to the 'fix-sql-injection-in-cleanup-template' branch but creating a PR is experiencing technical difficulties. cc: @joel-jeremy
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1939
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?