github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2785] [MERGED] Custom Reports show activity fix #18872

New Issue
Closed
opened 2026-04-14 20:53:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 20:53:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2785
Author: @carkom
Created: 5/20/2024
Status: ✅ Merged
Merged: 6/3/2024
Merged by: @carkom

Base: master ← Head: weeklyIntervalFix

📝 Commits (5)

📊 Changes

16 files changed (+145 additions, -225 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/ChooseGraph.tsx (+5 -1)
📝 packages/desktop-client/src/components/reports/ReportOptions.ts (+3 -3)
📝 packages/desktop-client/src/components/reports/graphs/AreaGraph.tsx (+1 -1)
📝 packages/desktop-client/src/components/reports/graphs/BarGraph.tsx (+16 -57)
📝 packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx (+16 -57)
📝 packages/desktop-client/src/components/reports/graphs/LineGraph.tsx (+18 -43)
📝 packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx (+19 -49)
📝 packages/desktop-client/src/components/reports/graphs/showActivity.ts (+23 -8)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx (+2 -0)
📝 packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx (+10 -0)
📝 packages/desktop-client/src/components/reports/reports/CustomReport.tsx (+4 -2)
📝 packages/desktop-client/src/components/reports/spreadsheets/custom-spreadsheet.ts (+8 -2)
📝 packages/desktop-client/src/components/reports/spreadsheets/grouped-spreadsheet.ts (+2 -0)
📝 packages/desktop-client/src/components/reports/spreadsheets/recalculate.ts (+11 -2)
📝 packages/loot-core/src/types/models/reports.d.ts (+1 -0)
➕ upcoming-release-notes/2785.md (+6 -0)

📄 Description

There was a regression created with #2643 which broke the "showActivity" elements of custom reports since they were using negative numbers for the filters. Easy fix, just switched to "inflow/outflow"

Also had an issue with weekly show activity clicks not filtering dates correctly. To duplicate on edge Open new custom report, click table graph, click time, change interval to weekly, click any cell, notice the "filtered balance" doesn't match the cell you clicked. Can also be seen on weekly stacked bar graph and weekly line graph.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2785 **Author:** [@carkom](https://github.com/carkom) **Created:** 5/20/2024 **Status:** ✅ Merged **Merged:** 6/3/2024 **Merged by:** [@carkom](https://github.com/carkom) **Base:** `master` ← **Head:** `weeklyIntervalFix` --- ### 📝 Commits (5) - [`0dd4918`](https://github.com/actualbudget/actual/commit/0dd49188503e091751983dbd34dbda43fca71fdf) onShow Activity fix with Weekly Interval fix - [`5189f86`](https://github.com/actualbudget/actual/commit/5189f867dc01ce24ba86b5238326fabd2fcd5bbe) notes - [`35d204b`](https://github.com/actualbudget/actual/commit/35d204b94c8b593886be39a36a2df805af3b1de8) remove scrollbar - [`a9124a7`](https://github.com/actualbudget/actual/commit/a9124a75fd92cc75f5cf114562722f0eb1a46cf0) notes update - [`3070d0b`](https://github.com/actualbudget/actual/commit/3070d0b0c9a170c27268264be9bd8ed6aeb6230f) updates ### 📊 Changes **16 files changed** (+145 additions, -225 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/ChooseGraph.tsx` (+5 -1) 📝 `packages/desktop-client/src/components/reports/ReportOptions.ts` (+3 -3) 📝 `packages/desktop-client/src/components/reports/graphs/AreaGraph.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/reports/graphs/BarGraph.tsx` (+16 -57) 📝 `packages/desktop-client/src/components/reports/graphs/DonutGraph.tsx` (+16 -57) 📝 `packages/desktop-client/src/components/reports/graphs/LineGraph.tsx` (+18 -43) 📝 `packages/desktop-client/src/components/reports/graphs/StackedBarGraph.tsx` (+19 -49) 📝 `packages/desktop-client/src/components/reports/graphs/showActivity.ts` (+23 -8) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTable.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/reports/graphs/tableGraph/ReportTableRow.tsx` (+10 -0) 📝 `packages/desktop-client/src/components/reports/reports/CustomReport.tsx` (+4 -2) 📝 `packages/desktop-client/src/components/reports/spreadsheets/custom-spreadsheet.ts` (+8 -2) 📝 `packages/desktop-client/src/components/reports/spreadsheets/grouped-spreadsheet.ts` (+2 -0) 📝 `packages/desktop-client/src/components/reports/spreadsheets/recalculate.ts` (+11 -2) 📝 `packages/loot-core/src/types/models/reports.d.ts` (+1 -0) ➕ `upcoming-release-notes/2785.md` (+6 -0) </details> ### 📄 Description There was a regression created with #2643 which broke the "showActivity" elements of custom reports since they were using negative numbers for the filters. Easy fix, just switched to "inflow/outflow" Also had an issue with weekly show activity clicks not filtering dates correctly. To duplicate on edge Open new custom report, click table graph, click time, change interval to weekly, click any cell, notice the "filtered balance" doesn't match the cell you clicked. Can also be seen on weekly stacked bar graph and weekly line graph. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:53:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#18872
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?