[PR #2453] [MERGED] ♻️ (typescript) make rollover budget components strict TS compliant #18671

Closed
opened 2026-04-14 20:49:35 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2453
Author: @MatissJanis
Created: 3/10/2024
Status: Merged
Merged: 3/12/2024
Merged by: @MatissJanis

Base: masterHead: matiss/ts-strict-rollover


📝 Commits (5)

  • a371c43 ♻️ (typescript) make rollover budget components strict TS compliant
  • 4d1065c Release notes
  • 32d128b Feedback: default value for AmountInput
  • 2457a1c Merge branch 'master' into matiss/ts-strict-rollover
  • a5ec3de Remove unused stringToInteger

📊 Changes

14 files changed (+107 additions, -75 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+3 -1)
📝 packages/desktop-client/src/components/budget/rollover/BalanceTooltip.tsx (+9 -6)
📝 packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx (+5 -6)
📝 packages/desktop-client/src/components/budget/rollover/HoldTooltip.tsx (+5 -6)
📝 packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx (+9 -6)
📝 packages/desktop-client/src/components/budget/rollover/RolloverContext.tsx (+19 -5)
📝 packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx (+10 -11)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx (+25 -18)
📝 packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx (+5 -6)
📝 packages/desktop-client/src/components/budget/util.ts (+2 -2)
📝 packages/desktop-client/src/components/util/AmountInput.tsx (+1 -3)
📝 packages/loot-core/src/shared/arithmetic.ts (+7 -4)
upcoming-release-notes/2453.md (+6 -0)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2453 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/10/2024 **Status:** ✅ Merged **Merged:** 3/12/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/ts-strict-rollover` --- ### 📝 Commits (5) - [`a371c43`](https://github.com/actualbudget/actual/commit/a371c430a076c2314914af75aa2d14c55cf9f474) :recycle: (typescript) make rollover budget components strict TS compliant - [`4d1065c`](https://github.com/actualbudget/actual/commit/4d1065ca33abd55d9af5cd65d3f44b040f32e8bd) Release notes - [`32d128b`](https://github.com/actualbudget/actual/commit/32d128b7ef5450ab2104beafd1a1774b73f9729d) Feedback: default value for AmountInput - [`2457a1c`](https://github.com/actualbudget/actual/commit/2457a1c49b010e0430a44cca5546259e8203a18b) Merge branch 'master' into matiss/ts-strict-rollover - [`a5ec3de`](https://github.com/actualbudget/actual/commit/a5ec3deee630fb99fb343ca9ca078c7f326150ea) Remove unused stringToInteger ### 📊 Changes **14 files changed** (+107 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+3 -1) 📝 `packages/desktop-client/src/components/budget/rollover/BalanceTooltip.tsx` (+9 -6) 📝 `packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx` (+5 -6) 📝 `packages/desktop-client/src/components/budget/rollover/HoldTooltip.tsx` (+5 -6) 📝 `packages/desktop-client/src/components/budget/rollover/RolloverComponents.tsx` (+9 -6) 📝 `packages/desktop-client/src/components/budget/rollover/RolloverContext.tsx` (+19 -5) 📝 `packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx` (+10 -11) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx` (+25 -18) 📝 `packages/desktop-client/src/components/budget/rollover/budgetsummary/ToBudget.tsx` (+5 -6) 📝 `packages/desktop-client/src/components/budget/util.ts` (+2 -2) 📝 `packages/desktop-client/src/components/util/AmountInput.tsx` (+1 -3) 📝 `packages/loot-core/src/shared/arithmetic.ts` (+7 -4) ➕ `upcoming-release-notes/2453.md` (+6 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:49:35 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#18671