github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #1436] [MERGED] Dark mode filters/rules/transactions #18104

New Issue
Closed
opened 2026-04-14 20:34:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 20:34:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1436
Author: @carkom
Created: 7/31/2023
Status: ✅ Merged
Merged: 8/7/2023
Merged by: @MatissJanis

Base: master ← Head: darkTheme1

📝 Commits (10+)

📊 Changes

20 files changed (+472 additions, -353 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.js (+43 -32)
📝 packages/desktop-client/src/components/common/Input.tsx (+3 -2)
📝 packages/desktop-client/src/components/common/Menu.tsx (+14 -6)
📝 packages/desktop-client/src/components/common/Modal.tsx (+7 -6)
📝 packages/desktop-client/src/components/common/Select.tsx (+51 -10)
📝 packages/desktop-client/src/components/filters/FiltersMenu.js (+45 -39)
📝 packages/desktop-client/src/components/filters/SavedFilters.js (+3 -3)
📝 packages/desktop-client/src/components/forms.tsx (+13 -11)
📝 packages/desktop-client/src/components/modals/EditRule.js (+34 -22)
📝 packages/desktop-client/src/components/select/RecurringSchedulePicker.js (+12 -8)
📝 packages/desktop-client/src/components/sort.js (+2 -2)
📝 packages/desktop-client/src/components/table.tsx (+95 -76)
📝 packages/desktop-client/src/components/tooltips.js (+3 -2)
📝 packages/desktop-client/src/components/transactions/SimpleTransactionsTable.js (+2 -2)
📝 packages/desktop-client/src/components/transactions/TransactionList.js (+2 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.js (+72 -75)
📝 packages/desktop-client/src/style/styles.ts (+21 -34)
📝 packages/desktop-client/src/style/themes/dark.ts (+10 -2)
📝 packages/desktop-client/src/style/themes/light.ts (+35 -20)
➕ upcoming-release-notes/1436.md (+5 -0)

📄 Description

Trying to split darkTheme PR into smaller bits (#922).

It's actually really hard to find a good place to splice the work. Much of the smaller elements overlap so if you change one thing it changes another. And it's in this many-to-many relationship so you can't do one without doing another.

Anyway here is where I landed for the first PR. It's able to largely keep most things the same on any elements/pages I'm not touching while changing what I can for Filters/Rules.

Transactions Tables are all included, along with Modals, etc.

This one will be the largest since it is encorporating much of the base items. Hopefully we can find a way to split future PRs to be a bit smaller.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1436 **Author:** [@carkom](https://github.com/carkom) **Created:** 7/31/2023 **Status:** ✅ Merged **Merged:** 8/7/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `darkTheme1` --- ### 📝 Commits (10+) - [`1da8332`](https://github.com/actualbudget/actual/commit/1da833266adfe1a447ca269e5a42fd5520802f24) dark mode filters/rules/transactions - [`624ff20`](https://github.com/actualbudget/actual/commit/624ff203516b76862af54f2895289d1925f26429) releasae notes - [`af9042a`](https://github.com/actualbudget/actual/commit/af9042a2cdcd2773a4a6ad74a79b5f19232c7f7f) colors and fomatting. - [`9f5b3aa`](https://github.com/actualbudget/actual/commit/9f5b3aacb037f79c7b49807ecf805e5e5a6d7457) Merge branch 'master' into darkTheme1 - [`333aaa1`](https://github.com/actualbudget/actual/commit/333aaa15a02f9343ec5e5e9bcf0fe3de20ab8869) error fix - [`9ffb71f`](https://github.com/actualbudget/actual/commit/9ffb71f259703e98c866107c47944855a1b94b6c) Merge branch 'master' into darkTheme1 - [`692f583`](https://github.com/actualbudget/actual/commit/692f583e8dfb044ae1e260479615871d87330dbc) Fix Light Colors - [`9080ab3`](https://github.com/actualbudget/actual/commit/9080ab32b7f5fdf05f0da0a6fb326af308ac5b4b) Rule Modal Fix - [`cebae75`](https://github.com/actualbudget/actual/commit/cebae7500cf6326588d28819fdd203a8cf0df32d) Merge branch 'master' into darkTheme1 - [`44e0c6a`](https://github.com/actualbudget/actual/commit/44e0c6ae6bebf707a552bb2ddfa0a9565588cf0b) format/color changes ### 📊 Changes **20 files changed** (+472 additions, -353 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.js` (+43 -32) 📝 `packages/desktop-client/src/components/common/Input.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/common/Menu.tsx` (+14 -6) 📝 `packages/desktop-client/src/components/common/Modal.tsx` (+7 -6) 📝 `packages/desktop-client/src/components/common/Select.tsx` (+51 -10) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.js` (+45 -39) 📝 `packages/desktop-client/src/components/filters/SavedFilters.js` (+3 -3) 📝 `packages/desktop-client/src/components/forms.tsx` (+13 -11) 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+34 -22) 📝 `packages/desktop-client/src/components/select/RecurringSchedulePicker.js` (+12 -8) 📝 `packages/desktop-client/src/components/sort.js` (+2 -2) 📝 `packages/desktop-client/src/components/table.tsx` (+95 -76) 📝 `packages/desktop-client/src/components/tooltips.js` (+3 -2) 📝 `packages/desktop-client/src/components/transactions/SimpleTransactionsTable.js` (+2 -2) 📝 `packages/desktop-client/src/components/transactions/TransactionList.js` (+2 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.js` (+72 -75) 📝 `packages/desktop-client/src/style/styles.ts` (+21 -34) 📝 `packages/desktop-client/src/style/themes/dark.ts` (+10 -2) 📝 `packages/desktop-client/src/style/themes/light.ts` (+35 -20) ➕ `upcoming-release-notes/1436.md` (+5 -0) </details> ### 📄 Description Trying to split darkTheme PR into smaller bits (#922). It's actually really hard to find a good place to splice the work. Much of the smaller elements overlap so if you change one thing it changes another. And it's in this many-to-many relationship so you can't do one without doing another. Anyway here is where I landed for the first PR. It's able to largely keep most things the same on any elements/pages I'm not touching while changing what I can for Filters/Rules. Transactions Tables are all included, along with Modals, etc. This one will be the largest since it is encorporating much of the base items. Hopefully we can find a way to split future PRs to be a bit smaller. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:34:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#18104
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?