github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1242] [MERGED] Fix electron export issue #17981

New Issue
Closed
opened 2026-04-14 20:31:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 20:31:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1242
Author: @Shazib
Created: 7/1/2023
Status: ✅ Merged
Merged: 7/2/2023
Merged by: @j-f1

Base: master ← Head: fix-electron-export

📝 Commits (7)

  • fd3dd03 Workaround export not working
  • 2987abb Add Release Notes
  • d8565cf Merge branch 'actualbudget:master' into fix-electron-export
  • b2c159c Merge branch 'master' into fix-electron-export
  • 0c77e74 Merge branch 'actualbudget:master' into fix-electron-export
  • ff05385 refactor properly
  • a4dca24 linter fixes

📊 Changes

5 files changed (+24 additions, -5 deletions)

View changed files

📝 packages/loot-core/src/platform/server/sqlite/index.d.ts (+1 -1)
📝 packages/loot-core/src/platform/server/sqlite/index.electron.ts (+14 -2)
📝 packages/loot-core/src/platform/server/sqlite/index.web.ts (+1 -1)
📝 packages/loot-core/src/server/cloud-storage.ts (+2 -1)
➕ upcoming-release-notes/1242.md (+6 -0)

📄 Description

Solves #1238

If we are happy with this approach, which I don't love, I'll tidy it up a bit first, check the file doesn't exist, use a random(er) name, wrap it in a functon etc.

Basically the better-sqlite serialize function can't be used, as I guess under the surface its allocating a chunk of memory in C.

I tried to wrap all this logic inside the exportDatabase function in /server/sqlite/index.electron.ts but I had a lot of problems trying to import fs there if anyone can give advice.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1242 **Author:** [@Shazib](https://github.com/Shazib) **Created:** 7/1/2023 **Status:** ✅ Merged **Merged:** 7/2/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `fix-electron-export` --- ### 📝 Commits (7) - [`fd3dd03`](https://github.com/actualbudget/actual/commit/fd3dd0310adf71990668075781cde73541cfc4b4) Workaround export not working - [`2987abb`](https://github.com/actualbudget/actual/commit/2987abb53b3aea2dcad9c883d0b7764d46df87db) Add Release Notes - [`d8565cf`](https://github.com/actualbudget/actual/commit/d8565cf8df9b7af6642ac39390a77f8e06b1f2e4) Merge branch 'actualbudget:master' into fix-electron-export - [`b2c159c`](https://github.com/actualbudget/actual/commit/b2c159c39f767f89efce3d61d8c457e4ebc00b1c) Merge branch 'master' into fix-electron-export - [`0c77e74`](https://github.com/actualbudget/actual/commit/0c77e740ef4561a82e99ecebeb6e2a9f2e31dd08) Merge branch 'actualbudget:master' into fix-electron-export - [`ff05385`](https://github.com/actualbudget/actual/commit/ff05385b0c95ab11a3e12a8cf74b30f423a0d032) refactor properly - [`a4dca24`](https://github.com/actualbudget/actual/commit/a4dca243218cb863e4d7915bc63730a9af7ebf90) linter fixes ### 📊 Changes **5 files changed** (+24 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/platform/server/sqlite/index.d.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/sqlite/index.electron.ts` (+14 -2) 📝 `packages/loot-core/src/platform/server/sqlite/index.web.ts` (+1 -1) 📝 `packages/loot-core/src/server/cloud-storage.ts` (+2 -1) ➕ `upcoming-release-notes/1242.md` (+6 -0) </details> ### 📄 Description Solves #1238 If we are happy with this approach, which I don't _love_, I'll tidy it up a bit first, check the file doesn't exist, use a random(er) name, wrap it in a functon etc. Basically the `better-sqlite` `serialize` function can't be used, as I guess under the surface its allocating a chunk of memory in C. I tried to wrap all this logic inside the `exportDatabase` function in `/server/sqlite/index.electron.ts` but I had a lot of problems trying to import `fs` there if anyone can give advice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:31:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#17981
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?