github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #1216] [MERGED] Remove redundant UUID wrapper module, update uuid package to 9.x #17962

New Issue
Closed
opened 2026-04-14 20:31:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 20:31:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1216
Author: @j-f1
Created: 6/28/2023
Status: ✅ Merged
Merged: 6/28/2023
Merged by: @j-f1

Base: master ← Head: jed/uuid

📝 Commits (9)

📊 Changes

36 files changed (+168 additions, -153 deletions)

View changed files

📝 .eslintrc.js (+5 -0)
📝 packages/api/package.json (+2 -1)
📝 packages/crdt/package.json (+2 -1)
📝 packages/crdt/src/crdt/timestamp.ts (+2 -2)
📝 packages/desktop-client/package.json (+2 -0)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.test.js (+2 -2)
📝 packages/import-ynab4/importer.js (+3 -3)
📝 packages/import-ynab4/package.json (+4 -1)
📝 packages/import-ynab5/importer.js (+2 -2)
📝 packages/import-ynab5/package.json (+4 -1)
📝 packages/loot-core/package.json (+2 -1)
📝 packages/loot-core/src/client/actions/notifications.ts (+3 -2)
📝 packages/loot-core/src/mocks/index.ts (+8 -7)
📝 packages/loot-core/src/mocks/plaid.ts (+3 -3)
📝 packages/loot-core/src/platform/client/fetch/index.browser.ts (+17 -16)
📝 packages/loot-core/src/platform/client/fetch/index.web.ts (+26 -26)
📝 packages/loot-core/src/platform/client/undo/index.web.ts (+3 -3)
➖ packages/loot-core/src/platform/uuid/index.d.ts (+0 -5)
➖ packages/loot-core/src/platform/uuid/index.electron.ts (+0 -11)
➖ packages/loot-core/src/platform/uuid/index.web.ts (+0 -11)

...and 16 more files

📄 Description

I noticed that:

  • The web and electron versions of our uuid module both looked exactly the same…
  • …and deferred to the uuid package…
  • …and the async version just called the sync API.

So now we will just use the uuid package directly everywhere.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1216 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 6/28/2023 **Status:** ✅ Merged **Merged:** 6/28/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/uuid` --- ### 📝 Commits (9) - [`1520843`](https://github.com/actualbudget/actual/commit/1520843830ce7275a278e23635891fbfa90094ef) Replace redundant UUID wrapper module - [`002ad2c`](https://github.com/actualbudget/actual/commit/002ad2c554d1256024fb949a9415d07a240a234f) Add release note - [`8c31452`](https://github.com/actualbudget/actual/commit/8c314528e07d956bbb0f0f1dd46312115293a5ad) Fix tests - [`71f9a4c`](https://github.com/actualbudget/actual/commit/71f9a4cd7d9124b859c8a8eb81fd654f12e01a2b) Add uuid dep to desktop-client - [`a36e8a7`](https://github.com/actualbudget/actual/commit/a36e8a7c6eeec47f4fe3ff50e184fec3ead6e834) Update to uuid@9 - [`069d11a`](https://github.com/actualbudget/actual/commit/069d11a7a4483557d1f7108c85f48da679720042) Update release note - [`fb1c7ef`](https://github.com/actualbudget/actual/commit/fb1c7efbcfb3d26c4827151d29d8a75d5cc80153) Fix lint - [`f16f090`](https://github.com/actualbudget/actual/commit/f16f090e6ff2781091dc142bf4d3d9f081a35f2e) Add lint rule to discourage importing * from 'uuid' - [`b3f0b07`](https://github.com/actualbudget/actual/commit/b3f0b07d40eedd7761fde8e5de934c8a3af0eda3) Add @types/uuid dependencies ### 📊 Changes **36 files changed** (+168 additions, -153 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+5 -0) 📝 `packages/api/package.json` (+2 -1) 📝 `packages/crdt/package.json` (+2 -1) 📝 `packages/crdt/src/crdt/timestamp.ts` (+2 -2) 📝 `packages/desktop-client/package.json` (+2 -0) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.test.js` (+2 -2) 📝 `packages/import-ynab4/importer.js` (+3 -3) 📝 `packages/import-ynab4/package.json` (+4 -1) 📝 `packages/import-ynab5/importer.js` (+2 -2) 📝 `packages/import-ynab5/package.json` (+4 -1) 📝 `packages/loot-core/package.json` (+2 -1) 📝 `packages/loot-core/src/client/actions/notifications.ts` (+3 -2) 📝 `packages/loot-core/src/mocks/index.ts` (+8 -7) 📝 `packages/loot-core/src/mocks/plaid.ts` (+3 -3) 📝 `packages/loot-core/src/platform/client/fetch/index.browser.ts` (+17 -16) 📝 `packages/loot-core/src/platform/client/fetch/index.web.ts` (+26 -26) 📝 `packages/loot-core/src/platform/client/undo/index.web.ts` (+3 -3) ➖ `packages/loot-core/src/platform/uuid/index.d.ts` (+0 -5) ➖ `packages/loot-core/src/platform/uuid/index.electron.ts` (+0 -11) ➖ `packages/loot-core/src/platform/uuid/index.web.ts` (+0 -11) _...and 16 more files_ </details> ### 📄 Description I noticed that: - The web and electron versions of our `uuid` module both looked exactly the same… - …and deferred to the `uuid` package… - …and the async version just called the sync API. So now we will just use the `uuid` package directly everywhere. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:31:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#17962
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?