github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1186] [MERGED] chore: add more concrete types to loot-core #17939

New Issue
Closed
opened 2026-04-14 20:30:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 20:30:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1186
Author: @TomAFrench
Created: 6/25/2023
Status: ✅ Merged
Merged: 7/29/2023
Merged by: @j-f1

Base: master ← Head: more-ts

📝 Commits (10+)

📊 Changes

22 files changed (+352 additions, -198 deletions)

View changed files

📝 packages/desktop-client/src/components/settings/Experimental.tsx (+1 -1)
📝 packages/desktop-client/src/hooks/useFeatureFlag.ts (+1 -1)
📝 packages/desktop-client/src/style/theme.tsx (+1 -1)
📝 packages/loot-core/src/client/state-types/prefs.d.ts (+3 -57)
📝 packages/loot-core/src/mocks/budget.ts (+7 -4)
📝 packages/loot-core/src/server/accounts/parse-file.ts (+1 -1)
📝 packages/loot-core/src/server/api.ts (+10 -10)
📝 packages/loot-core/src/server/budget/actions.ts (+119 -24)
📝 packages/loot-core/src/server/main.test.ts (+1 -1)
📝 packages/loot-core/src/server/main.ts (+1 -1)
📝 packages/loot-core/src/server/prefs.ts (+17 -20)
📝 packages/loot-core/src/server/server-config.ts (+12 -4)
📝 packages/loot-core/src/server/sheet.ts (+27 -14)
📝 packages/loot-core/src/server/spreadsheet/globals.ts (+1 -1)
📝 packages/loot-core/src/server/spreadsheet/spreadsheet.ts (+49 -19)
📝 packages/loot-core/src/server/spreadsheet/util.ts (+1 -1)
📝 packages/loot-core/src/server/sync/encoder.ts (+1 -1)
📝 packages/loot-core/src/server/sync/index.ts (+2 -1)
📝 packages/loot-core/src/shared/months.ts (+37 -35)
📝 packages/loot-core/src/shared/util.ts (+1 -1)

...and 2 more files

📄 Description

This PR adds explicit types to several directories in loot-core. There's a slight conflict with #1180 in months.ts which will need to be resolved.

Waiting on #1077 to be merged.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1186 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 6/25/2023 **Status:** ✅ Merged **Merged:** 7/29/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `more-ts` --- ### 📝 Commits (10+) - [`9ae74c0`](https://github.com/actualbudget/actual/commit/9ae74c0d1bd36e22f357895cdf48e7906b83edac) chore: add concrete types in more areas - [`a96705e`](https://github.com/actualbudget/actual/commit/a96705efd28c01ef61bfe1a33f26521eca683032) chore: add a shared `DateLike` type alias for `months.ts` - [`c1a74ec`](https://github.com/actualbudget/actual/commit/c1a74ec22dbc6442780c1f62e76ef3c4605eb9c0) chore: fix type issues - [`beae576`](https://github.com/actualbudget/actual/commit/beae5764559add7b36d42dd08c1fca558793a2f8) chore: fix type errors - [`ca73a60`](https://github.com/actualbudget/actual/commit/ca73a60409b3f88d0828e416cafc1ae6acd69797) chore: add patch note - [`e8ff4a5`](https://github.com/actualbudget/actual/commit/e8ff4a553da7ad412e141395e7e50a258fdb5383) chore: fix test preferences - [`78f228b`](https://github.com/actualbudget/actual/commit/78f228ba55cdddc0da90bc47a48e06105a26e0bd) chore: linter - [`463ae4b`](https://github.com/actualbudget/actual/commit/463ae4bd43e4fcfb432d0cf287ac43f9c26cb7c4) Merge branch 'master' into more-ts - [`3576fd6`](https://github.com/actualbudget/actual/commit/3576fd6513f86c371e8aee176801dbd6895eab29) chore: linter - [`159ea24`](https://github.com/actualbudget/actual/commit/159ea24bb85385a97247dde1500932cd8756801f) chore: linter ### 📊 Changes **22 files changed** (+352 additions, -198 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/settings/Experimental.tsx` (+1 -1) 📝 `packages/desktop-client/src/hooks/useFeatureFlag.ts` (+1 -1) 📝 `packages/desktop-client/src/style/theme.tsx` (+1 -1) 📝 `packages/loot-core/src/client/state-types/prefs.d.ts` (+3 -57) 📝 `packages/loot-core/src/mocks/budget.ts` (+7 -4) 📝 `packages/loot-core/src/server/accounts/parse-file.ts` (+1 -1) 📝 `packages/loot-core/src/server/api.ts` (+10 -10) 📝 `packages/loot-core/src/server/budget/actions.ts` (+119 -24) 📝 `packages/loot-core/src/server/main.test.ts` (+1 -1) 📝 `packages/loot-core/src/server/main.ts` (+1 -1) 📝 `packages/loot-core/src/server/prefs.ts` (+17 -20) 📝 `packages/loot-core/src/server/server-config.ts` (+12 -4) 📝 `packages/loot-core/src/server/sheet.ts` (+27 -14) 📝 `packages/loot-core/src/server/spreadsheet/globals.ts` (+1 -1) 📝 `packages/loot-core/src/server/spreadsheet/spreadsheet.ts` (+49 -19) 📝 `packages/loot-core/src/server/spreadsheet/util.ts` (+1 -1) 📝 `packages/loot-core/src/server/sync/encoder.ts` (+1 -1) 📝 `packages/loot-core/src/server/sync/index.ts` (+2 -1) 📝 `packages/loot-core/src/shared/months.ts` (+37 -35) 📝 `packages/loot-core/src/shared/util.ts` (+1 -1) _...and 2 more files_ </details> ### 📄 Description This PR adds explicit types to several directories in `loot-core`. There's a slight conflict with #1180 in `months.ts` which will need to be resolved. Waiting on #1077 to be merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:30:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#17939
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?