[PR #1141] [MERGED] Updates to the server button at the top right #17911

Closed
opened 2026-04-14 20:30:22 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1141
Author: @j-f1
Created: 6/15/2023
Status: Merged
Merged: 6/20/2023
Merged by: @j-f1

Base: masterHead: jed/server-picker-ux


📝 Commits (8)

  • 76a4a49 Update server button in the top right to always show a menu
  • a39e646 Don’t show the loading indicator if no server is configured
  • 05c460c Hide server picker if no server is configured in the management app
  • a02f268 Delay showing the connecting message for a bit to reduce flickering
  • a387bd8 Add release note
  • 12792fb Fix failing test
  • 708b64a “Server online”
  • 69cb8a6 Merge branch 'master' into jed/server-picker-ux

📊 Changes

4 files changed (+87 additions, -55 deletions)

View changed files

📝 packages/desktop-client/e2e/onboarding.test.js (+1 -0)
📝 packages/desktop-client/src/components/LoggedInUser.js (+76 -54)
📝 packages/desktop-client/src/components/manager/ManagementApp.js (+4 -1)
upcoming-release-notes/1141.md (+6 -0)

📄 Description

It now always shows a menu, so the user doesn’t unexpectedly perform an action:

Screenshot_2023-06-15 18 10 24 Screenshot_2023-06-15 18 10 45 Screenshot_2023-06-15 18 11 03

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1141 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 6/15/2023 **Status:** ✅ Merged **Merged:** 6/20/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/server-picker-ux` --- ### 📝 Commits (8) - [`76a4a49`](https://github.com/actualbudget/actual/commit/76a4a49bc4d8982b40bc0338ff82c70272eb0bca) Update server button in the top right to always show a menu - [`a39e646`](https://github.com/actualbudget/actual/commit/a39e646478c331cc6c181227280d146372de4bbf) Don’t show the loading indicator if no server is configured - [`05c460c`](https://github.com/actualbudget/actual/commit/05c460c7dd0930e12558e0f4215d8902259afb97) Hide server picker if no server is configured in the management app - [`a02f268`](https://github.com/actualbudget/actual/commit/a02f2682f7a81be33641bc93adff038779a9d2cd) Delay showing the connecting message for a bit to reduce flickering - [`a387bd8`](https://github.com/actualbudget/actual/commit/a387bd8af23326b3b645810fedb2247f2d554e9d) Add release note - [`12792fb`](https://github.com/actualbudget/actual/commit/12792fb0061c4a1c6df38bb84919c2a9332e2113) Fix failing test - [`708b64a`](https://github.com/actualbudget/actual/commit/708b64a1c41632ce3d92b4e4840f8170bb1b0c73) “Server online” - [`69cb8a6`](https://github.com/actualbudget/actual/commit/69cb8a6a0641a3086e846779d9229a06138b4ec7) Merge branch 'master' into jed/server-picker-ux ### 📊 Changes **4 files changed** (+87 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/onboarding.test.js` (+1 -0) 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+76 -54) 📝 `packages/desktop-client/src/components/manager/ManagementApp.js` (+4 -1) ➕ `upcoming-release-notes/1141.md` (+6 -0) </details> ### 📄 Description It now always shows a menu, so the user doesn’t unexpectedly perform an action: <img width="167" alt="Screenshot_2023-06-15 18 10 24" src="https://github.com/actualbudget/actual/assets/25517624/3d87e0c3-6e0e-4a7f-a9b2-6a19b76aea88"> <img width="172" alt="Screenshot_2023-06-15 18 10 45" src="https://github.com/actualbudget/actual/assets/25517624/c6a39a29-7dff-4e3b-8dfe-32167128e988"> <img width="172" alt="Screenshot_2023-06-15 18 11 03" src="https://github.com/actualbudget/actual/assets/25517624/d2634718-adc9-43af-9d66-bd325b35fe5f"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:30:22 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#17911