github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-11 01:18:59 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

[PR #1019] [MERGED] Fix infinite loop in repeat goal #17833

New Issue
Closed
opened 2026-04-14 20:27:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 20:27:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1019
Author: @youngcw
Created: 5/10/2023
Status: ✅ Merged
Merged: 5/13/2023
Merged by: @j-f1

Base: master ← Head: fix_repeat_loop

📝 Commits (3)

  • d68b128 fix band increment placement
  • 184a1b0 release notes
  • be0fa63 Merge branch 'master' into fix_repeat_loop

📊 Changes

2 files changed (+7 additions, -1 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goaltemplates.ts (+1 -1)
➕ upcoming-release-notes/1019.md (+6 -0)

📄 Description

I believe I found the infinite loop problem in the repeat goal.

This doesn't mess things up if you are budgeting the same month that the goal starts, that's probably why we didn't see it before.

Side note: The logic always starts at the start date in the template, then increments until falling in the right month window. If this template gets used for, say, a few years, it will start to bog down the processing. If someone has a good quick fix I can add that.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1019 **Author:** [@youngcw](https://github.com/youngcw) **Created:** 5/10/2023 **Status:** ✅ Merged **Merged:** 5/13/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `fix_repeat_loop` --- ### 📝 Commits (3) - [`d68b128`](https://github.com/actualbudget/actual/commit/d68b1281377825ddfaf8c7a3d9db574e5e8d44b9) fix band increment placement - [`184a1b0`](https://github.com/actualbudget/actual/commit/184a1b04fae4a91c0c21534c830b35aa6955aa16) release notes - [`be0fa63`](https://github.com/actualbudget/actual/commit/be0fa63cbb3bce0e98477ec52b63132696db1417) Merge branch 'master' into fix_repeat_loop ### 📊 Changes **2 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+1 -1) ➕ `upcoming-release-notes/1019.md` (+6 -0) </details> ### 📄 Description I believe I found the infinite loop problem in the repeat goal. This doesn't mess things up if you are budgeting the same month that the goal starts, that's probably why we didn't see it before. Side note: The logic always starts at the start date in the template, then increments until falling in the right month window. If this template gets used for, say, a few years, it will start to bog down the processing. If someone has a good quick fix I can add that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:27:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#17833
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?