github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #237] [MERGED] Separate external, monorepo and internal imports #17439

New Issue
Closed
opened 2026-04-14 20:16:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 20:16:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/237
Author: @TomAFrench
Created: 9/2/2022
Status: ✅ Merged
Merged: 9/2/2022
Merged by: @TomAFrench

Base: master ← Head: sort-import-nonalphabetical

📝 Commits (5)

  • 13917e3 style: enforce ordering of imports
  • 9a78a6f style: sort imports in loot-core
  • bba99d4 style: sort imports in desktop-client
  • f242d46 style: sort imports in loot-design
  • 4b69f71 style: manual fixes

📊 Changes

295 files changed (+874 additions, -196 deletions)

View changed files

📝 .eslintrc.js (+27 -2)
📝 packages/desktop-client/package.json (+1 -1)
📝 packages/desktop-client/src/components/AnimatedRefresh.js (+2 -0)
📝 packages/desktop-client/src/components/App.js (+3 -0)
📝 packages/desktop-client/src/components/AppBackground.js (+4 -1)
📝 packages/desktop-client/src/components/Background.js (+1 -0)
📝 packages/desktop-client/src/components/BankSyncStatus.js (+2 -0)
📝 packages/desktop-client/src/components/Debugger.js (+3 -1)
📝 packages/desktop-client/src/components/FatalError.js (+1 -0)
📝 packages/desktop-client/src/components/FinancesApp.js (+4 -2)
📝 packages/desktop-client/src/components/FloatableSidebar.js (+2 -0)
📝 packages/desktop-client/src/components/GlobalKeys.js (+1 -0)
📝 packages/desktop-client/src/components/LoggedInUser.js (+1 -0)
📝 packages/desktop-client/src/components/MobileWebMessage.js (+1 -0)
📝 packages/desktop-client/src/components/Modals.js (+4 -2)
📝 packages/desktop-client/src/components/Notifications.js (+3 -1)
📝 packages/desktop-client/src/components/Page.js (+1 -0)
📝 packages/desktop-client/src/components/Settings.js (+3 -1)
📝 packages/desktop-client/src/components/SidebarWithData.js (+3 -1)
📝 packages/desktop-client/src/components/SpreadsheetInterface.js (+1 -0)

...and 80 more files

📄 Description

This PR is the same as #221 but without enforcing that imports are in alphabetical order

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/237 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 9/2/2022 **Status:** ✅ Merged **Merged:** 9/2/2022 **Merged by:** [@TomAFrench](https://github.com/TomAFrench) **Base:** `master` ← **Head:** `sort-import-nonalphabetical` --- ### 📝 Commits (5) - [`13917e3`](https://github.com/actualbudget/actual/commit/13917e3cc47460c377307580bc5edcb8335e832d) style: enforce ordering of imports - [`9a78a6f`](https://github.com/actualbudget/actual/commit/9a78a6fa3c8a9410806b9e83a86872d49dfcbcfa) style: sort imports in loot-core - [`bba99d4`](https://github.com/actualbudget/actual/commit/bba99d4f244b71b36e94aebb40611789fc89a82e) style: sort imports in desktop-client - [`f242d46`](https://github.com/actualbudget/actual/commit/f242d46f7b6d0c8ee4f9cf9df3bad42f0597e78e) style: sort imports in loot-design - [`4b69f71`](https://github.com/actualbudget/actual/commit/4b69f71484f727df4cdbce20e41616e3bd81a534) style: manual fixes ### 📊 Changes **295 files changed** (+874 additions, -196 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+27 -2) 📝 `packages/desktop-client/package.json` (+1 -1) 📝 `packages/desktop-client/src/components/AnimatedRefresh.js` (+2 -0) 📝 `packages/desktop-client/src/components/App.js` (+3 -0) 📝 `packages/desktop-client/src/components/AppBackground.js` (+4 -1) 📝 `packages/desktop-client/src/components/Background.js` (+1 -0) 📝 `packages/desktop-client/src/components/BankSyncStatus.js` (+2 -0) 📝 `packages/desktop-client/src/components/Debugger.js` (+3 -1) 📝 `packages/desktop-client/src/components/FatalError.js` (+1 -0) 📝 `packages/desktop-client/src/components/FinancesApp.js` (+4 -2) 📝 `packages/desktop-client/src/components/FloatableSidebar.js` (+2 -0) 📝 `packages/desktop-client/src/components/GlobalKeys.js` (+1 -0) 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+1 -0) 📝 `packages/desktop-client/src/components/MobileWebMessage.js` (+1 -0) 📝 `packages/desktop-client/src/components/Modals.js` (+4 -2) 📝 `packages/desktop-client/src/components/Notifications.js` (+3 -1) 📝 `packages/desktop-client/src/components/Page.js` (+1 -0) 📝 `packages/desktop-client/src/components/Settings.js` (+3 -1) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+3 -1) 📝 `packages/desktop-client/src/components/SpreadsheetInterface.js` (+1 -0) _...and 80 more files_ </details> ### 📄 Description This PR is the same as #221 but without enforcing that imports are in alphabetical order --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:16:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#17439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?