github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 12:28:57 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #223] [MERGED] Improve the UX around configuring a server URL #17428

New Issue
Closed
opened 2026-04-14 20:15:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 20:15:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/223
Author: @j-f1
Created: 8/30/2022
Status: ✅ Merged
Merged: 12/29/2022
Merged by: @MatissJanis

Base: master ← Head: config-server-polish

📝 Commits (10+)

  • 9cdbb2c Fix error about passing a null value to the server URL input
  • 937f507 Specify which domain will be used when you click “Use this domain”
  • bee9495 Add a useServerURL hook
  • eb0ab16 Hide server info when on the config-server page
  • 17793f1 Remove loading attribute from cancel button
  • 0b706c5 Update the server button in the corner to take the user to the “change server” page if none is configured
  • 598f63f Improve handling of no server URL in
  • 9abe7fa Add “Stop using a server” button
  • cc1e17b Auto-add https: protocol, and prompt to add http:// if that doesn’t work
  • d90559a Apply suggestions from code review

📊 Changes

5 files changed (+97 additions, -53 deletions)

View changed files

📝 packages/desktop-client/src/components/LoggedInUser.js (+13 -6)
📝 packages/desktop-client/src/components/manager/ConfigServer.js (+47 -33)
📝 packages/desktop-client/src/components/manager/ManagementApp.js (+8 -2)
📝 packages/desktop-client/src/components/manager/ServerURL.js (+11 -12)
➕ packages/desktop-client/src/hooks/useServerURL.js (+18 -0)

📄 Description

  • Change the footer to say “No server configured”
    Screenshot_2022-08-30 19 24 59
  • Update the user item to also say “No server” and navigate to /config-server on click
    Screenshot_2022-08-30 19 25 25
  • Server picker now auto-detects when you forget the protocol. It will automatically try https and use that if available. Otherwise it will fall back to http but require the user to click again to confirm (since that is insecure)
  • Also, add a “Stop using a server” button.
  • Show which URL will be used for the server with the auto-select button
    Screenshot_2022-08-30 19 39 42
  • Hide both mentions of the server when on the change server page
  • Fix a few warnings

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/223 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 8/30/2022 **Status:** ✅ Merged **Merged:** 12/29/2022 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `config-server-polish` --- ### 📝 Commits (10+) - [`9cdbb2c`](https://github.com/actualbudget/actual/commit/9cdbb2c40ccd98bb55822727cd6702e72e0702e9) Fix error about passing a null value to the server URL input - [`937f507`](https://github.com/actualbudget/actual/commit/937f507b88d6d75eb4ff7ee3dea2988e97d5c7ae) Specify which domain will be used when you click “Use this domain” - [`bee9495`](https://github.com/actualbudget/actual/commit/bee949506e71e4ef6c2e652e3b45383bc5083339) Add a useServerURL hook - [`eb0ab16`](https://github.com/actualbudget/actual/commit/eb0ab166c4606ccf74e5011b6555856e97c7688c) Hide server info when on the config-server page - [`17793f1`](https://github.com/actualbudget/actual/commit/17793f1019fa05333fcfc5fe3661ddc8b20add25) Remove loading attribute from cancel button - [`0b706c5`](https://github.com/actualbudget/actual/commit/0b706c5eeee8d87f0894766afb652716b15c7863) Update the server button in the corner to take the user to the “change server” page if none is configured - [`598f63f`](https://github.com/actualbudget/actual/commit/598f63ffe484c6aacd8a1699e5000e40dc67599b) Improve handling of no server URL in <ServerURL> - [`9abe7fa`](https://github.com/actualbudget/actual/commit/9abe7fa2ce2681dfa4599c962513ff17ad607cd7) Add “Stop using a server” button - [`cc1e17b`](https://github.com/actualbudget/actual/commit/cc1e17b115e9df0fa10965d037c1b593f62d5091) Auto-add https: protocol, and prompt to add http:// if that doesn’t work - [`d90559a`](https://github.com/actualbudget/actual/commit/d90559a6e5d5f86be3a54578a31c7bb47dd17d90) Apply suggestions from code review ### 📊 Changes **5 files changed** (+97 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+13 -6) 📝 `packages/desktop-client/src/components/manager/ConfigServer.js` (+47 -33) 📝 `packages/desktop-client/src/components/manager/ManagementApp.js` (+8 -2) 📝 `packages/desktop-client/src/components/manager/ServerURL.js` (+11 -12) ➕ `packages/desktop-client/src/hooks/useServerURL.js` (+18 -0) </details> ### 📄 Description - Change the footer to say “No server configured” <img width="275" alt="Screenshot_2022-08-30 19 24 59" src="https://user-images.githubusercontent.com/25517624/187560789-3485f8b4-4645-40b3-bdb0-cbaf7f8f6c75.png"> - Update the user item to also say “No server” and navigate to `/config-server` on click <img width="126" alt="Screenshot_2022-08-30 19 25 25" src="https://user-images.githubusercontent.com/25517624/187560815-e87fb63b-a535-40c5-aaec-5dc2135eb540.png"> - Server picker now auto-detects when you forget the protocol. It will automatically try https and use that if available. Otherwise it will fall back to http but require the user to click again to confirm (since that is insecure) <img width="573" src="https://user-images.githubusercontent.com/25517624/187561902-50e959c4-796c-44d3-b094-85ede119d9c7.gif"> - Also, add a “Stop using a server” button. - Show which URL will be used for the server with the auto-select button <img width="550" alt="Screenshot_2022-08-30 19 39 42" src="https://user-images.githubusercontent.com/25517624/187562231-3e0261cb-15e8-4cb7-b236-5f0ad9364508.png"> - Hide both mentions of the server when on the change server page - Fix a few warnings --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:15:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#17428
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?