github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #7003] [Bug]: in rule result window, imported payee doesn't have tooltip/title while payee does #17178

New Issue
Closed
opened 2026-04-14 20:05:22 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-14 20:05:22 -05:00
Owner
Copy Link

Originally created by @zdimension on GitHub (Feb 17, 2026).
Original GitHub issue: https://github.com/actualbudget/actual/issues/7003

What happened?

In the rule edition modal, the result list doesn't add title attributes to cells in the imported payee column, resulting in no tooltips for truncated values:

Image

The payee column on the other hand, has tooltips:

Image

How can we reproduce the issue?

  1. Open rule edition modal
  2. Have "imported payee" anywhere so that the result list has it
  3. No tooltip is present on overflowing cells

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @zdimension on GitHub (Feb 17, 2026). Original GitHub issue: https://github.com/actualbudget/actual/issues/7003 ### What happened? In the rule edition modal, the result list doesn't add `title` attributes to cells in the imported payee column, resulting in no tooltips for truncated values: <img width="291" height="50" alt="Image" src="https://github.com/user-attachments/assets/51c894f0-198b-40e2-b46d-049df7205c59" /> The payee column on the other hand, has tooltips: <img width="430" height="104" alt="Image" src="https://github.com/user-attachments/assets/1685ba82-d868-46ad-850e-1611979b3474" /> ### How can we reproduce the issue? 1. Open rule edition modal 2. Have "imported payee" anywhere so that the result list has it 3. No tooltip is present on overflowing cells ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the user interfacegood first issuebug labels 2026-04-14 20:05:22 -05:00
GiteaMirror commented 2026-04-14 20:05:23 -05:00
Author
Owner
Copy Link

@zdimension commented on GitHub (Feb 17, 2026):

SimpleTransactionsTable uses DisplayId for payee but a simple Field for imported payee:
253530e239/packages/desktop-client/src/components/transactions/SimpleTransactionsTable.tsx (L95-L97)
253530e239/packages/desktop-client/src/components/transactions/SimpleTransactionsTable.tsx (L123)
DisplayId adds a title:
253530e239/packages/desktop-client/src/components/util/DisplayId.tsx (L47-L50)

I guess the simplest fix would be add a title property to Field and using that.

<!-- gh-comment-id:3913376964 --> @zdimension commented on GitHub (Feb 17, 2026): `SimpleTransactionsTable` uses `DisplayId` for payee but a simple `Field` for imported payee: https://github.com/actualbudget/actual/blob/253530e2390b2ded75c4009ee2c23dea52276f03/packages/desktop-client/src/components/transactions/SimpleTransactionsTable.tsx#L95-L97 https://github.com/actualbudget/actual/blob/253530e2390b2ded75c4009ee2c23dea52276f03/packages/desktop-client/src/components/transactions/SimpleTransactionsTable.tsx#L123 `DisplayId` adds a title: https://github.com/actualbudget/actual/blob/253530e2390b2ded75c4009ee2c23dea52276f03/packages/desktop-client/src/components/util/DisplayId.tsx#L47-L50 I guess the simplest fix would be add a `title` property to `Field` and using that.
GiteaMirror commented 2026-04-14 20:05:24 -05:00
Author
Owner
Copy Link

@zdimension commented on GitHub (Feb 20, 2026):

@danielalanbates your commit says it was co-authored with Opus 4.6. Was the PR made by a AI agent? If so, I think it's not exactly the best approach for an issue that was marked as "good first issue" and "help wanted". These are supposed to be there to encourage newcomers to contribute to projects. I'd wager more than 90% of "good first issues" on GitHub could be solved by cheap AI agents but then we wouldn't have any new contributors anywhere

<!-- gh-comment-id:3934231524 --> @zdimension commented on GitHub (Feb 20, 2026): @danielalanbates your commit says it was co-authored with Opus 4.6. Was the PR made by a AI agent? If so, I think it's not exactly the best approach for an issue that was marked as "good first issue" and "help wanted". These are supposed to be there to encourage newcomers to contribute to projects. I'd wager more than 90% of "good first issues" on GitHub could be solved by cheap AI agents but then we wouldn't have any new contributors anywhere
GiteaMirror commented 2026-04-14 20:05:24 -05:00
Author
Owner
Copy Link

@danielalanbates commented on GitHub (Feb 20, 2026):

I appreciate the comment. Yes I am dialing in the software and taking on some low-hanging fruit. Sorry if that wasn't your intent.

<!-- gh-comment-id:3935607225 --> @danielalanbates commented on GitHub (Feb 20, 2026): I appreciate the comment. Yes I am dialing in the software and taking on some low-hanging fruit. Sorry if that wasn't your intent.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue user interface
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#17178
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?