github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: mobile - budget page is broken (master branch) #164

New Issue
Closed
opened 2026-02-28 18:50:45 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-02-28 18:50:45 -06:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Jan 20, 2023).

Verified issue does not already exist?

I have searched and found no existing issue

What happened?

  • the budget header style is broken (too large compared to last release)
  • budget sub-categories are no longer visible
Screenshot 2023-01-20 at 20 48 47

What error did you receive?

No response

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @MatissJanis on GitHub (Jan 20, 2023). ### Verified issue does not already exist? I have searched and found no existing issue ### What happened? - the budget header style is broken (too large compared to last release) - budget sub-categories are no longer visible <img width="266" alt="Screenshot 2023-01-20 at 20 48 47" src="https://user-images.githubusercontent.com/886567/213802598-c43304fd-95bc-4a04-bfd1-e60049360304.png"> ### What error did you receive? _No response_ ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the buguser interfacehelp wanted labels 2026-02-28 18:50:45 -06:00
GiteaMirror commented 2026-02-28 18:50:46 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Jan 20, 2023):

Last release:
Screenshot 2023-01-20 at 20 50 11

@MatissJanis commented on GitHub (Jan 20, 2023): Last release: <img width="274" alt="Screenshot 2023-01-20 at 20 50 11" src="https://user-images.githubusercontent.com/886567/213802803-9f428d29-70cf-46f9-9d1f-aa798cd4b1b4.png">
GiteaMirror commented 2026-02-28 18:50:46 -06:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (Jan 20, 2023):

Bisecting now, 4b90e37186 is good and 20c7abc150 is bad.

@j-f1 commented on GitHub (Jan 20, 2023): Bisecting now, 4b90e371869120a43adb9ef378b6d72c3691eb81 is good and 20c7abc1504d18f1498c771284d5deb60557880d is bad.
GiteaMirror commented 2026-02-28 18:50:46 -06:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (Jan 20, 2023):

git says 31792b3282 is the first bad commit
commit 31792b3282
Author: Trevor Farlow
Date: Mon Jan 16 11:41:47 2023 -0700

mobile: disable edit on tap of category balance (#471)

  • mobile: disable edit on tap of category balance
  • fixup! mobile: disable edit on tap of category balance

.../desktop-client/src/components/budget/MobileBudgetTable.js | 11 -----------
1 file changed, 11 deletions(-)

@j-f1 commented on GitHub (Jan 20, 2023): git says 31792b32828da5aebca483fa47cfb0c297eb9cb3 is the first bad commit commit 31792b32828da5aebca483fa47cfb0c297eb9cb3 Author: Trevor Farlow Date: Mon Jan 16 11:41:47 2023 -0700 > mobile: disable edit on tap of category balance (#471) > * mobile: disable edit on tap of category balance > * fixup! mobile: disable edit on tap of category balance `.../desktop-client/src/components/budget/MobileBudgetTable.js | 11 -----------` 1 file changed, 11 deletions(-)
GiteaMirror commented 2026-02-28 18:50:46 -06:00
Author
Owner
Copy Link

@j-f1 commented on GitHub (Jan 20, 2023):

Weird, not sure why that should cause the issue (cc @trevdor?)

@j-f1 commented on GitHub (Jan 20, 2023): Weird, not sure why that should cause the issue (cc @trevdor?)
GiteaMirror commented 2026-02-28 18:50:47 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Jan 20, 2023):

I think this line is bad:
31792b3282 (diff-60e094a44d38fac03fb722c1cf8eb9ddafcf42fbd2d15c0c9f4c3b7d1ec90474R337)

Should be:

- return <div>{() => content}</div>;
+ return <div>{content}</div>;
@MatissJanis commented on GitHub (Jan 20, 2023): I think this line is bad: https://github.com/actualbudget/actual/commit/31792b32828da5aebca483fa47cfb0c297eb9cb3#diff-60e094a44d38fac03fb722c1cf8eb9ddafcf42fbd2d15c0c9f4c3b7d1ec90474R337 Should be: ```diff - return <div>{() => content}</div>; + return <div>{content}</div>; ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug help wanted user interface
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#164
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?