github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug]: parseQIF function does not return assigned category thus category is empty on import modal #1625

New Issue
Open
opened 2026-02-28 19:49:05 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-02-28 19:49:05 -06:00
Owner
Copy Link

Originally created by @mrmajmaj on GitHub (Nov 27, 2024).

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

When a QIF file is being imported, qif2json function successfully parses transactions and assigns a category if there is here. But on the return of parseQIF function that assigned category is not being returned as map only returns below properties here

      .map(trans => ({
        amount: trans.amount != null ? looselyParseAmount(trans.amount) : null,
        date: trans.date,
        payee_name: trans.payee,
        imported_payee: trans.payee,
        notes: trans.memo || null,
      }))

In turn categories of imported transactions are not showing up on the import modal. You can also see other parsing functions such as parseCSV on the same file returns all properties, but not parseQIF or parseOFX functions. I can't upload QIF file here for testing but here is contents of the test file

!Type:Bank
D6/24/2024
T-100,58
POutlet
LUsual Expenses:Shopping
MPay Designer Outlet NR:123123123 Mall
^
D6/23/2024
T-20,15
PGroceriesYou
LGroceries
MPay Groceries NR:123123123 Another mall
^
D6/22/2024
T-156,99
PNike
LUsual Expenses:Shopping
MPay Nike NR:123123123123 Nike store
^
D6/21/2024
T-40,60
PRestaurantExample
LFood
MPay Food NR:123123123123 Outlet
^

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Linux

Originally created by @mrmajmaj on GitHub (Nov 27, 2024). ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? When a QIF file is being imported, `qif2json` function successfully parses transactions and assigns a category if there is [here](https://github.com/actualbudget/actual/blob/master/packages/loot-core/src/server/accounts/qif2json.ts#L73). But on the return of `parseQIF` function that assigned category is not being returned as map only returns below properties [here](https://github.com/actualbudget/actual/blob/master/packages/loot-core/src/server/accounts/parse-file.ts#L109) ``` transactions: data.transactions .map(trans => ({ amount: trans.amount != null ? looselyParseAmount(trans.amount) : null, date: trans.date, payee_name: trans.payee, imported_payee: trans.payee, notes: trans.memo || null, })) ``` In turn categories of imported transactions are not showing up on the import modal. You can also see other parsing functions such as `parseCSV` on the same file returns all properties, but not `parseQIF` or `parseOFX` functions. I can't upload QIF file here for testing but here is contents of the test file > !Type:Bank D6/24/2024 T-100,58 POutlet LUsual Expenses:Shopping MPay Designer Outlet NR:123123123 Mall ^ D6/23/2024 T-20,15 PGroceriesYou LGroceries MPay Groceries NR:123123123 Another mall ^ D6/22/2024 T-156,99 PNike LUsual Expenses:Shopping MPay Nike NR:123123123123 Nike store ^ D6/21/2024 T-40,60 PRestaurantExample LFood MPay Food NR:123123123123 Outlet ^ ### Where are you hosting Actual? Docker ### What browsers are you seeing the problem on? Chrome ### Operating System Linux
GiteaMirror added the good first issuetransaction importbug labels 2026-02-28 19:49:05 -06:00
GiteaMirror commented 2026-02-28 19:49:06 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Dec 4, 2024):

feel free to open a PR to fix this if you found the root issue.

@youngcw commented on GitHub (Dec 4, 2024): feel free to open a PR to fix this if you found the root issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue transaction import
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1625
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?