github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[Bug]: server-url related errors are not surfaced #1565

New Issue
Closed
opened 2026-02-28 19:47:19 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-02-28 19:47:19 -06:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Nov 4, 2024).

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

https://github.com/user-attachments/assets/2ebf28e0-0f2e-4c20-8907-5c64651f1f65

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @MatissJanis on GitHub (Nov 4, 2024). ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? https://github.com/user-attachments/assets/2ebf28e0-0f2e-4c20-8907-5c64651f1f65 ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the regressionuser interfacebug labels 2026-02-28 19:47:19 -06:00
GiteaMirror commented 2026-02-28 19:47:20 -06:00
Author
Owner
Copy Link

@shb9019 commented on GitHub (Nov 9, 2024):

Hi @MatissJanis, I'd love to take this up if no one's already working on it! I believe this regression was caused due to https://github.com/actualbudget/actual/pull/3736, where we're silently suppressing the URL validation error. This behavior was alluded to in https://github.com/actualbudget/actual/pull/3736#pullrequestreview-2396004709.

@shb9019 commented on GitHub (Nov 9, 2024): Hi @MatissJanis, I'd love to take this up if no one's already working on it! I believe this regression was caused due to https://github.com/actualbudget/actual/pull/3736, where we're silently suppressing the URL validation error. This behavior was alluded to in https://github.com/actualbudget/actual/pull/3736#pullrequestreview-2396004709.
GiteaMirror commented 2026-02-28 19:47:20 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Nov 14, 2024):

Feel free to send a PR for this. :)

@MatissJanis commented on GitHub (Nov 14, 2024): Feel free to send a PR for this. :)
GiteaMirror commented 2026-02-28 19:47:20 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Nov 14, 2024):

cc @MikesGlitch as an FYI

@MatissJanis commented on GitHub (Nov 14, 2024): cc @MikesGlitch as an FYI
GiteaMirror commented 2026-02-28 19:47:20 -06:00
Author
Owner
Copy Link

@MikesGlitch commented on GitHub (Nov 14, 2024):

Oops. 😊

Yeah, I added that to fix a crash state where the user somehow had an incorrect server URL (I'm not sure how they got to that state). The joinURL function failed and they got a crashed state with no way to fix it. I think it's an edge case - but would be good if any fix could also solve that.

@MikesGlitch commented on GitHub (Nov 14, 2024): Oops. 😊 Yeah, I added that to fix a crash state where the user somehow had an incorrect server URL (I'm not sure how they got to that state). The joinURL function failed and they got a crashed state with no way to fix it. I think it's an edge case - but would be good if any fix could also solve that.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug regression user interface
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1565
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?