github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-08 21:12:08 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[GH-ISSUE #3063] [Bug]: Invalid size declaration for two older javascript modals. #15475

New Issue
Closed
opened 2026-04-14 18:28:43 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-14 18:28:43 -05:00
Owner
Copy Link

Originally created by @wdpk on GitHub (Jul 16, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/3063

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

PostsOfflineNotification.jsx and ScheduleDetails.jsx both have invalid size size declarations, using only a name. the modal feature is expecting a height, width, or both.
Because these are javascript, the invalid declarations slipped by. When converted to typescript this shouldn't happen.
due to not having a size specified, these two modals could end up at full-screen width, making it hard to read.

Fixed by #2946

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @wdpk on GitHub (Jul 16, 2024). Original GitHub issue: https://github.com/actualbudget/actual/issues/3063 ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? PostsOfflineNotification.jsx and ScheduleDetails.jsx both have invalid size size declarations, using only a name. the modal feature is expecting a height, width, or both. Because these are javascript, the invalid declarations slipped by. When converted to typescript this shouldn't happen. due to not having a size specified, these two modals could end up at full-screen width, making it hard to read. Fixed by #2946 ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the bug label 2026-04-14 18:28:43 -05:00
GiteaMirror commented 2026-04-14 18:28:46 -05:00
Author
Owner
Copy Link

@psybers commented on GitHub (Jul 24, 2024):

To be clear, the "bug" is fixed (having size="small"). But the feature request to limit the size of those two modals still remains open?

<!-- gh-comment-id:2246844674 --> @psybers commented on GitHub (Jul 24, 2024): To be clear, the "bug" is fixed (having `size="small"`). But the feature request to limit the size of those two modals still remains open?
GiteaMirror commented 2026-04-14 18:28:46 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Jul 27, 2024):

#2946 was merged, so I assume this is solved

<!-- gh-comment-id:2254254275 --> @MatissJanis commented on GitHub (Jul 27, 2024): #2946 was merged, so I assume this is solved
GiteaMirror commented 2026-04-14 18:28:47 -05:00
Author
Owner
Copy Link

@wdpk commented on GitHub (Aug 15, 2024):

To be clear, the "bug" is fixed (having size="small"). But the feature request to limit the size of those two modals still remains open?

I think? I can't figure out a way to reliably make these modals pop up to see what the size looks like. based on how the others behave, and how the new ones are called, I think the size should be limited to something reasonable?

<!-- gh-comment-id:2290599037 --> @wdpk commented on GitHub (Aug 15, 2024): > To be clear, the "bug" is fixed (having `size="small"`). But the feature request to limit the size of those two modals still remains open? I think? I can't figure out a way to reliably make these modals pop up to see what the size looks like. based on how the others behave, and how the new ones are called, I *think* the size should be limited to something reasonable?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#15475
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?