github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #2938] [Bug]: Goal template balance colouring not correct on mobile #15410

New Issue
Closed
opened 2026-04-14 18:23:28 -05:00 by GiteaMirror · 9 comments
GiteaMirror commented 2026-04-14 18:23:28 -05:00
Owner
Copy Link

Originally created by @matt-fidd on GitHub (Jun 25, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/2938

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

The balance colouring to reflect goal template status (yellow under goal, green on track) works correctly on desktop but does not change to yellow on mobile and shows green regardless of if they are part of a template or not.

2024-06-25-My Finances 1.zip

Example budget attached but you can reproduce easily:

  • Enable goal templates
  • Template 20 to a category
  • Apply templates
  • Transfer 10 to another category
  • On desktop balance goes yellow, on mobile both appear green

Desktop:
image

Mobile:
image

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome

Operating System

Windows 11

Originally created by @matt-fidd on GitHub (Jun 25, 2024). Original GitHub issue: https://github.com/actualbudget/actual/issues/2938 ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? The balance colouring to reflect goal template status (yellow under goal, green on track) works correctly on desktop but does not change to yellow on mobile and shows green regardless of if they are part of a template or not. [2024-06-25-My Finances 1.zip](https://github.com/user-attachments/files/15974528/2024-06-25-My.Finances.1.zip) Example budget attached but you can reproduce easily: - Enable goal templates - Template 20 to a category - Apply templates - Transfer 10 to another category - On desktop balance goes yellow, on mobile both appear green Desktop: ![image](https://github.com/actualbudget/actual/assets/81489167/396d4628-3156-4194-a84d-fcd971aa7ae7) Mobile: ![image](https://github.com/actualbudget/actual/assets/81489167/bcb6bfeb-c186-44aa-b183-47b67fb90441) ### Where are you hosting Actual? Locally via Yarn ### What browsers are you seeing the problem on? Chrome ### Operating System Windows 11
GiteaMirror added the bug label 2026-04-14 18:23:28 -05:00
GiteaMirror commented 2026-04-14 18:23:29 -05:00
Author
Owner
Copy Link

@matt-fidd commented on GitHub (Jun 25, 2024):

This looks to be a regression caused by #2642

Before:
image

After:
image

<!-- gh-comment-id:2189514489 --> @matt-fidd commented on GitHub (Jun 25, 2024): This looks to be a regression caused by #2642 Before: ![image](https://github.com/actualbudget/actual/assets/81489167/47aa748f-bf41-4f8e-9cd0-d832b9fa7523) After: ![image](https://github.com/actualbudget/actual/assets/81489167/e6f3f972-b029-41aa-95d3-b18d16648da0)
GiteaMirror commented 2026-04-14 18:23:30 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jun 25, 2024):

Im viewing the updated budget table and its working for me

<!-- gh-comment-id:2189530718 --> @youngcw commented on GitHub (Jun 25, 2024): Im viewing the updated budget table and its working for me
GiteaMirror commented 2026-04-14 18:23:30 -05:00
Author
Owner
Copy Link

@matt-fidd commented on GitHub (Jun 25, 2024):

Odd, I can reproduce it in on https://edge.actualbudget.org too.

https://github.com/actualbudget/actual/assets/81489167/3443f714-1756-49d4-a5c6-ce3be6cfee3c

<!-- gh-comment-id:2189542042 --> @matt-fidd commented on GitHub (Jun 25, 2024): Odd, I can reproduce it in on https://edge.actualbudget.org too. https://github.com/actualbudget/actual/assets/81489167/3443f714-1756-49d4-a5c6-ce3be6cfee3c
GiteaMirror commented 2026-04-14 18:23:30 -05:00
Author
Owner
Copy Link

@matt-fidd commented on GitHub (Jun 25, 2024):

if you create a blank file do my steps reproduce it for you? I've been trying to dig into the code a bit but I'm not particularly up on React

<!-- gh-comment-id:2189591419 --> @matt-fidd commented on GitHub (Jun 25, 2024): if you create a blank file do my steps reproduce it for you? I've been trying to dig into the code a bit but I'm not particularly up on React
GiteaMirror commented 2026-04-14 18:23:31 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jun 25, 2024):

JK, im seeing the issue. Red is still working which is weird

<!-- gh-comment-id:2189607188 --> @youngcw commented on GitHub (Jun 25, 2024): JK, im seeing the issue. Red is still working which is weird
GiteaMirror commented 2026-04-14 18:23:31 -05:00
Author
Owner
Copy Link

@matt-fidd commented on GitHub (Jun 25, 2024):

I think (untested) the mobile view at current reverts back to positive number = green, negative number = red and ignores the goal template altogether

<!-- gh-comment-id:2189624244 --> @matt-fidd commented on GitHub (Jun 25, 2024): I think (untested) the mobile view at current reverts back to positive number = green, negative number = red and ignores the goal template altogether
GiteaMirror commented 2026-04-14 18:23:32 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jun 25, 2024):

@joel-jeremy Do you have an idea on why this would not be working? Ive been digging through the mobile code and I cant tell why the colors are getting ignored in the mobile view.

<!-- gh-comment-id:2189696053 --> @youngcw commented on GitHub (Jun 25, 2024): @joel-jeremy Do you have an idea on why this would not be working? Ive been digging through the mobile code and I cant tell why the colors are getting ignored in the mobile view.
GiteaMirror commented 2026-04-14 18:23:32 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jun 25, 2024):

Ok, the colors are definitely being overridden. The green and red show always. I can see that the colors are getting set by the base balanceWithCarryover commponent, but are likely getting re-set somewhere else along the line

<!-- gh-comment-id:2189728363 --> @youngcw commented on GitHub (Jun 25, 2024): Ok, the colors are definitely being overridden. The green and red show always. I can see that the colors are getting set by the base balanceWithCarryover commponent, but are likely getting re-set somewhere else along the line
GiteaMirror commented 2026-04-14 18:23:33 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jun 25, 2024):

I believe the issue is with https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx line 556-588. The base component returns colors, but the extra formatting and styling is using makeAmountFullStyle which is overwritting the goal colors

<!-- gh-comment-id:2189769721 --> @youngcw commented on GitHub (Jun 25, 2024): I believe the issue is with https://github.com/actualbudget/actual/blob/master/packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx line 556-588. The base component returns colors, but the extra formatting and styling is using makeAmountFullStyle which is overwritting the goal colors
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#15410
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?