github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[GH-ISSUE #1861] [Bug]: Electron / build (macos-latest) (pull_request) status check appears to be failing intermittently #14947

New Issue
Closed
opened 2026-04-14 17:45:39 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-14 17:45:39 -05:00
Owner
Copy Link

Originally created by @Marethyu1 on GitHub (Nov 4, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1861

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

The Electron / build (macos-latest) (pull_request) status check on pull requests is failing.

Steps to reproduce

  • Open a pull request
  • wait for Electron / build (macos-latest) (pull_request) to run
  • It reports the following failing (example here)

When did it start failing?

Looking at the commit history in master it started failing in the last few days - however it is happening intermittently
image

Extra details

  1. Example passing build from 5 hours ago here
    It has the following environment details
Current runner version: '2.311.0'
Operating System
  macOS
  12.6.9
  21G726
Runner Image
  Image: macos-12
  Version: 20230921.1
  Included Software: https://github.com/actions/runner-images/blob/macOS-12/20230921.1/images/macos/macos-12-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macOS-12%2F20230921.1
  1. Example failing build from 5 hours ago here
Current runner version: '2.311.0'
Operating System
  macOS
  12.7
  21G816
Runner Image
  Image: macos-12
  Version: 20231029.1
  Included Software: https://github.com/actions/runner-images/blob/macOS-12/20231029.1/images/macos/macos-12-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macOS-12%2F20231029.1

I thought it may have been environmental but the fact that it two runners ran but had different results seems to go against that (unless caching is somehow involved).

I am also able to successfully build it locally on Mac-os so, and nothing has changed regarding the package-electron script so this seems a bit strange to me.

What error did you receive?

Build Electron logs:

- Searching dependency tree
Traceback (most recent call last):
  File "/Users/runner/work/actual/actual/node_modules/@electron/rebuild/node_modules/node-gyp/gyp/gyp_main.py", line 42, in <module>
    import gyp  # noqa: E402
    ^^^^^^^^^^
  File "/Users/runner/work/actual/actual/node_modules/@electron/rebuild/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 9, in <module>
    import gyp.input
  File "/Users/runner/work/actual/actual/node_modules/@electron/rebuild/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 19, in <module>
    from distutils.version import StrictVersion
ModuleNotFoundError: No module named 'distutils'
Error: `gyp` failed with exit code: 1
    at ChildProcess.onCpExit (/Users/runner/work/actual/actual/node_modules/@electron/rebuild/node_modules/node-gyp/lib/configure.js:325:16)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess._handle.onexit (node:internal/child_process:291:12)

✖ Rebuild Failed

An unhandled error occurred inside electron-rebuild
node-gyp failed to rebuild '/Users/runner/work/actual/actual/node_modules/better-sqlite3'

Error: node-gyp failed to rebuild '/Users/runner/work/actual/actual/node_modules/better-sqlite3'
    at ChildProcess.<anonymous> (/Users/runner/work/actual/actual/node_modules/@electron/rebuild/lib/module-type/node-gyp/node-gyp.js:118:24)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess._handle.onexit (node:internal/child_process:291:12)
Error: Process completed with exit code 255.

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

Safari

Operating System

Mac OSX

Originally created by @Marethyu1 on GitHub (Nov 4, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1861 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? The ```Electron / build (macos-latest) (pull_request) ``` status check on pull requests is failing. Steps to reproduce - Open a pull request - wait for ```Electron / build (macos-latest) (pull_request) ``` to run - It reports the following failing (example [here](https://github.com/actualbudget/actual/actions/runs/6756556315/job/18366142959?pr=1860)) ## When did it start failing? Looking at the commit history in master it started failing in the last few days - however it is happening intermittently ![image](https://github.com/actualbudget/actual/assets/17978203/96be088d-be79-427d-989c-c70684733760) ## Extra details 1. Example passing build from 5 hours ago [here](https://github.com/actualbudget/actual/actions/runs/6755713334/job/18364430445) It has the following environment details ``` Current runner version: '2.311.0' Operating System macOS 12.6.9 21G726 Runner Image Image: macos-12 Version: 20230921.1 Included Software: https://github.com/actions/runner-images/blob/macOS-12/20230921.1/images/macos/macos-12-Readme.md Image Release: https://github.com/actions/runner-images/releases/tag/macOS-12%2F20230921.1 ``` 1. Example failing build from 5 hours ago [here](https://github.com/actualbudget/actual/actions/runs/6755815787/job/18364622268) ``` Current runner version: '2.311.0' Operating System macOS 12.7 21G816 Runner Image Image: macos-12 Version: 20231029.1 Included Software: https://github.com/actions/runner-images/blob/macOS-12/20231029.1/images/macos/macos-12-Readme.md Image Release: https://github.com/actions/runner-images/releases/tag/macOS-12%2F20231029.1 ``` I thought it may have been environmental but the fact that it two runners ran but had different results seems to go against that (unless caching is somehow involved). I am also able to successfully build it locally on Mac-os so, and nothing has changed regarding the package-electron script so this seems a bit strange to me. ### What error did you receive? Build Electron logs: ``` - Searching dependency tree Traceback (most recent call last): File "/Users/runner/work/actual/actual/node_modules/@electron/rebuild/node_modules/node-gyp/gyp/gyp_main.py", line 42, in <module> import gyp # noqa: E402 ^^^^^^^^^^ File "/Users/runner/work/actual/actual/node_modules/@electron/rebuild/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 9, in <module> import gyp.input File "/Users/runner/work/actual/actual/node_modules/@electron/rebuild/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 19, in <module> from distutils.version import StrictVersion ModuleNotFoundError: No module named 'distutils' Error: `gyp` failed with exit code: 1 at ChildProcess.onCpExit (/Users/runner/work/actual/actual/node_modules/@electron/rebuild/node_modules/node-gyp/lib/configure.js:325:16) at ChildProcess.emit (node:events:513:28) at ChildProcess._handle.onexit (node:internal/child_process:291:12) ✖ Rebuild Failed An unhandled error occurred inside electron-rebuild node-gyp failed to rebuild '/Users/runner/work/actual/actual/node_modules/better-sqlite3' Error: node-gyp failed to rebuild '/Users/runner/work/actual/actual/node_modules/better-sqlite3' at ChildProcess.<anonymous> (/Users/runner/work/actual/actual/node_modules/@electron/rebuild/lib/module-type/node-gyp/node-gyp.js:118:24) at ChildProcess.emit (node:events:513:28) at ChildProcess._handle.onexit (node:internal/child_process:291:12) Error: Process completed with exit code 255. ``` ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? Safari ### Operating System Mac OSX
GiteaMirror added the electronbug labels 2026-04-14 17:45:40 -05:00
GiteaMirror commented 2026-04-14 17:45:42 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Nov 4, 2023):

Thanks for the investigation! Here's some more details from my investigations: https://github.com/actualbudget/actual/pull/1857#issuecomment-1793161974

I suspect we'll have to wait for all downstream dependencies to upgrade node-gyp to v10+.

<!-- gh-comment-id:1793561142 --> @MatissJanis commented on GitHub (Nov 4, 2023): Thanks for the investigation! Here's some more details from my investigations: https://github.com/actualbudget/actual/pull/1857#issuecomment-1793161974 I suspect we'll have to wait for all downstream dependencies to upgrade `node-gyp` to v10+.
GiteaMirror commented 2026-04-14 17:45:43 -05:00
Author
Owner
Copy Link

@Marethyu1 commented on GitHub (Nov 4, 2023):

Oh amazing! Is it worth keeping this issue around until its fixed or should I close it?

<!-- gh-comment-id:1793561651 --> @Marethyu1 commented on GitHub (Nov 4, 2023): Oh amazing! Is it worth keeping this issue around until its fixed or should I close it?
GiteaMirror commented 2026-04-14 17:45:44 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Nov 4, 2023):

Lets keep it around until we get a resolution. Maybe someone else does investigations too and figures out a different solution that we could apply TODAY instead of waiting :)

<!-- gh-comment-id:1793563231 --> @MatissJanis commented on GitHub (Nov 4, 2023): Lets keep it around until we get a resolution. Maybe someone else does investigations too and figures out a different solution that we could apply TODAY instead of waiting :)
GiteaMirror commented 2026-04-14 17:45:44 -05:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Nov 5, 2023):

The electron builds are flaky for me right now, where sometimes they (claim to) work, sometimes they don't

<!-- gh-comment-id:1793770262 --> @youngcw commented on GitHub (Nov 5, 2023): The electron builds are flaky for me right now, where sometimes they (claim to) work, sometimes they don't
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug electron
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#14947
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?