github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #779] [Bug]: filtering by one-of notes #14540

New Issue
Closed
opened 2026-04-14 17:18:18 -05:00 by GiteaMirror · 6 comments
GiteaMirror commented 2026-04-14 17:18:18 -05:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Mar 18, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/779

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

Tricky to explain.. please see the video

https://user-images.githubusercontent.com/886567/226101719-3b700472-3dd0-4538-81b8-6c77d2270d0c.mov

What error did you receive?

No response

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

Originally created by @MatissJanis on GitHub (Mar 18, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/779 ### Verified issue does not already exist? - [X] I have searched and found no existing issue ### What happened? Tricky to explain.. please see the video https://user-images.githubusercontent.com/886567/226101719-3b700472-3dd0-4538-81b8-6c77d2270d0c.mov ### What error did you receive? _No response_ ### Where are you hosting Actual? Locally via Yarn ### What browsers are you seeing the problem on? Chrome ### Operating System Mac OSX
GiteaMirror added the user interfacebuggood first issue labels 2026-04-14 17:18:18 -05:00
GiteaMirror commented 2026-04-14 17:18:20 -05:00
Author
Owner
Copy Link

@Kidglove57 commented on GitHub (Mar 18, 2023):

I am unclear as to what the "One of" filter is intended for. Or what separator there should be between search criteria if this is used.
When I try it, I get a message Notes: Value cannot be empty
PS I have a very comprehensive store of Notes on transactions going back three years so will happily test anything you think of.

<!-- gh-comment-id:1474827849 --> @Kidglove57 commented on GitHub (Mar 18, 2023): I am unclear as to what the "One of" filter is intended for. Or what separator there should be between search criteria if this is used. When I try it, I get a message *Notes: Value cannot be empty* PS I have a very comprehensive store of Notes on transactions going back three years so will happily test anything you think of.
GiteaMirror commented 2026-04-14 17:18:21 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Mar 18, 2023):

You need to click "enter" for the filter to be applied.

--

But the issue here is: after adding the one-of filter and clicking on "edit" - the fields in "is" and "contains" section are not rendered.

<!-- gh-comment-id:1474828339 --> @MatissJanis commented on GitHub (Mar 18, 2023): You need to click "enter" for the filter to be applied. -- But the issue here is: after adding the one-of filter and clicking on "edit" - the fields in "is" and "contains" section are not rendered.
GiteaMirror commented 2026-04-14 17:18:22 -05:00
Author
Owner
Copy Link

@Kidglove57 commented on GitHub (Mar 18, 2023):

Thank you for explaining:

  1. I can see what you mean now! Sorry I did not pick that up immediately. Very strange indeed. In practice I cannot see how "one of" could ever be relevant in the notes field (as it is freeform)
    As an added issue:
  2. If I click "Apply" after making an entry in the "Is" or "Contains" fields I get a filter result even without additionally clicking "enter". So is there an inconsistency here?
    BUT seems irrelevant option in this field - only needed where there is multiple choice? I notice that it is not included in a number of other filter fields.

I would suggest removing this option from the Notes filter

<!-- gh-comment-id:1474830917 --> @Kidglove57 commented on GitHub (Mar 18, 2023): Thank you for explaining: 1) I can see what you mean now! Sorry I did not pick that up immediately. Very strange indeed. In practice I cannot see how "one of" could ever be relevant in the notes field (as it is freeform) As an added issue: 2) If I click "Apply" after making an entry in the "Is" or "Contains" fields I get a filter result **even** without additionally clicking "enter". So is there an inconsistency here? BUT seems irrelevant option in this field - only needed where there is multiple choice? I notice that it is not included in a number of other filter fields. I would suggest removing this option from the Notes filter
GiteaMirror commented 2026-04-14 17:18:22 -05:00
Author
Owner
Copy Link

@jacksoncooper commented on GitHub (Jun 21, 2023):

As far as I understand there is no well-defined defined GenericInput of type string with multi set due to the auto-complete mechanism.

  // This makes the UI more resilient in case of faulty data
  if (multi && !Array.isArray(value)) {
    value = [];
  } else if (!multi && Array.isArray(value)) {
    return null;
  }

I'm curious what issues emerged from normalizing the field, because this PR was reopened.

<!-- gh-comment-id:1601400913 --> @jacksoncooper commented on GitHub (Jun 21, 2023): As far as I understand there is no well-defined defined `GenericInput` of type `string` with `multi` set due to the auto-complete mechanism. ```ts // This makes the UI more resilient in case of faulty data if (multi && !Array.isArray(value)) { value = []; } else if (!multi && Array.isArray(value)) { return null; } ``` I'm curious what issues emerged from normalizing the field, because this PR was reopened.
GiteaMirror commented 2026-04-14 17:18:23 -05:00
Author
Owner
Copy Link

@carkom commented on GitHub (Jul 8, 2023):

I would agree with with Kid. I don't think this option is needed for Notes. You can attain the same functionality with the all/any list as well. this dropdown option is a new addition and didn't exist when this issue was raised. Could remove "one-of" from notes and mark this resolved as of the merge of the saved filters PR.

<!-- gh-comment-id:1627478148 --> @carkom commented on GitHub (Jul 8, 2023): I would agree with with Kid. I don't think this option is needed for Notes. You can attain the same functionality with the all/any list as well. this dropdown option is a new addition and didn't exist when this issue was raised. Could remove "one-of" from notes and mark this resolved as of the merge of the saved filters PR.
GiteaMirror commented 2026-04-14 17:18:23 -05:00
Author
Owner
Copy Link

@carkom commented on GitHub (Jul 8, 2023):

I'm going to update my comment. This is also an issue when going from OneOf to is for all "id" type elements.

<!-- gh-comment-id:1627482961 --> @carkom commented on GitHub (Jul 8, 2023): I'm going to update my comment. This is also an issue when going from `OneOf` to `is` for all "id" type elements.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug good first issue user interface
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#14540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?