github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[GH-ISSUE #239] Importer packages don't use the current version of actual-app/api #14369

New Issue
Closed
opened 2026-04-14 17:05:46 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-14 17:05:46 -05:00
Owner
Copy Link

Originally created by @TomAFrench on GitHub (Sep 2, 2022).
Original GitHub issue: https://github.com/actualbudget/actual/issues/239

As shown here, the YNAB importer packages are pulling a version of actual-app/api from NPM rather than using the up-to-date version from within the monorepo

9c0df36e16/yarn.lock (L25-L59)

We should be using workspace ranges to ensure that this doesn't happen but when we tried this it resulted in 30min build times (https://github.com/actualbudget/actual/pull/230).

My guess on the cause of this is the cyclic dependency between loot-core -> actual-app/api -> actual-app/import-ynab4/5 -> loot-core

Originally created by @TomAFrench on GitHub (Sep 2, 2022). Original GitHub issue: https://github.com/actualbudget/actual/issues/239 As shown here, the YNAB importer packages are pulling a version of `actual-app/api` from NPM rather than using the up-to-date version from within the monorepo https://github.com/actualbudget/actual/blob/9c0df36e16d031501474bc3ee738af24479a02a1/yarn.lock#L25-L59 We should be using [workspace ranges](https://yarnpkg.com/features/workspaces#workspace-ranges-workspace) to ensure that this doesn't happen but when we tried this it resulted in 30min build times (https://github.com/actualbudget/actual/pull/230). My guess on the cause of this is the cyclic dependency between `loot-core -> actual-app/api -> actual-app/import-ynab4/5 -> loot-core`
GiteaMirror added the bughelp wanted labels 2026-04-14 17:05:46 -05:00
GiteaMirror commented 2026-04-14 17:05:48 -05:00
Author
Owner
Copy Link

@megawubs commented on GitHub (Oct 31, 2022):

Is this the reason why I'm unable to use the workspace version of actual/api inside of the YNAB importers? I'm trying to dig into #378, but debugging is a bit confusing right now.

<!-- gh-comment-id:1296626899 --> @megawubs commented on GitHub (Oct 31, 2022): Is this the reason why I'm unable to use the workspace version of `actual/api` inside of the YNAB importers? I'm trying to dig into #378, but debugging is a bit confusing right now.
GiteaMirror commented 2026-04-14 17:05:48 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Jan 16, 2023):

This has been solved

<!-- gh-comment-id:1384489505 --> @MatissJanis commented on GitHub (Jan 16, 2023): This has been solved
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#14369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?