[PR #7429] [MERGED] [AI] Add subpath import wildcard patterns to loot-core #14213

Closed
opened 2026-04-10 22:16:33 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7429
Author: @MatissJanis
Created: 4/8/2026
Status: Merged
Merged: 4/9/2026
Merged by: @MatissJanis

Base: masterHead: worktree-loot-core-subpath


📝 Commits (3)

  • 3ca3b46 [AI] Add subpath import wildcard patterns and explicit directory entries to loot-core
  • 524c8bb [AI] Add release notes for #7429
  • bbbed3e Merge remote-tracking branch 'origin/master' into worktree-loot-core-subpath

📊 Changes

156 files changed (+771 additions, -634 deletions)

View changed files

📝 .oxlintrc.json (+6 -0)
📝 packages/eslint-plugin-actual/lib/index.js (+1 -0)
packages/eslint-plugin-actual/lib/rules/prefer-subpath-imports.js (+96 -0)
📝 packages/loot-core/migrations/1722804019000_create_dashboard_table.js (+1 -1)
📝 packages/loot-core/package.json (+25 -9)
📝 packages/loot-core/src/mocks/arbitrary-schema.ts (+2 -2)
📝 packages/loot-core/src/mocks/budget.ts (+12 -12)
📝 packages/loot-core/src/mocks/index.ts (+2 -2)
📝 packages/loot-core/src/mocks/setup.ts (+16 -16)
📝 packages/loot-core/src/platform/client/connection/__mocks__/index.ts (+1 -1)
📝 packages/loot-core/src/platform/client/connection/index-types.ts (+2 -2)
📝 packages/loot-core/src/platform/client/connection/index.browser.ts (+2 -2)
📝 packages/loot-core/src/platform/client/connection/index.ts (+1 -1)
📝 packages/loot-core/src/platform/client/undo/index.ts (+1 -1)
📝 packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts (+2 -2)
📝 packages/loot-core/src/platform/server/asyncStorage/index-types.ts (+1 -1)
📝 packages/loot-core/src/platform/server/asyncStorage/index.ts (+2 -2)
📝 packages/loot-core/src/platform/server/connection/__mocks__/index.ts (+1 -1)
📝 packages/loot-core/src/platform/server/connection/index-types.ts (+2 -2)
📝 packages/loot-core/src/platform/server/connection/index.ts (+4 -4)

...and 80 more files

📄 Description

Ok, this is quite a big one..

Generally there are only a few changes here:

  • introduced an eslint rule that forces people to use subpath imports (it has autofixer!)
  • enforce this rule in "loot-core" (only there for now)
  • updating "package.json" subpath imports in loot-core with the missing entries

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 12.41 MB → 12.86 MB (+461.77 kB) +3.63%
loot-core 1 4.84 MB → 4.84 MB (-54 B) -0.00%
api 1 3.84 MB → 3.84 MB (-54 B) -0.00%
cli 1 7.89 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 12.41 MB → 12.86 MB (+461.77 kB) +3.63%
Changeset
File Δ Size
locale/zh-Hans.json 📈 +5.08 kB (+5.39%) 94.19 kB → 99.27 kB
locale/ca.json 📈 +2.23 kB (+1.18%) 189.75 kB → 191.98 kB
locale/en.json 📈 +71 B (+0.04%) 175.65 kB → 175.72 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/theme.js 30.79 kB → 485.18 kB (+454.39 kB) +1475.72%
static/js/zh-Hans.js 94.19 kB → 99.27 kB (+5.08 kB) +5.39%
static/js/ca.js 189.75 kB → 191.98 kB (+2.23 kB) +1.18%
static/js/en.js 175.65 kB → 175.72 kB (+71 B) +0.04%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 3.31 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 852.77 kB 0%
static/js/ReportRouter.js 1.17 MB 0%
static/js/TransactionList.js 82.49 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 174.38 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/es.js 181.8 kB 0%
static/js/fr.js 177.08 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.87 kB 0%
static/js/narrow.js 363.02 kB 0%
static/js/nb-NO.js 151.85 kB 0%
static/js/nl.js 108.93 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.44 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 179.3 kB 0%
static/js/uk.js 212.6 kB 0%
static/js/useTransactionBatchActions.js 4.33 MB 0%
static/js/wide.js 295 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.84 MB → 4.84 MB (-54 B) -0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/aql/compiler.ts 📈 +8 B (+0.03%) 24.69 kB → 24.7 kB
home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.ts 📉 -2 B (-0.01%) 24.71 kB → 24.7 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📉 -2 B (-0.01%) 22.17 kB → 22.17 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📉 -2 B (-0.01%) 19.56 kB → 19.56 kB
home/runner/work/actual/actual/packages/loot-core/src/server/schedules/app.ts 📉 -4 B (-0.03%) 11.92 kB → 11.92 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/months.ts 📉 -2 B (-0.04%) 4.78 kB → 4.77 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts 📉 -4 B (-0.05%) 7.84 kB → 7.84 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts 📉 -6 B (-0.07%) 8.24 kB → 8.24 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/schedules.ts 📉 -4 B (-0.08%) 4.86 kB → 4.86 kB
home/runner/work/actual/actual/packages/loot-core/src/server/schedules/find-schedules.ts 📉 -24 B (-0.33%) 7.19 kB → 7.17 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/handlebars-helpers.ts 📉 -12 B (-0.35%) 3.33 kB → 3.32 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.2cr-I6dh.js 0 B → 4.84 MB (+4.84 MB) -

Removed

Asset File Size % Changed
kcab.worker.DOvC4GKD.js 4.84 MB → 0 B (-4.84 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged


api

Total

Files count Total bundle size % Changed
1 3.84 MB → 3.84 MB (-54 B) -0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/aql/compiler.ts 📈 +8 B (+0.03%) 24.06 kB → 24.07 kB
home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.ts 📉 -2 B (-0.01%) 24.12 kB → 24.11 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📉 -2 B (-0.01%) 21.73 kB → 21.73 kB
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts 📉 -2 B (-0.01%) 19.08 kB → 19.08 kB
home/runner/work/actual/actual/packages/loot-core/src/server/schedules/app.ts 📉 -4 B (-0.03%) 11.68 kB → 11.67 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/months.ts 📉 -2 B (-0.04%) 4.62 kB → 4.62 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts 📉 -4 B (-0.05%) 7.39 kB → 7.39 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts 📉 -6 B (-0.08%) 7.78 kB → 7.77 kB
home/runner/work/actual/actual/packages/loot-core/src/shared/schedules.ts 📉 -4 B (-0.08%) 4.75 kB → 4.75 kB
home/runner/work/actual/actual/packages/loot-core/src/server/schedules/find-schedules.ts 📉 -24 B (-0.34%) 7 kB → 6.97 kB
home/runner/work/actual/actual/packages/loot-core/src/server/rules/handlebars-helpers.ts 📉 -12 B (-0.36%) 3.25 kB → 3.24 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
index.js 3.84 MB → 3.84 MB (-54 B) -0.00%

Unchanged
No assets were unchanged


cli

Total

Files count Total bundle size % Changed
1 7.89 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.89 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7429 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/9/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `worktree-loot-core-subpath` --- ### 📝 Commits (3) - [`3ca3b46`](https://github.com/actualbudget/actual/commit/3ca3b461dbb65ec95f40dba0cad996f572acf5a1) [AI] Add subpath import wildcard patterns and explicit directory entries to loot-core - [`524c8bb`](https://github.com/actualbudget/actual/commit/524c8bb1267e2fa3b417b00b5800e4699d6d4a65) [AI] Add release notes for #7429 - [`bbbed3e`](https://github.com/actualbudget/actual/commit/bbbed3e3bcddffce31cedf3a839738873a8cc09f) Merge remote-tracking branch 'origin/master' into worktree-loot-core-subpath ### 📊 Changes **156 files changed** (+771 additions, -634 deletions) <details> <summary>View changed files</summary> 📝 `.oxlintrc.json` (+6 -0) 📝 `packages/eslint-plugin-actual/lib/index.js` (+1 -0) ➕ `packages/eslint-plugin-actual/lib/rules/prefer-subpath-imports.js` (+96 -0) 📝 `packages/loot-core/migrations/1722804019000_create_dashboard_table.js` (+1 -1) 📝 `packages/loot-core/package.json` (+25 -9) 📝 `packages/loot-core/src/mocks/arbitrary-schema.ts` (+2 -2) 📝 `packages/loot-core/src/mocks/budget.ts` (+12 -12) 📝 `packages/loot-core/src/mocks/index.ts` (+2 -2) 📝 `packages/loot-core/src/mocks/setup.ts` (+16 -16) 📝 `packages/loot-core/src/platform/client/connection/__mocks__/index.ts` (+1 -1) 📝 `packages/loot-core/src/platform/client/connection/index-types.ts` (+2 -2) 📝 `packages/loot-core/src/platform/client/connection/index.browser.ts` (+2 -2) 📝 `packages/loot-core/src/platform/client/connection/index.ts` (+1 -1) 📝 `packages/loot-core/src/platform/client/undo/index.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts` (+2 -2) 📝 `packages/loot-core/src/platform/server/asyncStorage/index-types.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/asyncStorage/index.ts` (+2 -2) 📝 `packages/loot-core/src/platform/server/connection/__mocks__/index.ts` (+1 -1) 📝 `packages/loot-core/src/platform/server/connection/index-types.ts` (+2 -2) 📝 `packages/loot-core/src/platform/server/connection/index.ts` (+4 -4) _...and 80 more files_ </details> ### 📄 Description Ok, this is quite a big one.. Generally there are only a few changes here: - introduced an eslint rule that forces people to use subpath imports (it has autofixer!) - enforce this rule in "loot-core" (only there for now) - updating "package.json" subpath imports in loot-core with the missing entries <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 12.41 MB → 12.86 MB (+461.77 kB) | +3.63% loot-core | 1 | 4.84 MB → 4.84 MB (-54 B) | -0.00% api | 1 | 3.84 MB → 3.84 MB (-54 B) | -0.00% cli | 1 | 7.89 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 12.41 MB → 12.86 MB (+461.77 kB) | +3.63% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `locale/zh-Hans.json` | 📈 +5.08 kB (+5.39%) | 94.19 kB → 99.27 kB `locale/ca.json` | 📈 +2.23 kB (+1.18%) | 189.75 kB → 191.98 kB `locale/en.json` | 📈 +71 B (+0.04%) | 175.65 kB → 175.72 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/theme.js | 30.79 kB → 485.18 kB (+454.39 kB) | +1475.72% static/js/zh-Hans.js | 94.19 kB → 99.27 kB (+5.08 kB) | +5.39% static/js/ca.js | 189.75 kB → 191.98 kB (+2.23 kB) | +1.18% static/js/en.js | 175.65 kB → 175.72 kB (+71 B) | +0.04% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.31 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 852.77 kB | 0% static/js/ReportRouter.js | 1.17 MB | 0% static/js/TransactionList.js | 82.49 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.38 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/es.js | 181.8 kB | 0% static/js/fr.js | 177.08 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.87 kB | 0% static/js/narrow.js | 363.02 kB | 0% static/js/nb-NO.js | 151.85 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.44 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 179.3 kB | 0% static/js/uk.js | 212.6 kB | 0% static/js/useTransactionBatchActions.js | 4.33 MB | 0% static/js/wide.js | 295 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.84 MB → 4.84 MB (-54 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/aql/compiler.ts` | 📈 +8 B (+0.03%) | 24.69 kB → 24.7 kB `home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.ts` | 📉 -2 B (-0.01%) | 24.71 kB → 24.7 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📉 -2 B (-0.01%) | 22.17 kB → 22.17 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📉 -2 B (-0.01%) | 19.56 kB → 19.56 kB `home/runner/work/actual/actual/packages/loot-core/src/server/schedules/app.ts` | 📉 -4 B (-0.03%) | 11.92 kB → 11.92 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/months.ts` | 📉 -2 B (-0.04%) | 4.78 kB → 4.77 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts` | 📉 -4 B (-0.05%) | 7.84 kB → 7.84 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts` | 📉 -6 B (-0.07%) | 8.24 kB → 8.24 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/schedules.ts` | 📉 -4 B (-0.08%) | 4.86 kB → 4.86 kB `home/runner/work/actual/actual/packages/loot-core/src/server/schedules/find-schedules.ts` | 📉 -24 B (-0.33%) | 7.19 kB → 7.17 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/handlebars-helpers.ts` | 📉 -12 B (-0.35%) | 3.33 kB → 3.32 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.2cr-I6dh.js | 0 B → 4.84 MB (+4.84 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DOvC4GKD.js | 4.84 MB → 0 B (-4.84 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 3.84 MB → 3.84 MB (-54 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/aql/compiler.ts` | 📈 +8 B (+0.03%) | 24.06 kB → 24.07 kB `home/runner/work/actual/actual/packages/loot-core/src/server/importers/ynab5.ts` | 📉 -2 B (-0.01%) | 24.12 kB → 24.11 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📉 -2 B (-0.01%) | 21.73 kB → 21.73 kB `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transaction-rules.ts` | 📉 -2 B (-0.01%) | 19.08 kB → 19.08 kB `home/runner/work/actual/actual/packages/loot-core/src/server/schedules/app.ts` | 📉 -4 B (-0.03%) | 11.68 kB → 11.67 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/months.ts` | 📉 -2 B (-0.04%) | 4.62 kB → 4.62 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/action.ts` | 📉 -4 B (-0.05%) | 7.39 kB → 7.39 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/condition.ts` | 📉 -6 B (-0.08%) | 7.78 kB → 7.77 kB `home/runner/work/actual/actual/packages/loot-core/src/shared/schedules.ts` | 📉 -4 B (-0.08%) | 4.75 kB → 4.75 kB `home/runner/work/actual/actual/packages/loot-core/src/server/schedules/find-schedules.ts` | 📉 -24 B (-0.34%) | 7 kB → 6.97 kB `home/runner/work/actual/actual/packages/loot-core/src/server/rules/handlebars-helpers.ts` | 📉 -12 B (-0.36%) | 3.25 kB → 3.24 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.84 MB → 3.84 MB (-54 B) | -0.00% **Unchanged** No assets were unchanged </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.89 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.89 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 22:16:33 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#14213