github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7257] [MERGED] Proportional distribute for split transaction #14098

New Issue
Closed
opened 2026-04-10 22:13:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 22:13:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7257
Author: @victle
Created: 3/22/2026
Status: ✅ Merged
Merged: 4/6/2026
Merged by: @matt-fidd

Base: master ← Head: proportional-distribute

📝 Commits (10+)

  • 8573e3c Add button to proportionally distribute remaining amount of split transaction among child transactions
  • 76b9af1 Added release note
  • 6bb34c3 Increased min width for split error popover so all buttons are visible
  • 436aee3 Updated release note
  • 5a345fd Merge proportional distribution into even distribution button
  • 4c793bd Added docs on split transactions
  • d154432 [autofix.ci] apply automated fixes
  • dddb27f Fixed spelling
  • 4c2e86e [autofix.ci] apply automated fixes
  • 7e40600 Change split transaction popover hack to use resize event

📊 Changes

5 files changed (+138 additions, -36 deletions)

View changed files

📝 packages/desktop-client/src/components/transactions/TransactionsTable.tsx (+83 -36)
📝 packages/docs/docs-sidebar.js (+1 -0)
➕ packages/docs/docs/transactions/split-transactions.md (+48 -0)
➕ packages/docs/static/img/split-transactions/split-transactions-buttons.png (+0 -0)
➕ upcoming-release-notes/7257.md (+6 -0)

📄 Description

Description

This PR adds a button to proportionally distribute the remaining amount of a split transaction among the existing child transactions. One use case for me was splitting transactions into different categories, and needing to distribute the sales tax by having to pull out a calculator or do some napkin math. This change should automate that and make it simple.

I recognize this does add another UI element, so I'm open to discussing how the function actually gets called (e.g., a dropdown, or a setting).

Related issue(s)

Fixes #1166

Testing

I ran the typechecker and linter, passed all current tests, and passed e2e tests when running in headed mode. A simple way to test the feature is spinning up the dev server and:

  1. Go to any Budget and add a new transaction
  2. Change the category to a split transaction, and put in $40.00 for the total amount under Payment
  3. Add a split
  4. Input $20.00 for one split, and $10.00 for the second split
  5. Click the "Proportionally Distribute"

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 12.09 MB → 12.09 MB (+500 B) +0.00%
loot-core 1 4.83 MB 0%
api 4 4.06 MB 0%
cli 1 7.88 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 12.09 MB → 12.09 MB (+500 B) +0.00%
Changeset
File Δ Size
src/components/transactions/TransactionsTable.tsx 📈 +502 B (+0.58%) 85.21 kB → 85.7 kB
src/components/table.tsx 📉 -2 B (-0.01%) 37.63 kB → 37.62 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/useTransactionBatchActions.js 4.29 MB → 4.29 MB (+500 B) +0.01%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 3.23 MB 0%
static/js/BackgroundImage.js 119.98 kB 0%
static/js/FormulaEditor.js 846.44 kB 0%
static/js/ReportRouter.js 1.02 MB 0%
static/js/TransactionList.js 81.29 kB 0%
static/js/ca.js 182.91 kB 0%
static/js/da.js 104.66 kB 0%
static/js/de.js 174.79 kB 0%
static/js/en-GB.js 7.16 kB 0%
static/js/en.js 170.76 kB 0%
static/js/es.js 182.09 kB 0%
static/js/fr.js 177.47 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 166.25 kB 0%
static/js/narrow.js 354.27 kB 0%
static/js/nb-NO.js 152.2 kB 0%
static/js/nl.js 108.93 kB 0%
static/js/pl.js 88.34 kB 0%
static/js/pt-BR.js 177.84 kB 0%
static/js/resize-observer.js 18.03 kB 0%
static/js/sv.js 80.58 kB 0%
static/js/th.js 179.94 kB 0%
static/js/theme.js 30.68 kB 0%
static/js/uk.js 213.14 kB 0%
static/js/wide.js 418 B 0%
static/js/workbox-window.prod.es5.js 7.28 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 4.83 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.CwpE34S5.js 4.83 MB 0%

api

Total

Files count Total bundle size % Changed
4 4.06 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.84 MB 0%
from-Bl-Hslp4.js 167.73 kB 0%
multipart-parser-BnDysoMr.js 8.1 kB 0%
src-iMkUmuwR.js 43.64 kB 0%

cli

Total

Files count Total bundle size % Changed
1 7.88 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.88 MB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7257 **Author:** [@victle](https://github.com/victle) **Created:** 3/22/2026 **Status:** ✅ Merged **Merged:** 4/6/2026 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `proportional-distribute` --- ### 📝 Commits (10+) - [`8573e3c`](https://github.com/actualbudget/actual/commit/8573e3ca3c29e4c4fb90aa55245b77ede5284eff) Add button to proportionally distribute remaining amount of split transaction among child transactions - [`76b9af1`](https://github.com/actualbudget/actual/commit/76b9af16dfa4aae368fe33d311b7b1db4a2b4280) Added release note - [`6bb34c3`](https://github.com/actualbudget/actual/commit/6bb34c37469e55a747bb53292212794e37354cde) Increased min width for split error popover so all buttons are visible - [`436aee3`](https://github.com/actualbudget/actual/commit/436aee3559119e006ade215cf6075647441265c5) Updated release note - [`5a345fd`](https://github.com/actualbudget/actual/commit/5a345fd9ec096991fa14c2e9827e23ab2543a254) Merge proportional distribution into even distribution button - [`4c793bd`](https://github.com/actualbudget/actual/commit/4c793bdd35394eb6d1a34bfa0365d52dde903157) Added docs on split transactions - [`d154432`](https://github.com/actualbudget/actual/commit/d154432f837ea247d300f7e1e9a134b611e052e8) [autofix.ci] apply automated fixes - [`dddb27f`](https://github.com/actualbudget/actual/commit/dddb27f7bfc28bddd2ca8eff1992bf492c15b067) Fixed spelling - [`4c2e86e`](https://github.com/actualbudget/actual/commit/4c2e86e0986759beaea2c552b324234942e2d269) [autofix.ci] apply automated fixes - [`7e40600`](https://github.com/actualbudget/actual/commit/7e40600fc5e24d2a15de6b9f86245bbdac3dabdb) Change split transaction popover hack to use resize event ### 📊 Changes **5 files changed** (+138 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.tsx` (+83 -36) 📝 `packages/docs/docs-sidebar.js` (+1 -0) ➕ `packages/docs/docs/transactions/split-transactions.md` (+48 -0) ➕ `packages/docs/static/img/split-transactions/split-transactions-buttons.png` (+0 -0) ➕ `upcoming-release-notes/7257.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> ## Description <!-- What does this PR do? Why is it needed? Please give context on the "why?": why do we need this change? What problem is it solving for you?--> This PR adds a button to proportionally distribute the remaining amount of a split transaction among the existing child transactions. One use case for me was splitting transactions into different categories, and needing to distribute the sales tax by having to pull out a calculator or do some napkin math. This change should automate that and make it simple. I recognize this does add another UI element, so I'm open to discussing how the function actually gets called (e.g., a dropdown, or a setting). ## Related issue(s) Fixes #1166 <!-- e.g. Fixes #123, Relates to #456 --> ## Testing <!-- What did you test? How can we reproduce the issue you are fixing or how can we test the feature you built? --> I ran the typechecker and linter, passed all current tests, and passed e2e tests when running in headed mode. A simple way to test the feature is spinning up the dev server and: 1) Go to any Budget and add a new transaction 2) Change the category to a split transaction, and put in $40.00 for the total amount under Payment 3) Add a split 4) Input $20.00 for one split, and $10.00 for the second split 5) Click the "Proportionally Distribute" ## Checklist - [X] Release notes added (see link above) - [X] No obvious regressions in affected areas - [X] Self-review has been performed - I understand what each change in the code does and why it is needed <!--- actual-bot-sections ---> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 12.09 MB → 12.09 MB (+500 B) | +0.00% loot-core | 1 | 4.83 MB | 0% api | 4 | 4.06 MB | 0% cli | 1 | 7.88 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 12.09 MB → 12.09 MB (+500 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/transactions/TransactionsTable.tsx` | 📈 +502 B (+0.58%) | 85.21 kB → 85.7 kB `src/components/table.tsx` | 📉 -2 B (-0.01%) | 37.63 kB → 37.62 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/useTransactionBatchActions.js | 4.29 MB → 4.29 MB (+500 B) | +0.01% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 3.23 MB | 0% static/js/BackgroundImage.js | 119.98 kB | 0% static/js/FormulaEditor.js | 846.44 kB | 0% static/js/ReportRouter.js | 1.02 MB | 0% static/js/TransactionList.js | 81.29 kB | 0% static/js/ca.js | 182.91 kB | 0% static/js/da.js | 104.66 kB | 0% static/js/de.js | 174.79 kB | 0% static/js/en-GB.js | 7.16 kB | 0% static/js/en.js | 170.76 kB | 0% static/js/es.js | 182.09 kB | 0% static/js/fr.js | 177.47 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 166.25 kB | 0% static/js/narrow.js | 354.27 kB | 0% static/js/nb-NO.js | 152.2 kB | 0% static/js/nl.js | 108.93 kB | 0% static/js/pl.js | 88.34 kB | 0% static/js/pt-BR.js | 177.84 kB | 0% static/js/resize-observer.js | 18.03 kB | 0% static/js/sv.js | 80.58 kB | 0% static/js/th.js | 179.94 kB | 0% static/js/theme.js | 30.68 kB | 0% static/js/uk.js | 213.14 kB | 0% static/js/wide.js | 418 B | 0% static/js/workbox-window.prod.es5.js | 7.28 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 4.83 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.CwpE34S5.js | 4.83 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 4 | 4.06 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.84 MB | 0% from-Bl-Hslp4.js | 167.73 kB | 0% multipart-parser-BnDysoMr.js | 8.1 kB | 0% src-iMkUmuwR.js | 43.64 kB | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.88 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.88 MB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 22:13:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#14098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?