github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #7194] [MERGED] Add theme mode filtering to custom theme catalog #14054

New Issue
Closed
opened 2026-04-10 22:11:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 22:11:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7194
Author: @MatissJanis
Created: 3/13/2026
Status: ✅ Merged
Merged: 3/14/2026
Merged by: @MatissJanis

Base: master ← Head: claude/add-theme-mode-support-PhTOI

📝 Commits (4)

  • f789a2a [AI] Add mode field to custom theme catalog for dark/light filtering
  • 9a613f9 Add release notes for PR #7194
  • 89527f5 Change category from Features to Enhancements
  • 7044a8a [AI] Rename filter parameter to avoid shadowing useTranslation t()

📊 Changes

5 files changed (+156 additions, -20 deletions)

View changed files

📝 packages/desktop-client/src/components/settings/ThemeInstaller.tsx (+5 -3)
📝 packages/desktop-client/src/components/settings/Themes.tsx (+5 -0)
📝 packages/desktop-client/src/data/customThemeCatalog.json (+139 -17)
📝 packages/desktop-client/src/style/customThemes.ts (+1 -0)
➕ upcoming-release-notes/7194.md (+6 -0)

📄 Description

Changes:

Added light/dark mode specificity to the custom themes

Related issue(s)

https://github.com/actualbudget/actual/issues/6607

Testing

The changes can be tested by:

  1. Opening the theme settings
  2. Clicking to install a light theme - verify only light mode themes are displayed
  3. Clicking to install a dark theme - verify only dark mode themes are displayed
  4. Verifying all 18 themes display correctly with their respective modes

Checklist

  • Release notes added
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

https://claude.ai/code/session_01PtSEMRv3SpAEtdGzvYxzpa

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 27 14.92 MB → 14.92 MB (+160 B) +0.00%
loot-core 1 5.75 MB 0%
api 3 4.69 MB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
27 14.92 MB → 14.92 MB (+160 B) +0.00%
Changeset
File Δ Size
src/components/settings/Themes.tsx 📈 +86 B (+1.25%) 6.7 kB → 6.78 kB
src/components/settings/ThemeInstaller.tsx 📈 +74 B (+0.70%) 10.27 kB → 10.34 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 9.57 MB → 9.57 MB (+160 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 12.94 kB 0%
static/js/workbox-window.prod.es5.js 5.64 kB 0%
static/js/ca.js 187.85 kB 0%
static/js/da.js 106.13 kB 0%
static/js/de.js 179.82 kB 0%
static/js/en-GB.js 7.18 kB 0%
static/js/en.js 171.21 kB 0%
static/js/es.js 174.29 kB 0%
static/js/fr.js 179.34 kB 0%
static/js/it.js 170.91 kB 0%
static/js/nb-NO.js 156.74 kB 0%
static/js/nl.js 113.03 kB 0%
static/js/pl.js 89.61 kB 0%
static/js/pt-BR.js 182.82 kB 0%
static/js/th.js 181.54 kB 0%
static/js/uk.js 215.25 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 120.54 kB 0%
static/js/ReportRouter.js 1.16 MB 0%
static/js/narrow.js 638.11 kB 0%
static/js/TransactionList.js 106.52 kB 0%
static/js/wide.js 164.16 kB 0%
static/js/AppliedFilters.js 9.99 kB 0%
static/js/usePayeeRuleCounts.js 11.57 kB 0%
static/js/useTransactionBatchActions.js 13.24 kB 0%
static/js/FormulaEditor.js 1.04 MB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.75 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.Bm3zKqpv.js 5.75 MB 0%

api

Total

Files count Total bundle size % Changed
3 4.69 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 4.4 MB 0%
index-BKGP2w5F.js 285.56 kB 0%
multipart-parser-DwddZ4BH.js 9.33 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7194 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/13/2026 **Status:** ✅ Merged **Merged:** 3/14/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/add-theme-mode-support-PhTOI` --- ### 📝 Commits (4) - [`f789a2a`](https://github.com/actualbudget/actual/commit/f789a2ac4e9e1d2bc2e3960c0b2e88fbe480fb10) [AI] Add mode field to custom theme catalog for dark/light filtering - [`9a613f9`](https://github.com/actualbudget/actual/commit/9a613f98d403b97a3398a1e977462be64df03999) Add release notes for PR #7194 - [`89527f5`](https://github.com/actualbudget/actual/commit/89527f59522eb76ad9d60d0b9a257cb15007bd7a) Change category from Features to Enhancements - [`7044a8a`](https://github.com/actualbudget/actual/commit/7044a8a2acb34864b97d76e2d08188bb8f60cdfd) [AI] Rename filter parameter to avoid shadowing useTranslation t() ### 📊 Changes **5 files changed** (+156 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/settings/ThemeInstaller.tsx` (+5 -3) 📝 `packages/desktop-client/src/components/settings/Themes.tsx` (+5 -0) 📝 `packages/desktop-client/src/data/customThemeCatalog.json` (+139 -17) 📝 `packages/desktop-client/src/style/customThemes.ts` (+1 -0) ➕ `upcoming-release-notes/7194.md` (+6 -0) </details> ### 📄 Description ### Changes: Added light/dark mode specificity to the custom themes ## Related issue(s) <!-- Link to any related issues if applicable --> https://github.com/actualbudget/actual/issues/6607 ## Testing The changes can be tested by: 1. Opening the theme settings 2. Clicking to install a light theme - verify only light mode themes are displayed 3. Clicking to install a dark theme - verify only dark mode themes are displayed 4. Verifying all 18 themes display correctly with their respective modes ## Checklist - [x] Release notes added - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed https://claude.ai/code/session_01PtSEMRv3SpAEtdGzvYxzpa <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 27 | 14.92 MB → 14.92 MB (+160 B) | +0.00% loot-core | 1 | 5.75 MB | 0% api | 3 | 4.69 MB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 27 | 14.92 MB → 14.92 MB (+160 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/settings/Themes.tsx` | 📈 +86 B (+1.25%) | 6.7 kB → 6.78 kB `src/components/settings/ThemeInstaller.tsx` | 📈 +74 B (+0.70%) | 10.27 kB → 10.34 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 9.57 MB → 9.57 MB (+160 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/indexeddb-main-thread-worker-e59fee74.js | 12.94 kB | 0% static/js/workbox-window.prod.es5.js | 5.64 kB | 0% static/js/ca.js | 187.85 kB | 0% static/js/da.js | 106.13 kB | 0% static/js/de.js | 179.82 kB | 0% static/js/en-GB.js | 7.18 kB | 0% static/js/en.js | 171.21 kB | 0% static/js/es.js | 174.29 kB | 0% static/js/fr.js | 179.34 kB | 0% static/js/it.js | 170.91 kB | 0% static/js/nb-NO.js | 156.74 kB | 0% static/js/nl.js | 113.03 kB | 0% static/js/pl.js | 89.61 kB | 0% static/js/pt-BR.js | 182.82 kB | 0% static/js/th.js | 181.54 kB | 0% static/js/uk.js | 215.25 kB | 0% static/js/resize-observer.js | 18.37 kB | 0% static/js/BackgroundImage.js | 120.54 kB | 0% static/js/ReportRouter.js | 1.16 MB | 0% static/js/narrow.js | 638.11 kB | 0% static/js/TransactionList.js | 106.52 kB | 0% static/js/wide.js | 164.16 kB | 0% static/js/AppliedFilters.js | 9.99 kB | 0% static/js/usePayeeRuleCounts.js | 11.57 kB | 0% static/js/useTransactionBatchActions.js | 13.24 kB | 0% static/js/FormulaEditor.js | 1.04 MB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.75 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Bm3zKqpv.js | 5.75 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 3 | 4.69 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 4.4 MB | 0% index-BKGP2w5F.js | 285.56 kB | 0% multipart-parser-DwddZ4BH.js | 9.33 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 22:11:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#14054
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?