github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6041] [MERGED] Feature: Add Akahu New Zealand bank sync #139782

New Issue
Closed
opened 2026-06-19 06:45:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-19 06:45:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6041
Author: @ItsThatDude
Created: 10/31/2025
Status: ✅ Merged
Merged: 6/6/2026
Merged by: @MatissJanis

Base: master ← Head: feature/akahu-nz-bank-sync

📝 Commits (10+)

  • 02be24a add akahu integration for nz banks
  • a94c24b akahu fix bank name being set to account name
  • 78b6c2b rename apiToken and fix reset pointing to the wrong function
  • 7ee93a4 fix apitoken wording in akahu init modal
  • 8ae21bb add upcoming-release-notes
  • 6b8165c fix lint issues
  • cfbdffb fix lint issues
  • 289a118 Merge branch 'actualbudget:master' into feature/akahu-nz-bank-sync
  • 12b29c8 add loan account type to starting balance inversion
  • 5be67ad fix initial sync balance

📊 Changes

24 files changed (+1029 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/accounts/mutations.ts (+41 -0)
📝 packages/desktop-client/src/components/Modals.tsx (+4 -0)
📝 packages/desktop-client/src/components/banksync/EditSyncAccount.tsx (+6 -0)
📝 packages/desktop-client/src/components/banksync/bankSyncUtils.ts (+2 -0)
📝 packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts (+151 -0)
➕ packages/desktop-client/src/components/modals/AkahuInitialiseModal.tsx (+153 -0)
📝 packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.tsx (+33 -1)
📝 packages/desktop-client/src/components/settings/Experimental.tsx (+6 -0)
➕ packages/desktop-client/src/hooks/useAkahuStatus.ts (+33 -0)
📝 packages/desktop-client/src/hooks/useFeatureFlag.ts (+1 -0)
📝 packages/desktop-client/src/modals/modalsSlice.ts (+6 -0)
📝 packages/loot-core/src/server/accounts/app.ts (+128 -0)
📝 packages/loot-core/src/server/accounts/sync.ts (+49 -0)
📝 packages/loot-core/src/server/server-config.ts (+2 -0)
➕ packages/loot-core/src/types/models/akahu.ts (+8 -0)
📝 packages/loot-core/src/types/models/bank-sync.ts (+1 -0)
📝 packages/loot-core/src/types/models/index.ts (+1 -0)
📝 packages/loot-core/src/types/prefs.ts (+2 -1)
📝 packages/sync-server/package.json (+1 -0)
➕ packages/sync-server/src/app-akahu/app-akahu.ts (+341 -0)

...and 4 more files

📄 Description

Adds the ability to sync with New Zealand banks via Akahu. (https://developers.akahu.nz/docs/getting-started)

Akahu are a NZ based fintech company who specialize in open banking and payment/banking interfacing with all major New Zealand banks (along with some other fund/investment providers as well - https://developers.akahu.nz/docs/integrations)

I've developed this integration for my own personal use and figured there may be other NZers out there who would benefit from it.

Summary by CodeRabbit

  • New Features
    • Added Akahu bank synchronization provider with account linking and account sync (transactions & balances).
    • Added an Akahu setup modal to enter credentials and manage/reset configuration.
    • Added Akahu account discovery and selection during account linking flows.
    • Added Akahu status/check and account-import flows to the server to support in-app linking.

✏️ Tip: You can customize this high-level summary in your review settings.

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.06 MB → 14.07 MB (+10.28 kB) +0.07%
loot-core 1 5.28 MB → 5.28 MB (+3.25 kB) +0.06%
api 2 3.86 MB → 3.86 MB (+3.17 kB) +0.08%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.06 MB → 14.07 MB (+10.28 kB) +0.07%
Changeset
File Δ Size
src/components/modals/AkahuInitialiseModal.tsx 🆕 +4.57 kB 0 B → 4.57 kB
src/hooks/useAkahuStatus.ts 🆕 +602 B 0 B → 602 B
src/components/banksync/useBuiltInBankSyncProviders.ts 📈 +2.97 kB (+26.39%) 11.26 kB → 14.23 kB
src/accounts/mutations.ts 📈 +745 B (+5.42%) 13.42 kB → 14.14 kB
src/hooks/useFeatureFlag.ts 📈 +23 B (+4.01%) 573 B → 596 B
src/components/settings/Experimental.tsx 📈 +284 B (+2.44%) 11.37 kB → 11.65 kB
src/components/modals/SelectLinkedAccountsModal.tsx 📈 +862 B (+1.97%) 42.82 kB → 43.66 kB
src/components/banksync/bankSyncUtils.ts 📈 +28 B (+1.83%) 1.49 kB → 1.52 kB
src/components/banksync/EditSyncAccount.tsx 📈 +133 B (+1.75%) 7.44 kB → 7.57 kB
src/components/Modals.tsx 📈 +125 B (+0.95%) 12.85 kB → 12.97 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 1.56 MB → 1.56 MB (+5.81 kB) +0.36%
static/js/SchedulesTable.js 202.7 kB → 206.26 kB (+3.56 kB) +1.76%
static/js/extends.js 508.06 kB → 508.79 kB (+745 B) +0.14%
static/js/ScheduleEditForm.js 146.44 kB → 146.57 kB (+133 B) +0.09%
static/js/ManageRules.js 46.6 kB → 46.63 kB (+28 B) +0.06%
static/js/Value.js 5.08 MB → 5.08 MB (+23 B) +0.00%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.27 MB 0%
static/js/TransactionEdit.js 90.63 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/_baseIsEqual.js 98.38 kB 0%
static/js/ca.js 186.26 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 100.8 kB 0%
static/js/de.js 170.65 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 200.02 kB 0%
static/js/es.js 178.21 kB 0%
static/js/fr.js 178.06 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 164.53 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 147.72 kB 0%
static/js/nl.js 106.82 kB 0%
static/js/pt-BR.js 187.97 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.31 kB 0%
static/js/theme.js 31.88 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 208.65 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 298.88 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.84 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB → 5.28 MB (+3.25 kB) +0.06%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts 📈 +2.09 kB (+7.46%) 27.96 kB → 30.04 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📈 +1.13 kB (+4.75%) 23.74 kB → 24.87 kB
home/runner/work/actual/actual/packages/loot-core/src/server/server-config.ts 📈 +42 B (+4.36%) 963 B → 1005 B
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.DbcwJgea.js 0 B → 5.28 MB (+5.28 MB) -

Removed

Asset File Size % Changed
kcab.worker.BkkH_8jr.js 5.28 MB → 0 B (-5.28 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
2 3.86 MB → 3.86 MB (+3.17 kB) +0.08%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts 📈 +2.03 kB (+7.44%) 27.26 kB → 29.29 kB
home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts 📈 +1.1 kB (+4.76%) 23.21 kB → 24.32 kB
home/runner/work/actual/actual/packages/loot-core/src/server/server-config.ts 📈 +41 B (+4.41%) 929 B → 970 B
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
index.js 3.86 MB → 3.86 MB (+3.17 kB) +0.08%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6041 **Author:** [@ItsThatDude](https://github.com/ItsThatDude) **Created:** 10/31/2025 **Status:** ✅ Merged **Merged:** 6/6/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `feature/akahu-nz-bank-sync` --- ### 📝 Commits (10+) - [`02be24a`](https://github.com/actualbudget/actual/commit/02be24adb7fd32965b6fdfe289bdfcb71d57c731) add akahu integration for nz banks - [`a94c24b`](https://github.com/actualbudget/actual/commit/a94c24b3b118e44bc8958e739c2dc92679cc5946) akahu fix bank name being set to account name - [`78b6c2b`](https://github.com/actualbudget/actual/commit/78b6c2bac1194e54e00179ca74a784bb568b4530) rename apiToken and fix reset pointing to the wrong function - [`7ee93a4`](https://github.com/actualbudget/actual/commit/7ee93a4bda19e275a792c6fea23613d59012469d) fix apitoken wording in akahu init modal - [`8ae21bb`](https://github.com/actualbudget/actual/commit/8ae21bbac7be3a96e1f80af8e5037b55f761e0a1) add upcoming-release-notes - [`6b8165c`](https://github.com/actualbudget/actual/commit/6b8165c45bf317c8e32b3b5341156f9e6d8b1419) fix lint issues - [`cfbdffb`](https://github.com/actualbudget/actual/commit/cfbdffbf5213bfaf8bd7646bc59c8474d9de5aa4) fix lint issues - [`289a118`](https://github.com/actualbudget/actual/commit/289a1182cf249c49aa7a6c6974e83ef27413b799) Merge branch 'actualbudget:master' into feature/akahu-nz-bank-sync - [`12b29c8`](https://github.com/actualbudget/actual/commit/12b29c808148b630eef4391954b118235cdb6c63) add loan account type to starting balance inversion - [`5be67ad`](https://github.com/actualbudget/actual/commit/5be67ad0d9d78d6fbb4aa934cc79ec16dbec4fed) fix initial sync balance ### 📊 Changes **24 files changed** (+1029 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/accounts/mutations.ts` (+41 -0) 📝 `packages/desktop-client/src/components/Modals.tsx` (+4 -0) 📝 `packages/desktop-client/src/components/banksync/EditSyncAccount.tsx` (+6 -0) 📝 `packages/desktop-client/src/components/banksync/bankSyncUtils.ts` (+2 -0) 📝 `packages/desktop-client/src/components/banksync/useBuiltInBankSyncProviders.ts` (+151 -0) ➕ `packages/desktop-client/src/components/modals/AkahuInitialiseModal.tsx` (+153 -0) 📝 `packages/desktop-client/src/components/modals/SelectLinkedAccountsModal.tsx` (+33 -1) 📝 `packages/desktop-client/src/components/settings/Experimental.tsx` (+6 -0) ➕ `packages/desktop-client/src/hooks/useAkahuStatus.ts` (+33 -0) 📝 `packages/desktop-client/src/hooks/useFeatureFlag.ts` (+1 -0) 📝 `packages/desktop-client/src/modals/modalsSlice.ts` (+6 -0) 📝 `packages/loot-core/src/server/accounts/app.ts` (+128 -0) 📝 `packages/loot-core/src/server/accounts/sync.ts` (+49 -0) 📝 `packages/loot-core/src/server/server-config.ts` (+2 -0) ➕ `packages/loot-core/src/types/models/akahu.ts` (+8 -0) 📝 `packages/loot-core/src/types/models/bank-sync.ts` (+1 -0) 📝 `packages/loot-core/src/types/models/index.ts` (+1 -0) 📝 `packages/loot-core/src/types/prefs.ts` (+2 -1) 📝 `packages/sync-server/package.json` (+1 -0) ➕ `packages/sync-server/src/app-akahu/app-akahu.ts` (+341 -0) _...and 4 more files_ </details> ### 📄 Description Adds the ability to sync with New Zealand banks via Akahu. (https://developers.akahu.nz/docs/getting-started) Akahu are a NZ based fintech company who specialize in open banking and payment/banking interfacing with all major New Zealand banks (along with some other fund/investment providers as well - https://developers.akahu.nz/docs/integrations) I've developed this integration for my own personal use and figured there may be other NZers out there who would benefit from it. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added Akahu bank synchronization provider with account linking and account sync (transactions & balances). * Added an Akahu setup modal to enter credentials and manage/reset configuration. * Added Akahu account discovery and selection during account linking flows. * Added Akahu status/check and account-import flows to the server to support in-app linking. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.06 MB → 14.07 MB (+10.28 kB) | +0.07% loot-core | 1 | 5.28 MB → 5.28 MB (+3.25 kB) | +0.06% api | 2 | 3.86 MB → 3.86 MB (+3.17 kB) | +0.08% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.06 MB → 14.07 MB (+10.28 kB) | +0.07% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/modals/AkahuInitialiseModal.tsx` | 🆕 +4.57 kB | 0 B → 4.57 kB `src/hooks/useAkahuStatus.ts` | 🆕 +602 B | 0 B → 602 B `src/components/banksync/useBuiltInBankSyncProviders.ts` | 📈 +2.97 kB (+26.39%) | 11.26 kB → 14.23 kB `src/accounts/mutations.ts` | 📈 +745 B (+5.42%) | 13.42 kB → 14.14 kB `src/hooks/useFeatureFlag.ts` | 📈 +23 B (+4.01%) | 573 B → 596 B `src/components/settings/Experimental.tsx` | 📈 +284 B (+2.44%) | 11.37 kB → 11.65 kB `src/components/modals/SelectLinkedAccountsModal.tsx` | 📈 +862 B (+1.97%) | 42.82 kB → 43.66 kB `src/components/banksync/bankSyncUtils.ts` | 📈 +28 B (+1.83%) | 1.49 kB → 1.52 kB `src/components/banksync/EditSyncAccount.tsx` | 📈 +133 B (+1.75%) | 7.44 kB → 7.57 kB `src/components/Modals.tsx` | 📈 +125 B (+0.95%) | 12.85 kB → 12.97 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.56 MB → 1.56 MB (+5.81 kB) | +0.36% static/js/SchedulesTable.js | 202.7 kB → 206.26 kB (+3.56 kB) | +1.76% static/js/extends.js | 508.06 kB → 508.79 kB (+745 B) | +0.14% static/js/ScheduleEditForm.js | 146.44 kB → 146.57 kB (+133 B) | +0.09% static/js/ManageRules.js | 46.6 kB → 46.63 kB (+28 B) | +0.06% static/js/Value.js | 5.08 MB → 5.08 MB (+23 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.27 MB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 186.26 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 100.8 kB | 0% static/js/de.js | 170.65 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 200.02 kB | 0% static/js/es.js | 178.21 kB | 0% static/js/fr.js | 178.06 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 164.53 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 147.72 kB | 0% static/js/nl.js | 106.82 kB | 0% static/js/pt-BR.js | 187.97 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.31 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 208.65 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 298.88 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.84 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB → 5.28 MB (+3.25 kB) | +0.06% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts` | 📈 +2.09 kB (+7.46%) | 27.96 kB → 30.04 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📈 +1.13 kB (+4.75%) | 23.74 kB → 24.87 kB `home/runner/work/actual/actual/packages/loot-core/src/server/server-config.ts` | 📈 +42 B (+4.36%) | 963 B → 1005 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DbcwJgea.js | 0 B → 5.28 MB (+5.28 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BkkH_8jr.js | 5.28 MB → 0 B (-5.28 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.86 MB → 3.86 MB (+3.17 kB) | +0.08% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts` | 📈 +2.03 kB (+7.44%) | 27.26 kB → 29.29 kB `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/sync.ts` | 📈 +1.1 kB (+4.76%) | 23.21 kB → 24.32 kB `home/runner/work/actual/actual/packages/loot-core/src/server/server-config.ts` | 📈 +41 B (+4.41%) | 929 B → 970 B </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.86 MB → 3.86 MB (+3.17 kB) | +0.08% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-19 06:45:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#139782
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?